[{"id":308,"web_url":"https://patchwork.libcamera.org/comment/308/","msgid":"<5978594.i6M3oNiWt5@avalon>","date":"2019-01-14T17:07:10","subject":"Re: [libcamera-devel] [PATCH] meson: Utilise default compiler\n\toptions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Monday, 14 January 2019 12:03:46 EET Kieran Bingham wrote:\n> Remove our custom declarations for cpp_std=c++11 and -Werror, instead\n> prefering to use the built-in default_option parameters from meson.\n> \n> Our custom compiler flags (such as -Wno-unused-parameter) are\n> maintained.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> meson.build | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 0ab0da981083..37640c39f5b8 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,6 +1,11 @@\n> project('libcamera', 'c', 'cpp',\n> meson_version: '>= 0.40',\n> version : '0.1',\n> + default_options: [\n> + 'werror=true',\n> + 'warning_level=2',\n> + 'cpp_std=c++11',\n> + ],\n> license : 'LGPL 2.1+')\n> \n> # TODO: Extract this from project.version.\n> @@ -11,13 +16,11 @@ api_version = '0.1'\n> common_arguments = [\n> '-Wall',\n> '-Wextra',\n\nI think warning_level=2 adds -Wextra, and all warning levels include -Wall for \nboth clang and gcc.\n\nApart from that,\n\nReviewed-by: Laurent Pinchart \n\n> - '-Werror',\n> '-Wno-unused-parameter',\n> ]\n> \n> c_arguments = common_arguments\n> cpp_arguments = common_arguments\n> -cpp_arguments += '-std=c++11'\n> \n> add_project_arguments(c_arguments, language: 'c')\n> add_project_arguments(cpp_arguments, language: 'cpp')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB60060C6A\n\tfor ;\n\tMon, 14 Jan 2019 18:05:55 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28289530;\n\tMon, 14 Jan 2019 18:05:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547485555;\n\tbh=Ibe01RsEA/NTKJpXqZPzxp/UXEJiQ4UR8jls+aiNaW0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wmjZ8Q3YnUbnCXlV946huxX653+daP1BjbaoaHmpCsP3N6omwlL17Ib3CX5K4DoxZ\n\tJqeoFCNEG5dPNx6KdUgoMiUCyli+eZCg5uRh25TsxTTv62Js8IXY0iwp5Ym5L5wW8x\n\t1JNknDLFHGh0yrf28Mt3CeBRSeSKDrbz4+r5eC5c=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Jan 2019 19:07:10 +0200","Message-ID":"<5978594.i6M3oNiWt5@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190114100346.17925-1-kieran.bingham@ideasonboard.com>","References":"<20190114100346.17925-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] meson: Utilise default compiler\n\toptions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 14 Jan 2019 17:05:55 -0000"}}]