[{"id":33060,"web_url":"https://patchwork.libcamera.org/comment/33060/","msgid":"<Z4WSPzlPkMgwp6uE@pyrite.rasen.tech>","date":"2025-01-13T22:22:55","subject":"Re: [PATCH v1 03/11] libipa: Add AWB algorithm base class","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jan 09, 2025 at 12:53:54PM +0100, Stefan Klug wrote:\n> Add a class to provide a generic interface for auto white balance\n> algorithms. Concrete AWB algorithms are expected to subclass the\n> AwbAlgorithm class to implement their functionality.\n> \n> Pipeline handlers are expected to subclass the AwbStats class and\n> implement the necessary function to give the algorithm access to the\n> hardware specific statistics data.\n> \n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\nThe code/design looks great. Just some english comments...\n\n> ---\n>  src/ipa/libipa/awb.cpp     | 137 +++++++++++++++++++++++++++++++++++++\n>  src/ipa/libipa/awb.h       |  51 ++++++++++++++\n>  src/ipa/libipa/meson.build |   2 +\n>  3 files changed, 190 insertions(+)\n>  create mode 100644 src/ipa/libipa/awb.cpp\n>  create mode 100644 src/ipa/libipa/awb.h\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> new file mode 100644\n> index 000000000000..74e88d513b27\n> --- /dev/null\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -0,0 +1,137 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Ideas on Board Oy\n> + *\n> + * Generic AWB algorithms\n> + */\n> +\n> +#include \"awb.h\"\n> +\n> +#include <libcamera/base/log.h>\n> +\n> +/**\n> + * \\file awb.h\n> + * \\brief Base classes for AWB algorithms\n> + */\n> +\n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(Awb)\n> +\n> +namespace ipa {\n> +\n> +/**\n> + * \\class AwbResult\n> + * \\brief The result of an awb calculation\n> + *\n> + * This class holds the result of an auto white balance calculation.\n> + */\n> +\n> +/**\n> + * \\var AwbResult::gains\n> + * \\brief The calculated white balance gains\n> + */\n> +\n> +/**\n> + * \\var AwbResult::colourTemperature\n> + * \\brief The calculated colour temperature in Kelvin\n> + */\n> +\n> +/**\n> + * \\class AwbStats\n> + * \\brief A abstract class wrapping system specific AWB statistics\n\nI think \"An abstract class that wraps system-specific AWB statistics\"\nmight be better.\n\n> + *\n> + * Pipline handlers using an AWB algorithm based on the AwbAlgorithm class need\n\ns/Pipline/Pipeline/\n\n> + * to implement this class to give the algorithm access to the hardware specific\n\ns/hardware specific/hardware-specific/\n\n> + * statics data.\n\ns/statics/statistics/\n\n> + */\n> +\n> +/**\n> + * \\fn AwbStats::computeColourError\n> + * \\brief Compute an error value for when the given gains would be applied\n> + * \\param[in] gains The gains to apply\n> + *\n> + * Compute an error value (non-greyness) assuming the given \\a gains would be\n> + * applied. To keep the actual implementations computationally inexpensive,\n> + * the squared colour error shall be returned.\n> + *\n> + * If the awb statistics provide multiple zones, the sum over all zones needs to\n> + * calculated.\n> + *\n> + * \\return The computed error value\n> + */\n> +\n> +/**\n> + * \\fn AwbStats::getRGBMeans\n> + * \\brief Get RGB means of the statistics\n> + *\n> + * Fetch the RGB means from the statistics. The values of each channel are\n> + * dimensionless and only the ratios are used for further calculations. This is\n> + * used by the simple gray world model to calculate the gains to apply.\n> + *\n> + * \\return The RGB means\n> + */\n> +\n> +/**\n> + * \\class AwbAlgorithm\n> + * \\brief A base class for auto white balance algorithms\n> + *\n> + * This class is a base class for auto white balance algorithms. It provides an\n> + * interface for the algorithms to implement, and is used by the pipeline\n> + * handler to interact with the concrete implementation.\n\nI thought the IPAs interact with the algos and not the pipeline\nhandler... (unless there's a surprise in later patches that I haven't\nseen yet).\n\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::init\n> + * \\brief Initialize the algorithm with the given tuning data\n> + * \\param[in] tuningData The tuning data to use for the algorithm\n> + *\n> + * \\return 0 on success, a negative error code otherwise\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::calculateAwb\n> + * \\brief Calculate awb data from the given statistics\n> + * \\param[in] stats The statistics to use for the calculation\n> + * \\param[in] lux The lux value of the scene\n> + *\n> + * Calculate a AwbResult object from the given statistics and lux value. A \\a\n\ns/ a / an /\n\n> + * lux value of 0 means it is unknown or invalid and the algorithm shall ignore\n> + * it.\n> + *\n> + * \\return The awb result\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::gainsFromColourTemperature\n> + * \\brief Compute white balance gains from a colour temperature\n> + * \\param[in] colourTemperature The colour temperature in Kelvin\n> + *\n> + * Compute the white balance gains from a \\a colourTemperature. This function\n> + * does not take any statistics into account. It is used to compute the colour\n> + * gains when the user manually specifies a colour temperature.\n> + *\n> + * \\return The colour gains\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::controls\n> + * \\brief Get the controls info map for this algorithm\n> + *\n> + * \\return The controls info map\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::handleControls\n\nA bit of bikeshedding perhaps but personally I'd prefer \"processControls\". Up to you though :)\n\n\nThanks,\n\nPaul\n\n> + * \\param[in] controls The controls to handle\n> + * \\brief Handle the controls supplied in a request\n> + */\n> +\n> +/**\n> + * \\var AwbAlgorithm::controls_\n> + * \\brief Controls info map for the controls provided by the algorithm\n> + */\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> new file mode 100644\n> index 000000000000..2dd471606ec4\n> --- /dev/null\n> +++ b/src/ipa/libipa/awb.h\n> @@ -0,0 +1,51 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Ideas on Board Oy\n> + *\n> + * Generic AWB algorithms\n> + */\n> +\n> +#pragma once\n> +\n> +#include <libcamera/controls.h>\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \"vector.h\"\n> +\n> +namespace libcamera {\n> +\n> +namespace ipa {\n> +\n> +struct AwbResult {\n> +\tRGB<double> gains;\n> +\tdouble colourTemperature;\n> +};\n> +\n> +struct AwbStats {\n> +\tvirtual double computeColourError(const RGB<double> &gains) const = 0;\n> +\tvirtual RGB<double> getRGBMeans() const = 0;\n> +};\n> +\n> +class AwbAlgorithm\n> +{\n> +public:\n> +\tvirtual ~AwbAlgorithm() = default;\n> +\n> +\tvirtual int init(const YamlObject &tuningData) = 0;\n> +\tvirtual AwbResult calculateAwb(const AwbStats &stats, int lux) = 0;\n> +\tvirtual RGB<double> gainsFromColourTemperature(double colourTemperature) = 0;\n> +\n> +\tconst ControlInfoMap::Map &controls() const\n> +\t{\n> +\t\treturn controls_;\n> +\t}\n> +\n> +\tvirtual void handleControls([[maybe_unused]] const ControlList &controls) {}\n> +\n> +protected:\n> +\tControlInfoMap::Map controls_;\n> +};\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index f2b2f4be50db..03e879c5834f 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -3,6 +3,7 @@\n>  libipa_headers = files([\n>      'agc_mean_luminance.h',\n>      'algorithm.h',\n> +    'awb.h',\n>      'camera_sensor_helper.h',\n>      'colours.h',\n>      'exposure_mode_helper.h',\n> @@ -20,6 +21,7 @@ libipa_headers = files([\n>  libipa_sources = files([\n>      'agc_mean_luminance.cpp',\n>      'algorithm.cpp',\n> +    'awb.cpp',\n>      'camera_sensor_helper.cpp',\n>      'colours.cpp',\n>      'exposure_mode_helper.cpp',\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FC29BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jan 2025 22:23:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 749E76851C;\n\tMon, 13 Jan 2025 23:23:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1114B684E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jan 2025 23:23:31 +0100 (CET)","from pyrite.rasen.tech (unknown [173.16.167.215])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7943B74A;\n\tMon, 13 Jan 2025 23:22:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fC33W75I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736806954;\n\tbh=BS1Y7ErH0M/WJVahtcsUMrtt8hIec2QQw3lcvvxUFyU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fC33W75IKmmHmrZGRZNNVI3vv9mCe49xxXR9L47hCvmGxpV07eZ3DUI4fxrw3Uv04\n\tDfqoGLezppVVK++SCdTV4ucutz/aI5aHwT1V4iE6qfIayLGqpNQpCPlw8/fXLUQIeT\n\tmOfZk8EpKN9H/yNKaJ6gw7ligyYRfvzIr6m8qoQE=","Date":"Mon, 13 Jan 2025 16:22:55 -0600","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"Stefan Klug <stefan.klug@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 03/11] libipa: Add AWB algorithm base class","Message-ID":"<Z4WSPzlPkMgwp6uE@pyrite.rasen.tech>","References":"<20250109115412.356768-1-stefan.klug@ideasonboard.com>\n\t<20250109115412.356768-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250109115412.356768-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":33092,"web_url":"https://patchwork.libcamera.org/comment/33092/","msgid":"<20f28688-1b73-4e45-9303-322781f69989@ideasonboard.com>","date":"2025-01-17T14:30:29","subject":"Re: [PATCH v1 03/11] libipa: Add AWB algorithm base class","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan, thanks for the cool set\n\nOn 09/01/2025 11:53, Stefan Klug wrote:\n> Add a class to provide a generic interface for auto white balance\n> algorithms. Concrete AWB algorithms are expected to subclass the\n> AwbAlgorithm class to implement their functionality.\n>\n> Pipeline handlers are expected to subclass the AwbStats class and\n> implement the necessary function to give the algorithm access to the\n> hardware specific statistics data.\n\n\nThat sounds strange; I'd expect the IPA to handle that rather than the PipelineHandler\n\n>\n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> ---\n>   src/ipa/libipa/awb.cpp     | 137 +++++++++++++++++++++++++++++++++++++\n>   src/ipa/libipa/awb.h       |  51 ++++++++++++++\n>   src/ipa/libipa/meson.build |   2 +\n>   3 files changed, 190 insertions(+)\n>   create mode 100644 src/ipa/libipa/awb.cpp\n>   create mode 100644 src/ipa/libipa/awb.h\n>\n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> new file mode 100644\n> index 000000000000..74e88d513b27\n> --- /dev/null\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -0,0 +1,137 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Ideas on Board Oy\n> + *\n> + * Generic AWB algorithms\n> + */\n> +\n> +#include \"awb.h\"\n> +\n> +#include <libcamera/base/log.h>\n> +\n> +/**\n> + * \\file awb.h\n> + * \\brief Base classes for AWB algorithms\n> + */\n> +\n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(Awb)\n> +\n> +namespace ipa {\n> +\n> +/**\n> + * \\class AwbResult\n> + * \\brief The result of an awb calculation\n> + *\n> + * This class holds the result of an auto white balance calculation.\n> + */\n> +\n> +/**\n> + * \\var AwbResult::gains\n> + * \\brief The calculated white balance gains\n> + */\n> +\n> +/**\n> + * \\var AwbResult::colourTemperature\n> + * \\brief The calculated colour temperature in Kelvin\n> + */\n> +\n> +/**\n> + * \\class AwbStats\n> + * \\brief A abstract class wrapping system specific AWB statistics\ns/A/An here, and I think I'd say \"An abstraction class wrapping hardware specific...\" but that's \njust bikeshedding so feel free to ignore it.\n> + *\n> + * Pipline handlers using an AWB algorithm based on the AwbAlgorithm class need\n> + * to implement this class to give the algorithm access to the hardware specific\n> + * statics data.\ns/statics/statistics\n> + */\n> +\n> +/**\n> + * \\fn AwbStats::computeColourError\n> + * \\brief Compute an error value for when the given gains would be applied\n> + * \\param[in] gains The gains to apply\n> + *\n> + * Compute an error value (non-greyness) assuming the given \\a gains would be\n> + * applied. To keep the actual implementations computationally inexpensive,\n> + * the squared colour error shall be returned.\n> + *\n> + * If the awb statistics provide multiple zones, the sum over all zones needs to\n> + * calculated.\n> + *\n> + * \\return The computed error value\n> + */\n> +\n> +/**\n> + * \\fn AwbStats::getRGBMeans\n> + * \\brief Get RGB means of the statistics\n> + *\n> + * Fetch the RGB means from the statistics. The values of each channel are\n> + * dimensionless and only the ratios are used for further calculations. This is\n> + * used by the simple gray world model to calculate the gains to apply.\n> + *\n> + * \\return The RGB means\n> + */\n> +\n> +/**\n> + * \\class AwbAlgorithm\n> + * \\brief A base class for auto white balance algorithms\n> + *\n> + * This class is a base class for auto white balance algorithms. It provides an\n> + * interface for the algorithms to implement, and is used by the pipeline\n> + * handler to interact with the concrete implementation.\n\nI think s/provides/defines, and it should be used by the IPA rather than the pipeline handler.\n\n\nOtherwise, looks good:\n\n\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::init\n> + * \\brief Initialize the algorithm with the given tuning data\n> + * \\param[in] tuningData The tuning data to use for the algorithm\n> + *\n> + * \\return 0 on success, a negative error code otherwise\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::calculateAwb\n> + * \\brief Calculate awb data from the given statistics\n> + * \\param[in] stats The statistics to use for the calculation\n> + * \\param[in] lux The lux value of the scene\n> + *\n> + * Calculate a AwbResult object from the given statistics and lux value. A \\a\n> + * lux value of 0 means it is unknown or invalid and the algorithm shall ignore\n> + * it.\n> + *\n> + * \\return The awb result\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::gainsFromColourTemperature\n> + * \\brief Compute white balance gains from a colour temperature\n> + * \\param[in] colourTemperature The colour temperature in Kelvin\n> + *\n> + * Compute the white balance gains from a \\a colourTemperature. This function\n> + * does not take any statistics into account. It is used to compute the colour\n> + * gains when the user manually specifies a colour temperature.\n> + *\n> + * \\return The colour gains\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::controls\n> + * \\brief Get the controls info map for this algorithm\n> + *\n> + * \\return The controls info map\n> + */\n> +\n> +/**\n> + * \\fn AwbAlgorithm::handleControls\n> + * \\param[in] controls The controls to handle\n> + * \\brief Handle the controls supplied in a request\n> + */\n> +\n> +/**\n> + * \\var AwbAlgorithm::controls_\n> + * \\brief Controls info map for the controls provided by the algorithm\n> + */\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> new file mode 100644\n> index 000000000000..2dd471606ec4\n> --- /dev/null\n> +++ b/src/ipa/libipa/awb.h\n> @@ -0,0 +1,51 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Ideas on Board Oy\n> + *\n> + * Generic AWB algorithms\n> + */\n> +\n> +#pragma once\n> +\n> +#include <libcamera/controls.h>\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \"vector.h\"\n> +\n> +namespace libcamera {\n> +\n> +namespace ipa {\n> +\n> +struct AwbResult {\n> +\tRGB<double> gains;\n> +\tdouble colourTemperature;\n> +};\n> +\n> +struct AwbStats {\n> +\tvirtual double computeColourError(const RGB<double> &gains) const = 0;\n> +\tvirtual RGB<double> getRGBMeans() const = 0;\n> +};\n> +\n> +class AwbAlgorithm\n> +{\n> +public:\n> +\tvirtual ~AwbAlgorithm() = default;\n> +\n> +\tvirtual int init(const YamlObject &tuningData) = 0;\n> +\tvirtual AwbResult calculateAwb(const AwbStats &stats, int lux) = 0;\n> +\tvirtual RGB<double> gainsFromColourTemperature(double colourTemperature) = 0;\n> +\n> +\tconst ControlInfoMap::Map &controls() const\n> +\t{\n> +\t\treturn controls_;\n> +\t}\n> +\n> +\tvirtual void handleControls([[maybe_unused]] const ControlList &controls) {}\n> +\n> +protected:\n> +\tControlInfoMap::Map controls_;\n> +};\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index f2b2f4be50db..03e879c5834f 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -3,6 +3,7 @@\n>   libipa_headers = files([\n>       'agc_mean_luminance.h',\n>       'algorithm.h',\n> +    'awb.h',\n>       'camera_sensor_helper.h',\n>       'colours.h',\n>       'exposure_mode_helper.h',\n> @@ -20,6 +21,7 @@ libipa_headers = files([\n>   libipa_sources = files([\n>       'agc_mean_luminance.cpp',\n>       'algorithm.cpp',\n> +    'awb.cpp',\n>       'camera_sensor_helper.cpp',\n>       'colours.cpp',\n>       'exposure_mode_helper.cpp',","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCE49C3273\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Jan 2025 14:30:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7B8E68545;\n\tFri, 17 Jan 2025 15:30:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7CB668516\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2025 15:30:31 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79B176DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2025 15:29:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q5mx772q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737124172;\n\tbh=VCArOL/JfZIp9dSxoCdzl8kGxw98vRIdDNUM64WWHBk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=q5mx772qrSUt1kTNpd9u4LIROsOO2Ocu1eH3XfM9yKTI9SLx05vUXMH1yF990SUVW\n\tdHvBKYhKndgldJT/++VPV2DLChqXW52HPJAAGg/CMqG2VBxI1wUuQcBZ/rTLj/dNen\n\tDdm5V18aaH2lRXzu998mveUYraDSJDyY9vXdWe68=","Message-ID":"<20f28688-1b73-4e45-9303-322781f69989@ideasonboard.com>","Date":"Fri, 17 Jan 2025 14:30:29 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 03/11] libipa: Add AWB algorithm base class","To":"libcamera-devel@lists.libcamera.org","References":"<20250109115412.356768-1-stefan.klug@ideasonboard.com>\n\t<20250109115412.356768-4-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally <dan.scally@ideasonboard.com>","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250109115412.356768-4-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]