[{"id":33058,"web_url":"https://patchwork.libcamera.org/comment/33058/","msgid":"","date":"2025-01-13T22:09:44","subject":"Re: [PATCH v1 01/11] libipa: interpolator: Add accessor to internal\n\tdata","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jan 09, 2025 at 12:53:52PM +0100, Stefan Klug wrote:\n> The only way to access the internal data of an Interpolator is through\n> the getInterpolated() method. Sometimes it is necessary to to access the\n> internal data directly to iterate over it. Add an accessor for that.\n> \n> While at it, remove a line break from the doxygen documentation for\n> interpolate() so that doxygen is able to correctly match the function.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/interpolator.cpp | 10 ++++++++--\n> src/ipa/libipa/interpolator.h | 5 +++++\n> 2 files changed, 13 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/interpolator.cpp b/src/ipa/libipa/interpolator.cpp\n> index 73e8d3b7de14..f901a86e4c74 100644\n> --- a/src/ipa/libipa/interpolator.cpp\n> +++ b/src/ipa/libipa/interpolator.cpp\n> @@ -125,6 +125,13 @@ namespace ipa {\n> * Overwrites the internal map using move semantics.\n> */\n> \n> +/**\n> + * \\fn std::map &Interpolator::data() const\n> + * \\brief Access the internal map\n> + *\n> + * \\return The internal map\n> + */\n> +\n> /**\n> * \\fn const T& Interpolator::getInterpolated()\n> * \\brief Retrieve an interpolated value for the given key\n> @@ -136,8 +143,7 @@ namespace ipa {\n> */\n> \n> /**\n> - * \\fn void Interpolator::interpolate(const T &a, const T &b, T &dest, double\n> - * lambda)\n> + * \\fn void Interpolator::interpolate(const T &a, const T &b, T &dest, double lambda)\n> * \\brief Interpolate between two instances of T\n> * \\param a The first value to interpolate\n> * \\param b The second value to interpolate\n> diff --git a/src/ipa/libipa/interpolator.h b/src/ipa/libipa/interpolator.h\n> index fffce21465fe..7880db6976d1 100644\n> --- a/src/ipa/libipa/interpolator.h\n> +++ b/src/ipa/libipa/interpolator.h\n> @@ -81,6 +81,11 @@ public:\n> \t\tlastInterpolatedKey_.reset();\n> \t}\n> \n> +\tconst std::map &data() const\n> +\t{\n> +\t\treturn data_;\n> +\t}\n> +\n> \tconst T &getInterpolated(unsigned int key, unsigned int *quantizedKey = nullptr)\n> \t{\n> \t\tASSERT(data_.size() > 0);\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA8FCC326C\n\tfor ;\n\tMon, 13 Jan 2025 22:10:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2443D68536;\n\tMon, 13 Jan 2025 23:10:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 902AE684E7\n\tfor ;\n\tMon, 13 Jan 2025 23:10:20 +0100 (CET)","from pyrite.rasen.tech (unknown [173.16.167.215])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23CBE63F;\n\tMon, 13 Jan 2025 23:09:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"osvFtVxT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736806163;\n\tbh=TbNwFhsFlLo8eiUWvRl52pMOfcLvxwJ1SB+RJVgnu6c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=osvFtVxTCVAq+nxMf0x5rPd0G73eux+IeHJBA0NtV+vAOl5i1oAg0Eg0JUilnEYig\n\tWT/P5S1BVaCGkQxcu3eSfAxJAF5eyWvKMpr24u9LEWyB05jEmDKCx1vAGQDd7mO1WU\n\tErQKLNXuM86/lWfTTt+F2XpY7vNfDE4cbULY0QFU=","Date":"Mon, 13 Jan 2025 16:09:44 -0600","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 01/11] libipa: interpolator: Add accessor to internal\n\tdata","Message-ID":"","References":"<20250109115412.356768-1-stefan.klug@ideasonboard.com>\n\t<20250109115412.356768-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250109115412.356768-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33085,"web_url":"https://patchwork.libcamera.org/comment/33085/","msgid":"<0ecb1890-43e2-4335-bd04-51885f3e1523@ideasonboard.com>","date":"2025-01-15T22:46:14","subject":"Re: [PATCH v1 01/11] libipa: interpolator: Add accessor to internal\n\tdata","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 09/01/2025 11:53, Stefan Klug wrote:\n> The only way to access the internal data of an Interpolator is through\n> the getInterpolated() method. Sometimes it is necessary to to access the\n> internal data directly to iterate over it. Add an accessor for that.\n>\n> While at it, remove a line break from the doxygen documentation for\n> interpolate() so that doxygen is able to correctly match the function.\n>\n> Signed-off-by: Stefan Klug \n\n\nReviewed-by: Daniel Scally \n\n> ---\n> src/ipa/libipa/interpolator.cpp | 10 ++++++++--\n> src/ipa/libipa/interpolator.h | 5 +++++\n> 2 files changed, 13 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/libipa/interpolator.cpp b/src/ipa/libipa/interpolator.cpp\n> index 73e8d3b7de14..f901a86e4c74 100644\n> --- a/src/ipa/libipa/interpolator.cpp\n> +++ b/src/ipa/libipa/interpolator.cpp\n> @@ -125,6 +125,13 @@ namespace ipa {\n> * Overwrites the internal map using move semantics.\n> */\n> \n> +/**\n> + * \\fn std::map &Interpolator::data() const\n> + * \\brief Access the internal map\n> + *\n> + * \\return The internal map\n> + */\n> +\n> /**\n> * \\fn const T& Interpolator::getInterpolated()\n> * \\brief Retrieve an interpolated value for the given key\n> @@ -136,8 +143,7 @@ namespace ipa {\n> */\n> \n> /**\n> - * \\fn void Interpolator::interpolate(const T &a, const T &b, T &dest, double\n> - * lambda)\n> + * \\fn void Interpolator::interpolate(const T &a, const T &b, T &dest, double lambda)\n> * \\brief Interpolate between two instances of T\n> * \\param a The first value to interpolate\n> * \\param b The second value to interpolate\n> diff --git a/src/ipa/libipa/interpolator.h b/src/ipa/libipa/interpolator.h\n> index fffce21465fe..7880db6976d1 100644\n> --- a/src/ipa/libipa/interpolator.h\n> +++ b/src/ipa/libipa/interpolator.h\n> @@ -81,6 +81,11 @@ public:\n> \t\tlastInterpolatedKey_.reset();\n> \t}\n> \n> +\tconst std::map &data() const\n> +\t{\n> +\t\treturn data_;\n> +\t}\n> +\n> \tconst T &getInterpolated(unsigned int key, unsigned int *quantizedKey = nullptr)\n> \t{\n> \t\tASSERT(data_.size() > 0);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DC8EC32FE\n\tfor ;\n\tWed, 15 Jan 2025 22:46:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E582968521;\n\tWed, 15 Jan 2025 23:46:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3212C605BF\n\tfor ;\n\tWed, 15 Jan 2025 23:46:17 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2733422E\n\tfor ;\n\tWed, 15 Jan 2025 23:45:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LiouV7Le\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736981119;\n\tbh=gxSnJeUatXIuj5cCV2idwDKhDemOje2I20FDXPW1ag8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=LiouV7LeMT8eLiGOoMSHvx8BJur90HdejEEuOP6ngtV7/IAgNpviJAp1PKk0AGI/S\n\t3GKxrRqC7bcRqiyBpZKp3890eK9Hid9bgKGxcg3WXYFrO9ldfZNoFxpth++ka0Ayt/\n\tY4ROEZ5a+zmhFYzAJjs8a3wutWlgGmmks0xvVGCU=","Message-ID":"<0ecb1890-43e2-4335-bd04-51885f3e1523@ideasonboard.com>","Date":"Wed, 15 Jan 2025 22:46:14 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 01/11] libipa: interpolator: Add accessor to internal\n\tdata","To":"libcamera-devel@lists.libcamera.org","References":"<20250109115412.356768-1-stefan.klug@ideasonboard.com>\n\t<20250109115412.356768-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250109115412.356768-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]