[{"id":32973,"web_url":"https://patchwork.libcamera.org/comment/32973/","msgid":"<173641573030.2992722.2900556239305351031@ping.linuxembedded.co.uk>","date":"2025-01-09T09:42:10","subject":"Re: [PATCH] libcamera: include: Include missing stdint.h header","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-01-09 01:45:06)\n> Many libcamera headers that use standard C integer types do not include\n> stdint.h. Fix the omission.\n> \n\nI still wonder how we can get IWYU https://include-what-you-use.org/\ninto the ci loop sometime.\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  include/libcamera/base/utils.h                    | 1 +\n>  include/libcamera/internal/camera.h               | 1 +\n>  include/libcamera/internal/camera_lens.h          | 1 +\n>  include/libcamera/internal/camera_sensor.h        | 1 +\n>  include/libcamera/internal/framebuffer.h          | 1 +\n>  include/libcamera/internal/ipa_data_serializer.h  | 1 +\n>  include/libcamera/internal/ipc_pipe.h             | 1 +\n>  include/libcamera/internal/ipc_pipe_unixsocket.h  | 1 +\n>  include/libcamera/internal/request.h              | 1 +\n>  include/libcamera/internal/tracepoints/request.tp | 2 ++\n>  include/libcamera/internal/v4l2_device.h          | 1 +\n>  include/libcamera/internal/v4l2_subdevice.h       | 1 +\n>  12 files changed, 13 insertions(+)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 780aeda6a0ce732a..8d5c35782ee34e24 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -13,6 +13,7 @@\n>  #include <iterator>\n>  #include <ostream>\n>  #include <sstream>\n> +#include <stdint.h>\n>  #include <string.h>\n>  #include <string>\n>  #include <sys/time.h>\n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 2bb00bbcb6442b36..18f5c32a18e4def7 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -11,6 +11,7 @@\n>  #include <list>\n>  #include <memory>\n>  #include <set>\n> +#include <stdint.h>\n>  #include <string>\n>  \n>  #include <libcamera/base/class.h>\n> diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\n> index 5a4b993bb2dbcb3e..f347c5e0a5f3078f 100644\n> --- a/include/libcamera/internal/camera_lens.h\n> +++ b/include/libcamera/internal/camera_lens.h\n> @@ -7,6 +7,7 @@\n>  #pragma once\n>  \n>  #include <memory>\n> +#include <stdint.h>\n>  #include <string>\n>  \n>  #include <libcamera/base/class.h>\n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index f6002c5f56448faa..13048f327bf2f626 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -8,6 +8,7 @@\n>  #pragma once\n>  \n>  #include <memory>\n> +#include <stdint.h>\n>  #include <string>\n>  #include <variant>\n>  #include <vector>\n> diff --git a/include/libcamera/internal/framebuffer.h b/include/libcamera/internal/framebuffer.h\n> index e6698a459432812b..97b49d42063f627b 100644\n> --- a/include/libcamera/internal/framebuffer.h\n> +++ b/include/libcamera/internal/framebuffer.h\n> @@ -8,6 +8,7 @@\n>  #pragma once\n>  \n>  #include <memory>\n> +#include <stdint.h>\n>  #include <utility>\n>  \n>  #include <libcamera/base/class.h>\n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 66d9a19fcc54509d..b4614f21d701db0d 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -7,6 +7,7 @@\n>  \n>  #pragma once\n>  \n> +#include <stdint.h>\n>  #include <string.h>\n>  #include <tuple>\n>  #include <type_traits>\n> diff --git a/include/libcamera/internal/ipc_pipe.h b/include/libcamera/internal/ipc_pipe.h\n> index a45607529cbf8a8e..418c4622ff82ba6d 100644\n> --- a/include/libcamera/internal/ipc_pipe.h\n> +++ b/include/libcamera/internal/ipc_pipe.h\n> @@ -7,6 +7,7 @@\n>  \n>  #pragma once\n>  \n> +#include <stdint.h>\n>  #include <vector>\n>  \n>  #include <libcamera/base/shared_fd.h>\n> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> index 8c972613f314d5b1..845128096280a57a 100644\n> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> @@ -9,6 +9,7 @@\n>  \n>  #include <map>\n>  #include <memory>\n> +#include <stdint.h>\n>  \n>  #include \"libcamera/internal/ipc_pipe.h\"\n>  #include \"libcamera/internal/ipc_unixsocket.h\"\n> diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\n> index 4e7d05b1e028079d..73e9bb5ccb0a2941 100644\n> --- a/include/libcamera/internal/request.h\n> +++ b/include/libcamera/internal/request.h\n> @@ -10,6 +10,7 @@\n>  #include <chrono>\n>  #include <map>\n>  #include <memory>\n> +#include <stdint.h>\n>  #include <unordered_set>\n>  \n>  #include <libcamera/base/event_notifier.h>\n> diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\n> index 4f367e91458be267..42c596850e80dab9 100644\n> --- a/include/libcamera/internal/tracepoints/request.tp\n> +++ b/include/libcamera/internal/tracepoints/request.tp\n> @@ -5,6 +5,8 @@\n>   * request.tp - Tracepoints for the request object\n>   */\n>  \n> +#include <stdint.h>\n> +\n>  #include <libcamera/framebuffer.h>\n>  \n>  #include \"libcamera/internal/request.h\"\n> diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\n> index f5aa502482017325..affe52c2ad3ff7df 100644\n> --- a/include/libcamera/internal/v4l2_device.h\n> +++ b/include/libcamera/internal/v4l2_device.h\n> @@ -10,6 +10,7 @@\n>  #include <map>\n>  #include <memory>\n>  #include <optional>\n> +#include <stdint.h>\n>  #include <vector>\n>  \n>  #include <linux/videodev2.h>\n> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> index 194382f84d97fbbc..fa2a4a21eefbb792 100644\n> --- a/include/libcamera/internal/v4l2_subdevice.h\n> +++ b/include/libcamera/internal/v4l2_subdevice.h\n> @@ -10,6 +10,7 @@\n>  #include <memory>\n>  #include <optional>\n>  #include <ostream>\n> +#include <stdint.h>\n>  #include <string>\n>  #include <vector>\n>  \n> \n> base-commit: 340bb7aa63d18516bcb1d21a1b7f10ba039903cf\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6303DC0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  9 Jan 2025 09:42:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 199EE684E2;\n\tThu,  9 Jan 2025 10:42:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2670A61883\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  9 Jan 2025 10:42:13 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87D185B3;\n\tThu,  9 Jan 2025 10:41:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c0DF7Yjp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736415679;\n\tbh=gkT7QrPJfuSBoNHZjGDWs/DJpDIUBb1Dv+v2arkvrj0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=c0DF7YjpUWF5NwOx9AUMO5ZXXo+ipuFuhnOr2KhzsC3SVcG0vKkPWpFQFyfSpD4vJ\n\tUCdM7kRTpfKRW4ri79GwS+LlNg/Ln+uOe/mMH9KispdQwxe0fnA8g9TxY5KY6NlLnc\n\tnso+yb8QCH6/qm7GOzPqr/vpIF+oIr0ICJGggMes=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250109014506.27619-1-laurent.pinchart@ideasonboard.com>","References":"<20250109014506.27619-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: include: Include missing stdint.h header","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 09 Jan 2025 09:42:10 +0000","Message-ID":"<173641573030.2992722.2900556239305351031@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]