[{"id":33001,"web_url":"https://patchwork.libcamera.org/comment/33001/","msgid":"<20250109230613.GI6159@pendragon.ideasonboard.com>","date":"2025-01-09T23:06:13","subject":"Re: [PATCH v6 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jan 08, 2025 at 06:09:42PM -0600, Paul Elder wrote:\n> Even though the new AeEnable control internally switches on and off the\n> sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\n> be declared as available. Report this control as available in the\n> rpi IPA.\n> \n> Support for the control does not need to be added as it is handled by\n> the Camera class. It does not need to be handled in metadata either as\n> the new version of AeEnable is not returned in metadata.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> New in v6\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index 4334d22e1..44ce38caa 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n> \n> /* List of controls handled by the Raspberry Pi IPA */\n> const ControlInfoMap::Map ipaControls{\n> +\t/* \\todo Move this to the Camera class */\n> +\t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::ExposureTimeMode,\n> \t ControlInfo(static_cast(controls::ExposureTimeModeAuto),\n> \t\t static_cast(controls::ExposureTimeModeManual)) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6D61C32EA\n\tfor ;\n\tThu, 9 Jan 2025 23:06:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 829CE68503;\n\tFri, 10 Jan 2025 00:06:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1706A684E0\n\tfor ;\n\tFri, 10 Jan 2025 00:06:16 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C808161;\n\tFri, 10 Jan 2025 00:05:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bvMYSwVl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736463922;\n\tbh=ENcRVBAfwJ1BdNtxZ9wEBkwBH59ElrkdUWuf67afq9g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bvMYSwVlQpxEFFHQdPhro8T+0aGevFKHOv93tMm6maVe1yn89pERS+43VoS5fuxUX\n\tFqJpr88MOPIWcba8yUYEPYuD4Su71dlGQ/pdMOVPklmSF7TwDN23ZsyzT4MAB38rBM\n\tW53k6NynnrzcYWyIKnFPRobOks5G8jkdePkqSX88=","Date":"Fri, 10 Jan 2025 01:06:13 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, stefan.klug@ideasonboard.com","Subject":"Re: [PATCH v6 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","Message-ID":"<20250109230613.GI6159@pendragon.ideasonboard.com>","References":"<20250109000942.1616565-1-paul.elder@ideasonboard.com>\n\t<20250109000942.1616565-13-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250109000942.1616565-13-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]