[{"id":33000,"web_url":"https://patchwork.libcamera.org/comment/33000/","msgid":"<20250109230550.GH6159@pendragon.ideasonboard.com>","date":"2025-01-09T23:05:50","subject":"Re: [PATCH v6 11/12] ipa: rkisp1: agc: Report new AeEnable control\n\tas available","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jan 08, 2025 at 06:09:41PM -0600, Paul Elder wrote:\n> Even though the new AeEnable control internally switches on and off the\n> sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\n> be declared as available. Report this control as available in the\n> rkisp1 IPA.\n> \n> Support for the control does not need to be added as it is handled by\n> the Camera class. It does not need to be handled in metadata either as\n> the new version of AeEnable is not returned in metadata.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> New in v6\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 49c107c99..3c0cb01c7 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> \t\tControlInfo(static_cast(controls::AnalogueGainModeAuto),\n> \t\t\t static_cast(controls::AnalogueGainModeManual),\n> \t\t\t static_cast(controls::AnalogueGainModeAuto));\n> +\t/* \\todo Move this to the Camera class */\n> +\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);\n> \tcontext.ctrlMap.merge(controls());\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11A51C32EA\n\tfor ;\n\tThu, 9 Jan 2025 23:05:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A984661884;\n\tFri, 10 Jan 2025 00:05:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E9AA608AB\n\tfor ;\n\tFri, 10 Jan 2025 00:05:53 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E48D161;\n\tFri, 10 Jan 2025 00:04:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aEdC34sK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736463899;\n\tbh=vPDEpg3y0uYZLuUJx687K6D7gJzjHAe3XyPXvXVZpz4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aEdC34sKOQ+zd3w8ujRurBBny+AK6mLKEkcpEaYc9CrtSFgigwMU6NxyWPxfhNVyi\n\tgW2rb7Vj1nBzTDQ+4tw4Zte/6mLOgTDrwim1VPtQcvQPC6/A7rFeMsruZ1T3FVCZDs\n\tCHAQGSVa3llBV8AelETLYBzDZlqRk0D/oP/Ymw9c=","Date":"Fri, 10 Jan 2025 01:05:50 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, stefan.klug@ideasonboard.com","Subject":"Re: [PATCH v6 11/12] ipa: rkisp1: agc: Report new AeEnable control\n\tas available","Message-ID":"<20250109230550.GH6159@pendragon.ideasonboard.com>","References":"<20250109000942.1616565-1-paul.elder@ideasonboard.com>\n\t<20250109000942.1616565-12-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250109000942.1616565-12-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]