{"id":22484,"url":"https://patchwork.libcamera.org/api/patches/22484/?format=json","web_url":"https://patchwork.libcamera.org/patch/22484/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250109000942.1616565-12-paul.elder@ideasonboard.com>","date":"2025-01-09T00:09:41","name":"[v6,11/12] ipa: rkisp1: agc: Report new AeEnable control as available","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bfcd843f19dece82a3ca6e225ab7313bebde6a8b","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22484/mbox/","series":[{"id":4936,"url":"https://patchwork.libcamera.org/api/series/4936/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4936","date":"2025-01-09T00:09:30","name":"AEGC controls","version":6,"mbox":"https://patchwork.libcamera.org/series/4936/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22484/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22484/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2227C3318\n\tfor ;\n\tThu, 9 Jan 2025 00:10:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A17768521;\n\tThu, 9 Jan 2025 01:10:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4858868543\n\tfor ;\n\tThu, 9 Jan 2025 01:10:11 +0100 (CET)","from pyrite.hamster-moth.ts.net (unknown\n\t[IPv6:2604:2d80:9e93:ad00:3d82:7e4f:ab9b:8a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D13ACE6;\n\tThu, 9 Jan 2025 01:09:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A1wIBK41\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736381358;\n\tbh=FD/BGBvqUdXEdPZbAwXMJHAXe3+v3JBH6vxzf9VuhOQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A1wIBK413EbvDKQXYwJRHIvwmWsedhAEQNRfQUNor5wIJx9Y8ywoWqkSbt97TZ+iF\n\tOOmKBVFugk2lsZX62qcHmUu+DZ5c87Ysl/6ePbwceSMcHSvqJ5H/VT75cF3YUoZSwq\n\tgyzt1Iyq0HKFmvE4aV5IhLWBE0RMHoFdvCrA5fVQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tlaurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com","Subject":"[PATCH v6 11/12] ipa: rkisp1: agc: Report new AeEnable control as\n\tavailable","Date":"Wed, 8 Jan 2025 18:09:41 -0600","Message-Id":"<20250109000942.1616565-12-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20250109000942.1616565-1-paul.elder@ideasonboard.com>","References":"<20250109000942.1616565-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Even though the new AeEnable control internally switches on and off the\nsub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\nbe declared as available. Report this control as available in the\nrkisp1 IPA.\n\nSupport for the control does not need to be added as it is handled by\nthe Camera class. It does not need to be handled in metadata either as\nthe new version of AeEnable is not returned in metadata.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v6\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 49c107c99..3c0cb01c7 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n \t\tControlInfo(static_cast(controls::AnalogueGainModeAuto),\n \t\t\t static_cast(controls::AnalogueGainModeManual),\n \t\t\t static_cast(controls::AnalogueGainModeAuto));\n+\t/* \\todo Move this to the Camera class */\n+\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);\n \tcontext.ctrlMap.merge(controls());\n \n \treturn 0;\n","prefixes":["v6","11/12"]}