[{"id":32972,"web_url":"https://patchwork.libcamera.org/comment/32972/","msgid":"<20250108230456.GJ32541@pendragon.ideasonboard.com>","date":"2025-01-08T23:04:56","subject":"Re: [PATCH] utils: codegen: controls.py: Fix missing direction error\n\tmessage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jan 08, 2025 at 04:29:50PM -0600, Paul Elder wrote:\n> The error message for missing direction field prints the direction value\n> (usually 'None') instead of the name of the field 'direction'. Fix this.\n> \n> Fixes: 39fe4ad96803 (\"utils: codegen: controls.py: Parse direction information\")\n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/codegen/controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/codegen/controls.py b/utils/codegen/controls.py\n> index 602f15b25..e51610481 100644\n> --- a/utils/codegen/controls.py\n> +++ b/utils/codegen/controls.py\n> @@ -65,7 +65,7 @@ class Control(object):\n> else:\n> direction = self.__data.get('direction')\n> if direction is None:\n> - raise RuntimeError(f'Control `{self.__name}` missing required field `{direction}`')\n> + raise RuntimeError(f'Control `{self.__name}` missing required field `direction`')\n> if direction not in ['in', 'out', 'inout']:\n> raise RuntimeError(f'Control `{self.__name}` direction `{direction}` is invalid; must be one of `in`, `out`, or `inout`')\n> self.__direction = direction","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30D8FC32EF\n\tfor ;\n\tWed, 8 Jan 2025 23:05:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6253B684E2;\n\tThu, 9 Jan 2025 00:05:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0188684CD\n\tfor ;\n\tThu, 9 Jan 2025 00:04:59 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B97DC62;\n\tThu, 9 Jan 2025 00:04:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c2bKR12a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736377446;\n\tbh=oSVEGziKJ8R1hn290h4W2kpn+OLUzWOb2IN0W0e0lww=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c2bKR12aPqmJyDxZ+hRjDyPsX1cePIFvbWZagm6vUAxDcg58F4u42UNHFJbVJVqmK\n\tEgF06BtwhBv6W1u8kOI6P8HPza8msHAUUuJGfqLH6/vDY+gLODHjOUwArzua1yojun\n\tc2ByBZ8WbBdJJ1u03a74rBVJ/mynx2drquF3Nlvo=","Date":"Thu, 9 Jan 2025 01:04:56 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] utils: codegen: controls.py: Fix missing direction error\n\tmessage","Message-ID":"<20250108230456.GJ32541@pendragon.ideasonboard.com>","References":"<20250108222950.1317759-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250108222950.1317759-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32974,"web_url":"https://patchwork.libcamera.org/comment/32974/","msgid":"<173641594475.2992722.16068696222807251609@ping.linuxembedded.co.uk>","date":"2025-01-09T09:45:44","subject":"Re: [PATCH] utils: codegen: controls.py: Fix missing direction error\n\tmessage","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-01-08 23:04:56)\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Wed, Jan 08, 2025 at 04:29:50PM -0600, Paul Elder wrote:\n> > The error message for missing direction field prints the direction value\n> > (usually 'None') instead of the name of the field 'direction'. Fix this.\n> > \n> > Fixes: 39fe4ad96803 (\"utils: codegen: controls.py: Parse direction information\")\n> > Signed-off-by: Paul Elder \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > utils/codegen/controls.py | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/utils/codegen/controls.py b/utils/codegen/controls.py\n> > index 602f15b25..e51610481 100644\n> > --- a/utils/codegen/controls.py\n> > +++ b/utils/codegen/controls.py\n> > @@ -65,7 +65,7 @@ class Control(object):\n> > else:\n> > direction = self.__data.get('direction')\n> > if direction is None:\n> > - raise RuntimeError(f'Control `{self.__name}` missing required field `{direction}`')\n> > + raise RuntimeError(f'Control `{self.__name}` missing required field `direction`')\n\nIndeed, I can see how that printing None isn't helpful ;-)\n\n\nReviewed-by: Kieran Bingham \n\n> > if direction not in ['in', 'out', 'inout']:\n> > raise RuntimeError(f'Control `{self.__name}` direction `{direction}` is invalid; must be one of `in`, `out`, or `inout`')\n> > self.__direction = direction\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A242C32EF\n\tfor ;\n\tThu, 9 Jan 2025 09:45:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73C3B684E2;\n\tThu, 9 Jan 2025 10:45:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20EFC61883\n\tfor ;\n\tThu, 9 Jan 2025 10:45:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 272DD5B3;\n\tThu, 9 Jan 2025 10:44:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nS5SGrcs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736415894;\n\tbh=lKP1hKqQ3Ql2q2ZTillvAGyAQUr7nFb+LEvCBlK03mE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=nS5SGrcsWVrsMAEalqmqYkURT44E+lUpe5JIs6KA+6LRl5W7wujq419msqlBksoRa\n\tZ4i9iWeVunTMeeXsbRYQ8HfS+uJXRlyXJRNAsxPPVNlK8a+qQT69MMGeejFEisPcIR\n\tbnfUWPZFMUufL0uiCWLooSUDi5sb+Kk6++R4qo2o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250108230456.GJ32541@pendragon.ideasonboard.com>","References":"<20250108222950.1317759-1-paul.elder@ideasonboard.com>\n\t<20250108230456.GJ32541@pendragon.ideasonboard.com>","Subject":"Re: [PATCH] utils: codegen: controls.py: Fix missing direction error\n\tmessage","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tPaul Elder ","Date":"Thu, 09 Jan 2025 09:45:44 +0000","Message-ID":"<173641594475.2992722.16068696222807251609@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]