{"id":22471,"url":"https://patchwork.libcamera.org/api/patches/22471/?format=json","web_url":"https://patchwork.libcamera.org/patch/22471/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250108111030.3257931-5-naush@raspberrypi.com>","date":"2025-01-08T11:09:36","name":"[v3,4/4] ipa: rpi: Provide the camera helper with the hardware configuration","commit_ref":"18c9ff46ef79d474d7c620cc915ae3b3d52ec21d","pull_url":null,"state":"accepted","archived":false,"hash":"f45b4ee59399354f4fc638dce57268eb7981835d","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22471/mbox/","series":[{"id":4934,"url":"https://patchwork.libcamera.org/api/series/4934/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4934","date":"2025-01-08T11:09:32","name":"Raspberry Pi: Various changes","version":3,"mbox":"https://patchwork.libcamera.org/series/4934/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22471/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22471/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3CE4C32F0\n\tfor ;\n\tWed, 8 Jan 2025 11:10:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92CB868503;\n\tWed, 8 Jan 2025 12:10:42 +0100 (CET)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FB8D684E4\n\tfor ;\n\tWed, 8 Jan 2025 12:10:38 +0100 (CET)","by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-4361e82e3c3so25989205e9.0\n\tfor ;\n\tWed, 08 Jan 2025 03:10:38 -0800 (PST)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-436e2ddefcbsm17141325e9.22.2025.01.08.03.10.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Jan 2025 03:10:37 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Y9nI8gtq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736334638; x=1736939438;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=353pXkmOOArp5EYfEz09P8Q//IsEvbXNQ4sKh5FVhgU=;\n\tb=Y9nI8gtqQ9SFwQx5UsY2w4rb0tKSskivRxO+YwYdY0TfyNSr3QCq4lAXpVWaz77yTj\n\tffZmdghb3EOYn+3Off2OnPJzbKkeUyeBMZEOo43OuSy540YX2zhGxGp/rIrkcgQwuWG/\n\tjBvO1q+RWugwuZ3+TpUwOV5X1ujdv7JAaFU3lUgTkdNsExgz6ykRyaU6qSlZsMB3p5lo\n\toNX6ijCMfljs2dxvsI7+kGFG5XhMxbRHQIG4yxLCmP0Z/HocmOvw38UuvlsSxDicHqdA\n\t88jj0TZVxxl08dOkC+9NEx/gVftblbuzkBIb390spwaLjjR+BtpFIqQbCstGpqf186TS\n\tCzvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736334638; x=1736939438;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=353pXkmOOArp5EYfEz09P8Q//IsEvbXNQ4sKh5FVhgU=;\n\tb=JKFNo7ZQKjdodAizIqHlE1eqUgsdmwJgM/713JJuqrXyb2ZC4qAj4YpsIet5g9VGKc\n\toY7OJagf+f+Bv5IssBBJKaYZpaebdee8660pqy8q9C/si5/axDCEOyk1rw7s/NM54aVN\n\tZNhZVcCdhCX6CgVzm8rrZzFFrNy2W5yEnc/AcMLNRkDEOVeHLcLQSk7OmXakrMU0l2Gd\n\tfJloKY+7Fn8Zw93Gpy0VuZWTNdcEd2z0PQ3GJJCyMfkbnL8SDurKGCNf2dAcBCiaJptf\n\tVGmJr7+TPPyMZGpL0iaNZw6PiFyh5U3kOptOYQzUPZzH1bFOvRYi26WtZ2b+WQ4L9n8w\n\tBccA==","X-Gm-Message-State":"AOJu0YxzsEpWpl3Sf6EcVM4qjskvyT6phjPdxVDGFJfss9wHpOr7rO8+\n\txkwHLx0uk1SSVfPtm6NAczdRn3kr6Vdmug0dfiWQHfE+i2zZcZm836xlPp7DBUWHyLaupSEiqkS\n\tR+0U=","X-Gm-Gg":"ASbGncuncv8gxIlBAd33q6D/klE9K4nO9xnMKcBbzY7TshSZcrloLzq32d5DtEwmD7a\n\tjmnEjJW25zwokvPvLVJoYxi8IXpqtECsq3kqucwZfYsL1+EwGU24wCn/uCNmlu4y4HU9r/hff36\n\tKZi6LlhxstxRELeJEQT/2s4+JKN4nr3FCl7GxRP8Fy+LYTzcAKsjpo+k5vDu8/c+laH3FUbr4Qz\n\tLnuAPtf6gm5xRXltGwCMRCbOYOAKbWwnFr3mINw7jM4X5dScxetZCpQrsFxnZyEFrgmvfHWp5wa","X-Google-Smtp-Source":"AGHT+IHjG5VvkSKARqDCVyE8SB9sXAJ1EZeERA/DmlJCzen48VBcqRi9T4syq/tMPcRKaj/eXvTFxw==","X-Received":"by 2002:a05:600c:1385:b0:436:1b94:2deb with SMTP id\n\t5b1f17b1804b1-436e26f556fmr7452645e9.5.1736334637668; \n\tWed, 08 Jan 2025 03:10:37 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tDavid Plowman ,\n\tKieran Bingham ","Subject":"[PATCH v3 4/4] ipa: rpi: Provide the camera helper with the hardware\n\tconfiguration","Date":"Wed, 8 Jan 2025 11:09:36 +0000","Message-ID":"<20250108111030.3257931-5-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250108111030.3257931-1-naush@raspberrypi.com>","References":"<20250108111030.3257931-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a CamHelper::setHwConfig() helper used by the IPA to set the\nhardware configuration in use by the pipeline. This will be needed by\nthe IMX500 camera helper in a future commit to determine if the\nmetadata buffer is strided.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nAcked-by: Kieran Bingham \n---\n src/ipa/rpi/cam_helper/cam_helper.cpp | 5 +++++\n src/ipa/rpi/cam_helper/cam_helper.h | 2 ++\n src/ipa/rpi/common/ipa_base.cpp | 1 +\n 3 files changed, 8 insertions(+)","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper.cpp b/src/ipa/rpi/cam_helper/cam_helper.cpp\nindex 8c720652fbd0..a78db9c1cd7c 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper.cpp\n@@ -156,6 +156,11 @@ void CamHelper::setCameraMode(const CameraMode &mode)\n \t}\n }\n \n+void CamHelper::setHwConfig(const Controller::HardwareConfig &hwConfig)\n+{\n+\thwConfig_ = hwConfig;\n+}\n+\n bool CamHelper::sensorEmbeddedDataPresent() const\n {\n \treturn false;\ndiff --git a/src/ipa/rpi/cam_helper/cam_helper.h b/src/ipa/rpi/cam_helper/cam_helper.h\nindex 29371bdbf5ea..4a826690ec65 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper.h\n+++ b/src/ipa/rpi/cam_helper/cam_helper.h\n@@ -71,6 +71,7 @@ public:\n \tCamHelper(std::unique_ptr parser, unsigned int frameIntegrationDiff);\n \tvirtual ~CamHelper();\n \tvoid setCameraMode(const CameraMode &mode);\n+\tvoid setHwConfig(const Controller::HardwareConfig &hwConfig);\n \tvirtual void prepare(libcamera::Span buffer,\n \t\t\t Metadata &metadata);\n \tvirtual void process(StatisticsPtr &stats, Metadata &metadata);\n@@ -101,6 +102,7 @@ protected:\n \n \tstd::unique_ptr parser_;\n \tCameraMode mode_;\n+\tController::HardwareConfig hwConfig_;\n \n private:\n \t/*\ndiff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 0c8aee699155..6ff1e22b15d4 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -151,6 +151,7 @@ int32_t IpaBase::init(const IPASettings &settings, const InitParams ¶ms, Ini\n \tlensPresent_ = params.lensPresent;\n \n \tcontroller_.initialise();\n+\thelper_->setHwConfig(controller_.getHardwareConfig());\n \n \t/* Return the controls handled by the IPA */\n \tControlInfoMap::Map ctrlMap = ipaControls;\n","prefixes":["v3","4/4"]}