[{"id":32959,"web_url":"https://patchwork.libcamera.org/comment/32959/","msgid":"<173632934198.2992722.3663993167462991165@ping.linuxembedded.co.uk>","date":"2025-01-08T09:42:21","subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck (2025-01-08 09:03:22)\n> From: Dave Stevenson \n> \n> Basic tuning done by David Plowman using a Waveshare SKU 28524\n> \"IMX415-98 IR-CUT Camera\" module.\n> \n> Signed-off-by: Dave Stevenson \n\nCan I assume that you posting this one is an implicit RB or Acked-by tag\nfor the tuning content?\n\n\nAcked-by: Kieran Bingham \n\n\n> ---\n> src/ipa/rpi/vc4/data/imx415.json | 413 +++++++++++++++++++++++++++++++\n> src/ipa/rpi/vc4/data/meson.build | 1 +\n> 2 files changed, 414 insertions(+)\n> create mode 100755 src/ipa/rpi/vc4/data/imx415.json\n> \n> diff --git a/src/ipa/rpi/vc4/data/imx415.json b/src/ipa/rpi/vc4/data/imx415.json\n> new file mode 100755\n> index 000000000000..6ed16b173074\n> --- /dev/null\n> +++ b/src/ipa/rpi/vc4/data/imx415.json\n> @@ -0,0 +1,413 @@\n> +{\n> + \"version\": 2.0,\n> + \"target\": \"bcm2835\",\n> + \"algorithms\": [\n> + {\n> + \"rpi.black_level\":\n> + {\n> + \"black_level\": 3840\n> + }\n> + },\n> + {\n> + \"rpi.dpc\": { }\n> + },\n> + {\n> + \"rpi.lux\":\n> + {\n> + \"reference_shutter_speed\": 19230,\n> + \"reference_gain\": 1.0,\n> + \"reference_aperture\": 1.0,\n> + \"reference_lux\": 1198,\n> + \"reference_Y\": 14876\n> + }\n> + },\n> + {\n> + \"rpi.noise\":\n> + {\n> + \"reference_constant\": 17,\n> + \"reference_slope\": 3.439\n> + }\n> + },\n> + {\n> + \"rpi.geq\":\n> + {\n> + \"offset\": 193,\n> + \"slope\": 0.00902\n> + }\n> + },\n> + {\n> + \"rpi.sdn\": { }\n> + },\n> + {\n> + \"rpi.awb\":\n> + {\n> + \"priors\": [\n> + {\n> + \"lux\": 0,\n> + \"prior\":\n> + [\n> + 2000, 1.0,\n> + 3000, 0.0,\n> + 13000, 0.0\n> + ]\n> + },\n> + {\n> + \"lux\": 800,\n> + \"prior\":\n> + [\n> + 2000, 0.0,\n> + 6000, 2.0,\n> + 13000, 2.0\n> + ]\n> + },\n> + {\n> + \"lux\": 1500,\n> + \"prior\":\n> + [\n> + 2000, 0.0,\n> + 4000, 1.0,\n> + 6000, 6.0,\n> + 6500, 7.0,\n> + 7000, 1.0,\n> + 13000, 1.0\n> + ]\n> + }\n> + ],\n> + \"modes\":\n> + {\n> + \"auto\":\n> + {\n> + \"lo\": 2500,\n> + \"hi\": 8000\n> + },\n> + \"incandescent\":\n> + {\n> + \"lo\": 2500,\n> + \"hi\": 3000\n> + },\n> + \"tungsten\":\n> + {\n> + \"lo\": 3000,\n> + \"hi\": 3500\n> + },\n> + \"fluorescent\":\n> + {\n> + \"lo\": 4000,\n> + \"hi\": 4700\n> + },\n> + \"indoor\":\n> + {\n> + \"lo\": 3000,\n> + \"hi\": 5000\n> + },\n> + \"daylight\":\n> + {\n> + \"lo\": 5500,\n> + \"hi\": 6500\n> + },\n> + \"cloudy\":\n> + {\n> + \"lo\": 7000,\n> + \"hi\": 8600\n> + }\n> + },\n> + \"bayes\": 1,\n> + \"ct_curve\":\n> + [\n> + 2698.0, 0.7681, 0.2026,\n> + 2930.0, 0.7515, 0.2116,\n> + 3643.0, 0.6355, 0.2858,\n> + 4605.0, 0.4992, 0.4041,\n> + 5658.0, 0.4498, 0.4574\n> + ],\n> + \"sensitivity_r\": 1.0,\n> + \"sensitivity_b\": 1.0,\n> + \"transverse_pos\": 0.0112,\n> + \"transverse_neg\": 0.01424\n> + }\n> + },\n> + {\n> + \"rpi.agc\":\n> + {\n> + \"metering_modes\":\n> + {\n> + \"centre-weighted\":\n> + {\n> + \"weights\":\n> + [\n> + 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> + ]\n> + },\n> + \"spot\":\n> + {\n> + \"weights\":\n> + [\n> + 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> + ]\n> + },\n> + \"matrix\":\n> + {\n> + \"weights\":\n> + [\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> + ]\n> + }\n> + },\n> + \"exposure_modes\":\n> + {\n> + \"normal\":\n> + {\n> + \"shutter\": [ 100, 10000, 30000, 60000, 120000 ],\n> + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> + },\n> + \"short\":\n> + {\n> + \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n> + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> + }\n> + },\n> + \"constraint_modes\":\n> + {\n> + \"normal\": [\n> + {\n> + \"bound\": \"LOWER\",\n> + \"q_lo\": 0.98,\n> + \"q_hi\": 1.0,\n> + \"y_target\":\n> + [\n> + 0, 0.5,\n> + 1000, 0.5\n> + ]\n> + }\n> + ],\n> + \"highlight\": [\n> + {\n> + \"bound\": \"LOWER\",\n> + \"q_lo\": 0.98,\n> + \"q_hi\": 1.0,\n> + \"y_target\":\n> + [\n> + 0, 0.5,\n> + 1000, 0.5\n> + ]\n> + },\n> + {\n> + \"bound\": \"UPPER\",\n> + \"q_lo\": 0.98,\n> + \"q_hi\": 1.0,\n> + \"y_target\":\n> + [\n> + 0, 0.8,\n> + 1000, 0.8\n> + ]\n> + }\n> + ]\n> + },\n> + \"y_target\":\n> + [\n> + 0, 0.16,\n> + 1000, 0.165,\n> + 10000, 0.17\n> + ]\n> + }\n> + },\n> + {\n> + \"rpi.alsc\":\n> + {\n> + \"omega\": 1.3,\n> + \"n_iter\": 100,\n> + \"luminance_strength\": 0.8,\n> + \"calibrations_Cr\": [\n> + {\n> + \"ct\": 3000,\n> + \"table\":\n> + [\n> + 1.025, 1.016, 1.013, 1.011, 1.008, 1.005, 1.003, 1.001, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.027, 1.035,\n> + 1.025, 1.017, 1.013, 1.011, 1.008, 1.005, 1.003, 1.003, 1.004, 1.005, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> + 1.022, 1.017, 1.013, 1.009, 1.007, 1.005, 1.003, 1.003, 1.004, 1.006, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> + 1.019, 1.015, 1.011, 1.007, 1.005, 1.003, 1.001, 1.001, 1.003, 1.004, 1.007, 1.009, 1.015, 1.022, 1.028, 1.035,\n> + 1.018, 1.014, 1.009, 1.006, 1.004, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.021, 1.028, 1.035,\n> + 1.018, 1.013, 1.011, 1.006, 1.003, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.022, 1.028, 1.036,\n> + 1.018, 1.014, 1.011, 1.007, 1.004, 1.002, 1.001, 1.001, 1.001, 1.004, 1.007, 1.009, 1.015, 1.023, 1.029, 1.036,\n> + 1.019, 1.014, 1.012, 1.008, 1.005, 1.003, 1.002, 1.001, 1.003, 1.005, 1.008, 1.012, 1.016, 1.024, 1.031, 1.037,\n> + 1.021, 1.016, 1.013, 1.009, 1.008, 1.005, 1.003, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.026, 1.033, 1.039,\n> + 1.025, 1.021, 1.016, 1.013, 1.009, 1.008, 1.006, 1.006, 1.008, 1.011, 1.014, 1.019, 1.024, 1.031, 1.038, 1.046,\n> + 1.029, 1.025, 1.021, 1.018, 1.014, 1.013, 1.011, 1.011, 1.012, 1.015, 1.019, 1.023, 1.028, 1.035, 1.046, 1.051,\n> + 1.032, 1.029, 1.023, 1.021, 1.018, 1.015, 1.014, 1.014, 1.015, 1.018, 1.022, 1.027, 1.033, 1.041, 1.051, 1.054\n> + ]\n> + },\n> + {\n> + \"ct\": 5000,\n> + \"table\":\n> + [\n> + 1.025, 1.011, 1.009, 1.005, 1.004, 1.003, 1.001, 1.001, 1.002, 1.006, 1.009, 1.012, 1.016, 1.021, 1.031, 1.041,\n> + 1.025, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.004, 1.007, 1.009, 1.013, 1.021, 1.028, 1.037, 1.041,\n> + 1.023, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.005, 1.007, 1.011, 1.014, 1.021, 1.028, 1.037, 1.048,\n> + 1.022, 1.012, 1.007, 1.005, 1.002, 1.001, 1.001, 1.001, 1.003, 1.005, 1.009, 1.014, 1.019, 1.028, 1.039, 1.048,\n> + 1.022, 1.011, 1.006, 1.003, 1.001, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.014, 1.021, 1.029, 1.039, 1.051,\n> + 1.022, 1.012, 1.007, 1.003, 1.002, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.015, 1.021, 1.031, 1.041, 1.053,\n> + 1.023, 1.013, 1.009, 1.005, 1.003, 1.003, 1.001, 1.002, 1.004, 1.006, 1.011, 1.015, 1.022, 1.031, 1.042, 1.056,\n> + 1.024, 1.015, 1.012, 1.008, 1.005, 1.004, 1.004, 1.004, 1.006, 1.009, 1.013, 1.018, 1.024, 1.034, 1.045, 1.057,\n> + 1.027, 1.017, 1.015, 1.012, 1.009, 1.007, 1.007, 1.008, 1.009, 1.013, 1.018, 1.023, 1.029, 1.038, 1.051, 1.061,\n> + 1.029, 1.023, 1.017, 1.015, 1.014, 1.012, 1.011, 1.011, 1.014, 1.018, 1.024, 1.029, 1.036, 1.044, 1.056, 1.066,\n> + 1.034, 1.028, 1.023, 1.022, 1.019, 1.019, 1.018, 1.018, 1.021, 1.025, 1.031, 1.035, 1.042, 1.053, 1.066, 1.074,\n> + 1.041, 1.034, 1.027, 1.025, 1.025, 1.023, 1.023, 1.023, 1.025, 1.031, 1.035, 1.041, 1.049, 1.059, 1.074, 1.079\n> + ]\n> + }\n> + ],\n> + \"calibrations_Cb\": [\n> + {\n> + \"ct\": 3000,\n> + \"table\":\n> + [\n> + 1.001, 1.001, 1.007, 1.015, 1.027, 1.034, 1.038, 1.041, 1.042, 1.043, 1.043, 1.043, 1.041, 1.039, 1.049, 1.054,\n> + 1.011, 1.011, 1.013, 1.023, 1.032, 1.039, 1.044, 1.047, 1.052, 1.056, 1.059, 1.059, 1.055, 1.051, 1.054, 1.056,\n> + 1.015, 1.015, 1.019, 1.032, 1.039, 1.044, 1.047, 1.052, 1.055, 1.059, 1.061, 1.066, 1.063, 1.058, 1.061, 1.064,\n> + 1.016, 1.017, 1.023, 1.032, 1.041, 1.045, 1.048, 1.053, 1.056, 1.061, 1.066, 1.069, 1.067, 1.064, 1.065, 1.068,\n> + 1.018, 1.019, 1.025, 1.033, 1.042, 1.045, 1.049, 1.054, 1.058, 1.063, 1.071, 1.072, 1.071, 1.068, 1.069, 1.071,\n> + 1.023, 1.024, 1.029, 1.035, 1.043, 1.048, 1.052, 1.057, 1.061, 1.065, 1.074, 1.075, 1.075, 1.072, 1.072, 1.075,\n> + 1.027, 1.028, 1.031, 1.038, 1.045, 1.051, 1.054, 1.059, 1.064, 1.068, 1.075, 1.079, 1.078, 1.075, 1.076, 1.081,\n> + 1.029, 1.031, 1.033, 1.044, 1.048, 1.054, 1.059, 1.064, 1.067, 1.073, 1.079, 1.082, 1.082, 1.079, 1.081, 1.085,\n> + 1.033, 1.033, 1.035, 1.047, 1.053, 1.058, 1.064, 1.067, 1.073, 1.079, 1.084, 1.086, 1.086, 1.084, 1.089, 1.091,\n> + 1.037, 1.037, 1.038, 1.049, 1.057, 1.062, 1.068, 1.073, 1.079, 1.084, 1.089, 1.092, 1.092, 1.092, 1.096, 1.104,\n> + 1.041, 1.041, 1.043, 1.051, 1.061, 1.068, 1.073, 1.079, 1.083, 1.089, 1.092, 1.094, 1.097, 1.099, 1.105, 1.115,\n> + 1.048, 1.044, 1.044, 1.051, 1.063, 1.071, 1.076, 1.082, 1.088, 1.091, 1.094, 1.097, 1.099, 1.104, 1.115, 1.126\n> + ]\n> + },\n> + {\n> + \"ct\": 5000,\n> + \"table\":\n> + [\n> + 1.001, 1.001, 1.005, 1.011, 1.014, 1.018, 1.019, 1.019, 1.019, 1.021, 1.021, 1.021, 1.019, 1.017, 1.014, 1.014,\n> + 1.009, 1.009, 1.011, 1.014, 1.019, 1.024, 1.026, 1.029, 1.031, 1.032, 1.032, 1.031, 1.027, 1.023, 1.022, 1.022,\n> + 1.011, 1.012, 1.015, 1.018, 1.024, 1.026, 1.029, 1.032, 1.035, 1.036, 1.036, 1.034, 1.031, 1.027, 1.025, 1.025,\n> + 1.012, 1.013, 1.015, 1.019, 1.025, 1.029, 1.032, 1.035, 1.036, 1.038, 1.038, 1.036, 1.034, 1.029, 1.026, 1.026,\n> + 1.013, 1.014, 1.016, 1.019, 1.027, 1.031, 1.034, 1.037, 1.039, 1.039, 1.041, 1.039, 1.036, 1.031, 1.028, 1.027,\n> + 1.014, 1.014, 1.017, 1.021, 1.027, 1.033, 1.037, 1.039, 1.041, 1.041, 1.042, 1.042, 1.039, 1.033, 1.029, 1.028,\n> + 1.015, 1.015, 1.018, 1.021, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.042, 1.042, 1.039, 1.034, 1.029, 1.029,\n> + 1.015, 1.016, 1.018, 1.022, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.043, 1.043, 1.041, 1.035, 1.031, 1.031,\n> + 1.015, 1.016, 1.018, 1.022, 1.027, 1.032, 1.037, 1.041, 1.042, 1.042, 1.044, 1.043, 1.041, 1.036, 1.034, 1.033,\n> + 1.016, 1.017, 1.017, 1.022, 1.027, 1.032, 1.036, 1.039, 1.042, 1.042, 1.043, 1.043, 1.041, 1.039, 1.036, 1.034,\n> + 1.017, 1.017, 1.018, 1.022, 1.027, 1.031, 1.035, 1.039, 1.041, 1.042, 1.042, 1.042, 1.042, 1.039, 1.039, 1.039,\n> + 1.018, 1.017, 1.017, 1.021, 1.027, 1.031, 1.033, 1.038, 1.041, 1.041, 1.042, 1.042, 1.041, 1.041, 1.041, 1.041\n> + ]\n> + }\n> + ],\n> + \"luminance_lut\":\n> + [\n> + 2.102, 1.903, 1.658, 1.483, 1.358, 1.267, 1.202, 1.202, 1.202, 1.242, 1.323, 1.431, 1.585, 1.797, 2.096, 2.351,\n> + 1.996, 1.776, 1.549, 1.385, 1.273, 1.204, 1.138, 1.133, 1.133, 1.185, 1.252, 1.343, 1.484, 1.679, 1.954, 2.228,\n> + 1.923, 1.689, 1.474, 1.318, 1.204, 1.138, 1.079, 1.071, 1.071, 1.133, 1.185, 1.284, 1.415, 1.597, 1.854, 2.146,\n> + 1.881, 1.631, 1.423, 1.272, 1.159, 1.079, 1.051, 1.026, 1.046, 1.071, 1.144, 1.245, 1.369, 1.543, 1.801, 2.095,\n> + 1.867, 1.595, 1.391, 1.242, 1.131, 1.051, 1.013, 1.002, 1.013, 1.046, 1.121, 1.219, 1.343, 1.511, 1.752, 2.079,\n> + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.001, 1.001, 1.003, 1.045, 1.118, 1.217, 1.342, 1.511, 1.746, 2.079,\n> + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.011, 1.003, 1.011, 1.046, 1.118, 1.217, 1.343, 1.511, 1.746, 2.079,\n> + 1.884, 1.621, 1.411, 1.261, 1.149, 1.071, 1.048, 1.024, 1.046, 1.069, 1.141, 1.239, 1.369, 1.541, 1.781, 2.093,\n> + 1.913, 1.675, 1.459, 1.304, 1.191, 1.125, 1.071, 1.065, 1.069, 1.124, 1.181, 1.278, 1.413, 1.592, 1.842, 2.133,\n> + 1.981, 1.755, 1.529, 1.368, 1.251, 1.191, 1.125, 1.124, 1.124, 1.181, 1.242, 1.337, 1.479, 1.669, 1.935, 2.207,\n> + 2.078, 1.867, 1.625, 1.453, 1.344, 1.251, 1.202, 1.201, 1.201, 1.242, 1.333, 1.418, 1.571, 1.776, 2.063, 2.321,\n> + 2.217, 2.011, 1.747, 1.562, 1.431, 1.331, 1.278, 1.278, 1.278, 1.313, 1.407, 1.523, 1.686, 1.911, 2.226, 2.484\n> + ],\n> + \"sigma\": 0.00135,\n> + \"sigma_Cb\": 0.00279\n> + }\n> + },\n> + {\n> + \"rpi.contrast\":\n> + {\n> + \"ce_enable\": 1,\n> + \"gamma_curve\":\n> + [\n> + 0, 0,\n> + 1024, 5040,\n> + 2048, 9338,\n> + 3072, 12356,\n> + 4096, 15312,\n> + 5120, 18051,\n> + 6144, 20790,\n> + 7168, 23193,\n> + 8192, 25744,\n> + 9216, 27942,\n> + 10240, 30035,\n> + 11264, 32005,\n> + 12288, 33975,\n> + 13312, 35815,\n> + 14336, 37600,\n> + 15360, 39168,\n> + 16384, 40642,\n> + 18432, 43379,\n> + 20480, 45749,\n> + 22528, 47753,\n> + 24576, 49621,\n> + 26624, 51253,\n> + 28672, 52698,\n> + 30720, 53796,\n> + 32768, 54876,\n> + 36864, 57012,\n> + 40960, 58656,\n> + 45056, 59954,\n> + 49152, 61183,\n> + 53248, 62355,\n> + 57344, 63419,\n> + 61440, 64476,\n> + 65535, 65535\n> + ]\n> + }\n> + },\n> + {\n> + \"rpi.ccm\":\n> + {\n> + \"ccms\": [\n> + {\n> + \"ct\": 2698,\n> + \"ccm\":\n> + [\n> + 1.57227, -0.32596, -0.24631,\n> + -0.61264, 1.70791, -0.09526,\n> + -0.43254, 0.48489, 0.94765\n> + ]\n> + },\n> + {\n> + \"ct\": 2930,\n> + \"ccm\":\n> + [\n> + 1.69455, -0.52724, -0.16731,\n> + -0.67131, 1.78468, -0.11338,\n> + -0.41609, 0.54693, 0.86916\n> + ]\n> + },\n> + {\n> + \"ct\": 3643,\n> + \"ccm\":\n> + [\n> + 1.74041, -0.77553, 0.03512,\n> + -0.44073, 1.34131, 0.09943,\n> + -0.11035, -0.93919, 2.04954\n> + ]\n> + },\n> + {\n> + \"ct\": 4605,\n> + \"ccm\":\n> + [\n> + 1.49865, -0.41638, -0.08227,\n> + -0.39445, 1.70114, -0.30669,\n> + 0.01319, -0.88009, 1.86689\n> + ]\n> + },\n> + {\n> + \"ct\": 5658,\n> + \"ccm\":\n> + [\n> + 1.38601, -0.23128, -0.15472,\n> + -0.37641, 1.70444, -0.32803,\n> + -0.01575, -0.71466, 1.73041\n> + ]\n> + }\n> + ]\n> + }\n> + },\n> + {\n> + \"rpi.sharpen\": { }\n> + }\n> + ]\n> +}\n> diff --git a/src/ipa/rpi/vc4/data/meson.build b/src/ipa/rpi/vc4/data/meson.build\n> index 94c0ee6e6b7b..7a8001ee4817 100644\n> --- a/src/ipa/rpi/vc4/data/meson.build\n> +++ b/src/ipa/rpi/vc4/data/meson.build\n> @@ -9,6 +9,7 @@ conf_files = files([\n> 'imx296_mono.json',\n> 'imx327.json',\n> 'imx378.json',\n> + 'imx415.json',\n> 'imx462.json',\n> 'imx477.json',\n> 'imx477_noir.json',\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82ED2BD80A\n\tfor ;\n\tWed, 8 Jan 2025 09:42:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E69EE684E2;\n\tWed, 8 Jan 2025 10:42:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8E0461884\n\tfor ;\n\tWed, 8 Jan 2025 10:42:24 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3DFF3E;\n\tWed, 8 Jan 2025 10:41:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SPrO2U8x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736329291;\n\tbh=iBYfHwZ9DvXsdUvGe265cJaWHmO3XynqMaGxSDh8GRY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=SPrO2U8xrMDaH5fQvIKEohSuU8MzE1prdBLBOhn+Q266VnPyxCfy7Vuc143S2j63o\n\t6+j0N/aenUB6euL4q0+GfGv2s7eB8pq79DC0QNeIvdVhmYsX9PZ5VfeKcr9Bp57goW\n\tm+K5wFy+irKIUNusCYS6fKOUSQi/dkAlkQVFbLuc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250108090329.3185026-3-naush@raspberrypi.com>","References":"<20250108090329.3185026-1-naush@raspberrypi.com>\n\t<20250108090329.3185026-3-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","From":"Kieran Bingham ","Cc":"Dave Stevenson ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 08 Jan 2025 09:42:21 +0000","Message-ID":"<173632934198.2992722.3663993167462991165@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32960,"web_url":"https://patchwork.libcamera.org/comment/32960/","msgid":"","date":"2025-01-08T09:47:03","subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nHappy New Year!\n\nOn Wed, 8 Jan 2025 at 09:42, Kieran Bingham\n wrote:\n>\n> Hi Naush,\n>\n> Quoting Naushir Patuck (2025-01-08 09:03:22)\n> > From: Dave Stevenson \n> >\n> > Basic tuning done by David Plowman using a Waveshare SKU 28524\n> > \"IMX415-98 IR-CUT Camera\" module.\n> >\n> > Signed-off-by: Dave Stevenson \n>\n> Can I assume that you posting this one is an implicit RB or Acked-by tag\n> for the tuning content?\n>\n>\n> Acked-by: Kieran Bingham \n\nSorry my bad. All the patches should also have:\n\nReviewed-by: Naushir Patuck \n\n>\n>\n> > ---\n> > src/ipa/rpi/vc4/data/imx415.json | 413 +++++++++++++++++++++++++++++++\n> > src/ipa/rpi/vc4/data/meson.build | 1 +\n> > 2 files changed, 414 insertions(+)\n> > create mode 100755 src/ipa/rpi/vc4/data/imx415.json\n> >\n> > diff --git a/src/ipa/rpi/vc4/data/imx415.json b/src/ipa/rpi/vc4/data/imx415.json\n> > new file mode 100755\n> > index 000000000000..6ed16b173074\n> > --- /dev/null\n> > +++ b/src/ipa/rpi/vc4/data/imx415.json\n> > @@ -0,0 +1,413 @@\n> > +{\n> > + \"version\": 2.0,\n> > + \"target\": \"bcm2835\",\n> > + \"algorithms\": [\n> > + {\n> > + \"rpi.black_level\":\n> > + {\n> > + \"black_level\": 3840\n> > + }\n> > + },\n> > + {\n> > + \"rpi.dpc\": { }\n> > + },\n> > + {\n> > + \"rpi.lux\":\n> > + {\n> > + \"reference_shutter_speed\": 19230,\n> > + \"reference_gain\": 1.0,\n> > + \"reference_aperture\": 1.0,\n> > + \"reference_lux\": 1198,\n> > + \"reference_Y\": 14876\n> > + }\n> > + },\n> > + {\n> > + \"rpi.noise\":\n> > + {\n> > + \"reference_constant\": 17,\n> > + \"reference_slope\": 3.439\n> > + }\n> > + },\n> > + {\n> > + \"rpi.geq\":\n> > + {\n> > + \"offset\": 193,\n> > + \"slope\": 0.00902\n> > + }\n> > + },\n> > + {\n> > + \"rpi.sdn\": { }\n> > + },\n> > + {\n> > + \"rpi.awb\":\n> > + {\n> > + \"priors\": [\n> > + {\n> > + \"lux\": 0,\n> > + \"prior\":\n> > + [\n> > + 2000, 1.0,\n> > + 3000, 0.0,\n> > + 13000, 0.0\n> > + ]\n> > + },\n> > + {\n> > + \"lux\": 800,\n> > + \"prior\":\n> > + [\n> > + 2000, 0.0,\n> > + 6000, 2.0,\n> > + 13000, 2.0\n> > + ]\n> > + },\n> > + {\n> > + \"lux\": 1500,\n> > + \"prior\":\n> > + [\n> > + 2000, 0.0,\n> > + 4000, 1.0,\n> > + 6000, 6.0,\n> > + 6500, 7.0,\n> > + 7000, 1.0,\n> > + 13000, 1.0\n> > + ]\n> > + }\n> > + ],\n> > + \"modes\":\n> > + {\n> > + \"auto\":\n> > + {\n> > + \"lo\": 2500,\n> > + \"hi\": 8000\n> > + },\n> > + \"incandescent\":\n> > + {\n> > + \"lo\": 2500,\n> > + \"hi\": 3000\n> > + },\n> > + \"tungsten\":\n> > + {\n> > + \"lo\": 3000,\n> > + \"hi\": 3500\n> > + },\n> > + \"fluorescent\":\n> > + {\n> > + \"lo\": 4000,\n> > + \"hi\": 4700\n> > + },\n> > + \"indoor\":\n> > + {\n> > + \"lo\": 3000,\n> > + \"hi\": 5000\n> > + },\n> > + \"daylight\":\n> > + {\n> > + \"lo\": 5500,\n> > + \"hi\": 6500\n> > + },\n> > + \"cloudy\":\n> > + {\n> > + \"lo\": 7000,\n> > + \"hi\": 8600\n> > + }\n> > + },\n> > + \"bayes\": 1,\n> > + \"ct_curve\":\n> > + [\n> > + 2698.0, 0.7681, 0.2026,\n> > + 2930.0, 0.7515, 0.2116,\n> > + 3643.0, 0.6355, 0.2858,\n> > + 4605.0, 0.4992, 0.4041,\n> > + 5658.0, 0.4498, 0.4574\n> > + ],\n> > + \"sensitivity_r\": 1.0,\n> > + \"sensitivity_b\": 1.0,\n> > + \"transverse_pos\": 0.0112,\n> > + \"transverse_neg\": 0.01424\n> > + }\n> > + },\n> > + {\n> > + \"rpi.agc\":\n> > + {\n> > + \"metering_modes\":\n> > + {\n> > + \"centre-weighted\":\n> > + {\n> > + \"weights\":\n> > + [\n> > + 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> > + ]\n> > + },\n> > + \"spot\":\n> > + {\n> > + \"weights\":\n> > + [\n> > + 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> > + ]\n> > + },\n> > + \"matrix\":\n> > + {\n> > + \"weights\":\n> > + [\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> > + ]\n> > + }\n> > + },\n> > + \"exposure_modes\":\n> > + {\n> > + \"normal\":\n> > + {\n> > + \"shutter\": [ 100, 10000, 30000, 60000, 120000 ],\n> > + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> > + },\n> > + \"short\":\n> > + {\n> > + \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n> > + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> > + }\n> > + },\n> > + \"constraint_modes\":\n> > + {\n> > + \"normal\": [\n> > + {\n> > + \"bound\": \"LOWER\",\n> > + \"q_lo\": 0.98,\n> > + \"q_hi\": 1.0,\n> > + \"y_target\":\n> > + [\n> > + 0, 0.5,\n> > + 1000, 0.5\n> > + ]\n> > + }\n> > + ],\n> > + \"highlight\": [\n> > + {\n> > + \"bound\": \"LOWER\",\n> > + \"q_lo\": 0.98,\n> > + \"q_hi\": 1.0,\n> > + \"y_target\":\n> > + [\n> > + 0, 0.5,\n> > + 1000, 0.5\n> > + ]\n> > + },\n> > + {\n> > + \"bound\": \"UPPER\",\n> > + \"q_lo\": 0.98,\n> > + \"q_hi\": 1.0,\n> > + \"y_target\":\n> > + [\n> > + 0, 0.8,\n> > + 1000, 0.8\n> > + ]\n> > + }\n> > + ]\n> > + },\n> > + \"y_target\":\n> > + [\n> > + 0, 0.16,\n> > + 1000, 0.165,\n> > + 10000, 0.17\n> > + ]\n> > + }\n> > + },\n> > + {\n> > + \"rpi.alsc\":\n> > + {\n> > + \"omega\": 1.3,\n> > + \"n_iter\": 100,\n> > + \"luminance_strength\": 0.8,\n> > + \"calibrations_Cr\": [\n> > + {\n> > + \"ct\": 3000,\n> > + \"table\":\n> > + [\n> > + 1.025, 1.016, 1.013, 1.011, 1.008, 1.005, 1.003, 1.001, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.027, 1.035,\n> > + 1.025, 1.017, 1.013, 1.011, 1.008, 1.005, 1.003, 1.003, 1.004, 1.005, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> > + 1.022, 1.017, 1.013, 1.009, 1.007, 1.005, 1.003, 1.003, 1.004, 1.006, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> > + 1.019, 1.015, 1.011, 1.007, 1.005, 1.003, 1.001, 1.001, 1.003, 1.004, 1.007, 1.009, 1.015, 1.022, 1.028, 1.035,\n> > + 1.018, 1.014, 1.009, 1.006, 1.004, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.021, 1.028, 1.035,\n> > + 1.018, 1.013, 1.011, 1.006, 1.003, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.022, 1.028, 1.036,\n> > + 1.018, 1.014, 1.011, 1.007, 1.004, 1.002, 1.001, 1.001, 1.001, 1.004, 1.007, 1.009, 1.015, 1.023, 1.029, 1.036,\n> > + 1.019, 1.014, 1.012, 1.008, 1.005, 1.003, 1.002, 1.001, 1.003, 1.005, 1.008, 1.012, 1.016, 1.024, 1.031, 1.037,\n> > + 1.021, 1.016, 1.013, 1.009, 1.008, 1.005, 1.003, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.026, 1.033, 1.039,\n> > + 1.025, 1.021, 1.016, 1.013, 1.009, 1.008, 1.006, 1.006, 1.008, 1.011, 1.014, 1.019, 1.024, 1.031, 1.038, 1.046,\n> > + 1.029, 1.025, 1.021, 1.018, 1.014, 1.013, 1.011, 1.011, 1.012, 1.015, 1.019, 1.023, 1.028, 1.035, 1.046, 1.051,\n> > + 1.032, 1.029, 1.023, 1.021, 1.018, 1.015, 1.014, 1.014, 1.015, 1.018, 1.022, 1.027, 1.033, 1.041, 1.051, 1.054\n> > + ]\n> > + },\n> > + {\n> > + \"ct\": 5000,\n> > + \"table\":\n> > + [\n> > + 1.025, 1.011, 1.009, 1.005, 1.004, 1.003, 1.001, 1.001, 1.002, 1.006, 1.009, 1.012, 1.016, 1.021, 1.031, 1.041,\n> > + 1.025, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.004, 1.007, 1.009, 1.013, 1.021, 1.028, 1.037, 1.041,\n> > + 1.023, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.005, 1.007, 1.011, 1.014, 1.021, 1.028, 1.037, 1.048,\n> > + 1.022, 1.012, 1.007, 1.005, 1.002, 1.001, 1.001, 1.001, 1.003, 1.005, 1.009, 1.014, 1.019, 1.028, 1.039, 1.048,\n> > + 1.022, 1.011, 1.006, 1.003, 1.001, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.014, 1.021, 1.029, 1.039, 1.051,\n> > + 1.022, 1.012, 1.007, 1.003, 1.002, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.015, 1.021, 1.031, 1.041, 1.053,\n> > + 1.023, 1.013, 1.009, 1.005, 1.003, 1.003, 1.001, 1.002, 1.004, 1.006, 1.011, 1.015, 1.022, 1.031, 1.042, 1.056,\n> > + 1.024, 1.015, 1.012, 1.008, 1.005, 1.004, 1.004, 1.004, 1.006, 1.009, 1.013, 1.018, 1.024, 1.034, 1.045, 1.057,\n> > + 1.027, 1.017, 1.015, 1.012, 1.009, 1.007, 1.007, 1.008, 1.009, 1.013, 1.018, 1.023, 1.029, 1.038, 1.051, 1.061,\n> > + 1.029, 1.023, 1.017, 1.015, 1.014, 1.012, 1.011, 1.011, 1.014, 1.018, 1.024, 1.029, 1.036, 1.044, 1.056, 1.066,\n> > + 1.034, 1.028, 1.023, 1.022, 1.019, 1.019, 1.018, 1.018, 1.021, 1.025, 1.031, 1.035, 1.042, 1.053, 1.066, 1.074,\n> > + 1.041, 1.034, 1.027, 1.025, 1.025, 1.023, 1.023, 1.023, 1.025, 1.031, 1.035, 1.041, 1.049, 1.059, 1.074, 1.079\n> > + ]\n> > + }\n> > + ],\n> > + \"calibrations_Cb\": [\n> > + {\n> > + \"ct\": 3000,\n> > + \"table\":\n> > + [\n> > + 1.001, 1.001, 1.007, 1.015, 1.027, 1.034, 1.038, 1.041, 1.042, 1.043, 1.043, 1.043, 1.041, 1.039, 1.049, 1.054,\n> > + 1.011, 1.011, 1.013, 1.023, 1.032, 1.039, 1.044, 1.047, 1.052, 1.056, 1.059, 1.059, 1.055, 1.051, 1.054, 1.056,\n> > + 1.015, 1.015, 1.019, 1.032, 1.039, 1.044, 1.047, 1.052, 1.055, 1.059, 1.061, 1.066, 1.063, 1.058, 1.061, 1.064,\n> > + 1.016, 1.017, 1.023, 1.032, 1.041, 1.045, 1.048, 1.053, 1.056, 1.061, 1.066, 1.069, 1.067, 1.064, 1.065, 1.068,\n> > + 1.018, 1.019, 1.025, 1.033, 1.042, 1.045, 1.049, 1.054, 1.058, 1.063, 1.071, 1.072, 1.071, 1.068, 1.069, 1.071,\n> > + 1.023, 1.024, 1.029, 1.035, 1.043, 1.048, 1.052, 1.057, 1.061, 1.065, 1.074, 1.075, 1.075, 1.072, 1.072, 1.075,\n> > + 1.027, 1.028, 1.031, 1.038, 1.045, 1.051, 1.054, 1.059, 1.064, 1.068, 1.075, 1.079, 1.078, 1.075, 1.076, 1.081,\n> > + 1.029, 1.031, 1.033, 1.044, 1.048, 1.054, 1.059, 1.064, 1.067, 1.073, 1.079, 1.082, 1.082, 1.079, 1.081, 1.085,\n> > + 1.033, 1.033, 1.035, 1.047, 1.053, 1.058, 1.064, 1.067, 1.073, 1.079, 1.084, 1.086, 1.086, 1.084, 1.089, 1.091,\n> > + 1.037, 1.037, 1.038, 1.049, 1.057, 1.062, 1.068, 1.073, 1.079, 1.084, 1.089, 1.092, 1.092, 1.092, 1.096, 1.104,\n> > + 1.041, 1.041, 1.043, 1.051, 1.061, 1.068, 1.073, 1.079, 1.083, 1.089, 1.092, 1.094, 1.097, 1.099, 1.105, 1.115,\n> > + 1.048, 1.044, 1.044, 1.051, 1.063, 1.071, 1.076, 1.082, 1.088, 1.091, 1.094, 1.097, 1.099, 1.104, 1.115, 1.126\n> > + ]\n> > + },\n> > + {\n> > + \"ct\": 5000,\n> > + \"table\":\n> > + [\n> > + 1.001, 1.001, 1.005, 1.011, 1.014, 1.018, 1.019, 1.019, 1.019, 1.021, 1.021, 1.021, 1.019, 1.017, 1.014, 1.014,\n> > + 1.009, 1.009, 1.011, 1.014, 1.019, 1.024, 1.026, 1.029, 1.031, 1.032, 1.032, 1.031, 1.027, 1.023, 1.022, 1.022,\n> > + 1.011, 1.012, 1.015, 1.018, 1.024, 1.026, 1.029, 1.032, 1.035, 1.036, 1.036, 1.034, 1.031, 1.027, 1.025, 1.025,\n> > + 1.012, 1.013, 1.015, 1.019, 1.025, 1.029, 1.032, 1.035, 1.036, 1.038, 1.038, 1.036, 1.034, 1.029, 1.026, 1.026,\n> > + 1.013, 1.014, 1.016, 1.019, 1.027, 1.031, 1.034, 1.037, 1.039, 1.039, 1.041, 1.039, 1.036, 1.031, 1.028, 1.027,\n> > + 1.014, 1.014, 1.017, 1.021, 1.027, 1.033, 1.037, 1.039, 1.041, 1.041, 1.042, 1.042, 1.039, 1.033, 1.029, 1.028,\n> > + 1.015, 1.015, 1.018, 1.021, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.042, 1.042, 1.039, 1.034, 1.029, 1.029,\n> > + 1.015, 1.016, 1.018, 1.022, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.043, 1.043, 1.041, 1.035, 1.031, 1.031,\n> > + 1.015, 1.016, 1.018, 1.022, 1.027, 1.032, 1.037, 1.041, 1.042, 1.042, 1.044, 1.043, 1.041, 1.036, 1.034, 1.033,\n> > + 1.016, 1.017, 1.017, 1.022, 1.027, 1.032, 1.036, 1.039, 1.042, 1.042, 1.043, 1.043, 1.041, 1.039, 1.036, 1.034,\n> > + 1.017, 1.017, 1.018, 1.022, 1.027, 1.031, 1.035, 1.039, 1.041, 1.042, 1.042, 1.042, 1.042, 1.039, 1.039, 1.039,\n> > + 1.018, 1.017, 1.017, 1.021, 1.027, 1.031, 1.033, 1.038, 1.041, 1.041, 1.042, 1.042, 1.041, 1.041, 1.041, 1.041\n> > + ]\n> > + }\n> > + ],\n> > + \"luminance_lut\":\n> > + [\n> > + 2.102, 1.903, 1.658, 1.483, 1.358, 1.267, 1.202, 1.202, 1.202, 1.242, 1.323, 1.431, 1.585, 1.797, 2.096, 2.351,\n> > + 1.996, 1.776, 1.549, 1.385, 1.273, 1.204, 1.138, 1.133, 1.133, 1.185, 1.252, 1.343, 1.484, 1.679, 1.954, 2.228,\n> > + 1.923, 1.689, 1.474, 1.318, 1.204, 1.138, 1.079, 1.071, 1.071, 1.133, 1.185, 1.284, 1.415, 1.597, 1.854, 2.146,\n> > + 1.881, 1.631, 1.423, 1.272, 1.159, 1.079, 1.051, 1.026, 1.046, 1.071, 1.144, 1.245, 1.369, 1.543, 1.801, 2.095,\n> > + 1.867, 1.595, 1.391, 1.242, 1.131, 1.051, 1.013, 1.002, 1.013, 1.046, 1.121, 1.219, 1.343, 1.511, 1.752, 2.079,\n> > + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.001, 1.001, 1.003, 1.045, 1.118, 1.217, 1.342, 1.511, 1.746, 2.079,\n> > + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.011, 1.003, 1.011, 1.046, 1.118, 1.217, 1.343, 1.511, 1.746, 2.079,\n> > + 1.884, 1.621, 1.411, 1.261, 1.149, 1.071, 1.048, 1.024, 1.046, 1.069, 1.141, 1.239, 1.369, 1.541, 1.781, 2.093,\n> > + 1.913, 1.675, 1.459, 1.304, 1.191, 1.125, 1.071, 1.065, 1.069, 1.124, 1.181, 1.278, 1.413, 1.592, 1.842, 2.133,\n> > + 1.981, 1.755, 1.529, 1.368, 1.251, 1.191, 1.125, 1.124, 1.124, 1.181, 1.242, 1.337, 1.479, 1.669, 1.935, 2.207,\n> > + 2.078, 1.867, 1.625, 1.453, 1.344, 1.251, 1.202, 1.201, 1.201, 1.242, 1.333, 1.418, 1.571, 1.776, 2.063, 2.321,\n> > + 2.217, 2.011, 1.747, 1.562, 1.431, 1.331, 1.278, 1.278, 1.278, 1.313, 1.407, 1.523, 1.686, 1.911, 2.226, 2.484\n> > + ],\n> > + \"sigma\": 0.00135,\n> > + \"sigma_Cb\": 0.00279\n> > + }\n> > + },\n> > + {\n> > + \"rpi.contrast\":\n> > + {\n> > + \"ce_enable\": 1,\n> > + \"gamma_curve\":\n> > + [\n> > + 0, 0,\n> > + 1024, 5040,\n> > + 2048, 9338,\n> > + 3072, 12356,\n> > + 4096, 15312,\n> > + 5120, 18051,\n> > + 6144, 20790,\n> > + 7168, 23193,\n> > + 8192, 25744,\n> > + 9216, 27942,\n> > + 10240, 30035,\n> > + 11264, 32005,\n> > + 12288, 33975,\n> > + 13312, 35815,\n> > + 14336, 37600,\n> > + 15360, 39168,\n> > + 16384, 40642,\n> > + 18432, 43379,\n> > + 20480, 45749,\n> > + 22528, 47753,\n> > + 24576, 49621,\n> > + 26624, 51253,\n> > + 28672, 52698,\n> > + 30720, 53796,\n> > + 32768, 54876,\n> > + 36864, 57012,\n> > + 40960, 58656,\n> > + 45056, 59954,\n> > + 49152, 61183,\n> > + 53248, 62355,\n> > + 57344, 63419,\n> > + 61440, 64476,\n> > + 65535, 65535\n> > + ]\n> > + }\n> > + },\n> > + {\n> > + \"rpi.ccm\":\n> > + {\n> > + \"ccms\": [\n> > + {\n> > + \"ct\": 2698,\n> > + \"ccm\":\n> > + [\n> > + 1.57227, -0.32596, -0.24631,\n> > + -0.61264, 1.70791, -0.09526,\n> > + -0.43254, 0.48489, 0.94765\n> > + ]\n> > + },\n> > + {\n> > + \"ct\": 2930,\n> > + \"ccm\":\n> > + [\n> > + 1.69455, -0.52724, -0.16731,\n> > + -0.67131, 1.78468, -0.11338,\n> > + -0.41609, 0.54693, 0.86916\n> > + ]\n> > + },\n> > + {\n> > + \"ct\": 3643,\n> > + \"ccm\":\n> > + [\n> > + 1.74041, -0.77553, 0.03512,\n> > + -0.44073, 1.34131, 0.09943,\n> > + -0.11035, -0.93919, 2.04954\n> > + ]\n> > + },\n> > + {\n> > + \"ct\": 4605,\n> > + \"ccm\":\n> > + [\n> > + 1.49865, -0.41638, -0.08227,\n> > + -0.39445, 1.70114, -0.30669,\n> > + 0.01319, -0.88009, 1.86689\n> > + ]\n> > + },\n> > + {\n> > + \"ct\": 5658,\n> > + \"ccm\":\n> > + [\n> > + 1.38601, -0.23128, -0.15472,\n> > + -0.37641, 1.70444, -0.32803,\n> > + -0.01575, -0.71466, 1.73041\n> > + ]\n> > + }\n> > + ]\n> > + }\n> > + },\n> > + {\n> > + \"rpi.sharpen\": { }\n> > + }\n> > + ]\n> > +}\n> > diff --git a/src/ipa/rpi/vc4/data/meson.build b/src/ipa/rpi/vc4/data/meson.build\n> > index 94c0ee6e6b7b..7a8001ee4817 100644\n> > --- a/src/ipa/rpi/vc4/data/meson.build\n> > +++ b/src/ipa/rpi/vc4/data/meson.build\n> > @@ -9,6 +9,7 @@ conf_files = files([\n> > 'imx296_mono.json',\n> > 'imx327.json',\n> > 'imx378.json',\n> > + 'imx415.json',\n> > 'imx462.json',\n> > 'imx477.json',\n> > 'imx477_noir.json',\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBF63C3260\n\tfor ;\n\tWed, 8 Jan 2025 09:47:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D27DD61891;\n\tWed, 8 Jan 2025 10:47:39 +0100 (CET)","from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com\n\t[IPv6:2607:f8b0:4864:20::b2b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAE5761884\n\tfor ;\n\tWed, 8 Jan 2025 10:47:37 +0100 (CET)","by mail-yb1-xb2b.google.com with SMTP id\n\t3f1490d57ef6-e3c88163a00so2458261276.2\n\tfor ;\n\tWed, 08 Jan 2025 01:47:37 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QyrWBWtF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736329656; x=1736934456;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yBI6FVAfkmadCkKlxFNq0qWUX2jn+dZEgSHAYl90PbE=;\n\tb=QyrWBWtFnT6d+8Y+6QLO0ZH1GvS7mg7/3vxjczKu/tbEuhKSjTgIDnL3ZCIAG0oaaO\n\t5f01WRxcvRjchd932y4MIUM2gTISL0TZwQCC5sZkjKcuDjKajDmzylfH7tB92sdymDyj\n\tgqqBei4RgZup0G5zo1BRdgEYsY/sgK+oET1lFg/gyLdohd8m0J5crV6ii6lJ2n88R/Yz\n\tyqNLivYLGb10FAMudxr3pXzQWAedPA3VtV0QLfPFoWveeayj1CAHOWjHpKtv/4bMGLZH\n\tJwOa8FyOHpg+JMNhOcBf/T6p64zKOROghr2rbvrP0PyiVFTSQNpk2kZscchgO99QTs+7\n\tSy3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736329656; x=1736934456;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=yBI6FVAfkmadCkKlxFNq0qWUX2jn+dZEgSHAYl90PbE=;\n\tb=pTYcFtzw4Y/T4T96Whhd6LQAv9vzwvO1BZ1SayoyP9Fazoe8Y1X6EwIID0BJcRwbFr\n\tLpGyG07FH3ZKqUdB6w4ChIjisPH/+NC4UdovXp7sKvUWIDI/9vqHxASOjYLdEoH/ci3R\n\tQFk1TaRYwYMaYHFqNQYwTh9cg+O/SpvAmQtXZg39lXfMR5xn5RYEBMDcIWFO7x7Uwpm2\n\tdL8ASw6tF/RFji9JPbuRvQpYcjwWJ8cR4c1LlTNuCk/O9UjnzLYPDRM02OKi9k7E2U+E\n\tp4zt50ma5WER3s3bpHYaCVnUtP0TrWHVvo3N0EUIs0zNrx3JRoql5YLhqs5NdHASuuJH\n\tfaog==","X-Gm-Message-State":"AOJu0YxRTILfQJa+RmFjA3j2PTyJ03FiWYcymUNWErNil5fJ/lRboar7\n\tcJ+7o2oz/iZVYmfQP6tTiSx98uaPnoaso+2iU8zD8ky++AeSZ6I2tD4LH0+J+fJRpJ0gUJT16mV\n\tesOEl2xfFHutwbyOafJvDWz/Qq2JsT8E42QwZgDaIazDupLEQWbg=","X-Gm-Gg":"ASbGncuUdMjhl6SuxYlgNRHaGvGD/5D8qseoDhjeUv+qSGfHmgPBMm9Xr3u8NausZ8W\n\tCzhEKAFe+vcDrEFEGtpGlQ3/FWWuCU37hcn79GMQygstzGMEI7NDtjkMRnuorX4aE1Z0=","X-Google-Smtp-Source":"AGHT+IGLKjPYxt3haifOQP31TfKBx7cE9MLCf8UVTWK1ruP5CjcGBBJ0xKZF4C/1y1Ni38qB9s8LBuJ4b9SYIqauPtE=","X-Received":"by 2002:a05:690c:b84:b0:696:c33a:9cb9 with SMTP id\n\t00721157ae682-6f53129e312mr5746627b3.6.1736329656506; Wed, 08 Jan 2025\n\t01:47:36 -0800 (PST)","MIME-Version":"1.0","References":"<20250108090329.3185026-1-naush@raspberrypi.com>\n\t<20250108090329.3185026-3-naush@raspberrypi.com>\n\t<173632934198.2992722.3663993167462991165@ping.linuxembedded.co.uk>","In-Reply-To":"<173632934198.2992722.3663993167462991165@ping.linuxembedded.co.uk>","From":"Naushir Patuck ","Date":"Wed, 8 Jan 2025 09:47:03 +0000","X-Gm-Features":"AbW1kvbbtwDuYEb6uOcXy-bnfn1jdfQEgr9iD0NP5v3URp0rL2fj4BmbDS3_WwY","Message-ID":"","Subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, \n\tDave Stevenson ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32961,"web_url":"https://patchwork.libcamera.org/comment/32961/","msgid":"","date":"2025-01-08T09:48:51","subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nOn Wed, 8 Jan 2025 at 09:47, Naushir Patuck wrote:\n>\n> Hi Kieran,\n>\n> Happy New Year!\n>\n> On Wed, 8 Jan 2025 at 09:42, Kieran Bingham\n> wrote:\n> >\n> > Hi Naush,\n> >\n> > Quoting Naushir Patuck (2025-01-08 09:03:22)\n> > > From: Dave Stevenson \n> > >\n> > > Basic tuning done by David Plowman using a Waveshare SKU 28524\n> > > \"IMX415-98 IR-CUT Camera\" module.\n> > >\n> > > Signed-off-by: Dave Stevenson \n> >\n> > Can I assume that you posting this one is an implicit RB or Acked-by tag\n> > for the tuning content?\n> >\n> >\n> > Acked-by: Kieran Bingham \n>\n> Sorry my bad. All the patches should also have:\n>\n> Reviewed-by: Naushir Patuck \n\nAlso\n\nReviewed-by: David Plowman \n\nDavid\n\n>\n> >\n> >\n> > > ---\n> > > src/ipa/rpi/vc4/data/imx415.json | 413 +++++++++++++++++++++++++++++++\n> > > src/ipa/rpi/vc4/data/meson.build | 1 +\n> > > 2 files changed, 414 insertions(+)\n> > > create mode 100755 src/ipa/rpi/vc4/data/imx415.json\n> > >\n> > > diff --git a/src/ipa/rpi/vc4/data/imx415.json b/src/ipa/rpi/vc4/data/imx415.json\n> > > new file mode 100755\n> > > index 000000000000..6ed16b173074\n> > > --- /dev/null\n> > > +++ b/src/ipa/rpi/vc4/data/imx415.json\n> > > @@ -0,0 +1,413 @@\n> > > +{\n> > > + \"version\": 2.0,\n> > > + \"target\": \"bcm2835\",\n> > > + \"algorithms\": [\n> > > + {\n> > > + \"rpi.black_level\":\n> > > + {\n> > > + \"black_level\": 3840\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.dpc\": { }\n> > > + },\n> > > + {\n> > > + \"rpi.lux\":\n> > > + {\n> > > + \"reference_shutter_speed\": 19230,\n> > > + \"reference_gain\": 1.0,\n> > > + \"reference_aperture\": 1.0,\n> > > + \"reference_lux\": 1198,\n> > > + \"reference_Y\": 14876\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.noise\":\n> > > + {\n> > > + \"reference_constant\": 17,\n> > > + \"reference_slope\": 3.439\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.geq\":\n> > > + {\n> > > + \"offset\": 193,\n> > > + \"slope\": 0.00902\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.sdn\": { }\n> > > + },\n> > > + {\n> > > + \"rpi.awb\":\n> > > + {\n> > > + \"priors\": [\n> > > + {\n> > > + \"lux\": 0,\n> > > + \"prior\":\n> > > + [\n> > > + 2000, 1.0,\n> > > + 3000, 0.0,\n> > > + 13000, 0.0\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"lux\": 800,\n> > > + \"prior\":\n> > > + [\n> > > + 2000, 0.0,\n> > > + 6000, 2.0,\n> > > + 13000, 2.0\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"lux\": 1500,\n> > > + \"prior\":\n> > > + [\n> > > + 2000, 0.0,\n> > > + 4000, 1.0,\n> > > + 6000, 6.0,\n> > > + 6500, 7.0,\n> > > + 7000, 1.0,\n> > > + 13000, 1.0\n> > > + ]\n> > > + }\n> > > + ],\n> > > + \"modes\":\n> > > + {\n> > > + \"auto\":\n> > > + {\n> > > + \"lo\": 2500,\n> > > + \"hi\": 8000\n> > > + },\n> > > + \"incandescent\":\n> > > + {\n> > > + \"lo\": 2500,\n> > > + \"hi\": 3000\n> > > + },\n> > > + \"tungsten\":\n> > > + {\n> > > + \"lo\": 3000,\n> > > + \"hi\": 3500\n> > > + },\n> > > + \"fluorescent\":\n> > > + {\n> > > + \"lo\": 4000,\n> > > + \"hi\": 4700\n> > > + },\n> > > + \"indoor\":\n> > > + {\n> > > + \"lo\": 3000,\n> > > + \"hi\": 5000\n> > > + },\n> > > + \"daylight\":\n> > > + {\n> > > + \"lo\": 5500,\n> > > + \"hi\": 6500\n> > > + },\n> > > + \"cloudy\":\n> > > + {\n> > > + \"lo\": 7000,\n> > > + \"hi\": 8600\n> > > + }\n> > > + },\n> > > + \"bayes\": 1,\n> > > + \"ct_curve\":\n> > > + [\n> > > + 2698.0, 0.7681, 0.2026,\n> > > + 2930.0, 0.7515, 0.2116,\n> > > + 3643.0, 0.6355, 0.2858,\n> > > + 4605.0, 0.4992, 0.4041,\n> > > + 5658.0, 0.4498, 0.4574\n> > > + ],\n> > > + \"sensitivity_r\": 1.0,\n> > > + \"sensitivity_b\": 1.0,\n> > > + \"transverse_pos\": 0.0112,\n> > > + \"transverse_neg\": 0.01424\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.agc\":\n> > > + {\n> > > + \"metering_modes\":\n> > > + {\n> > > + \"centre-weighted\":\n> > > + {\n> > > + \"weights\":\n> > > + [\n> > > + 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> > > + ]\n> > > + },\n> > > + \"spot\":\n> > > + {\n> > > + \"weights\":\n> > > + [\n> > > + 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> > > + ]\n> > > + },\n> > > + \"matrix\":\n> > > + {\n> > > + \"weights\":\n> > > + [\n> > > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> > > + ]\n> > > + }\n> > > + },\n> > > + \"exposure_modes\":\n> > > + {\n> > > + \"normal\":\n> > > + {\n> > > + \"shutter\": [ 100, 10000, 30000, 60000, 120000 ],\n> > > + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> > > + },\n> > > + \"short\":\n> > > + {\n> > > + \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n> > > + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> > > + }\n> > > + },\n> > > + \"constraint_modes\":\n> > > + {\n> > > + \"normal\": [\n> > > + {\n> > > + \"bound\": \"LOWER\",\n> > > + \"q_lo\": 0.98,\n> > > + \"q_hi\": 1.0,\n> > > + \"y_target\":\n> > > + [\n> > > + 0, 0.5,\n> > > + 1000, 0.5\n> > > + ]\n> > > + }\n> > > + ],\n> > > + \"highlight\": [\n> > > + {\n> > > + \"bound\": \"LOWER\",\n> > > + \"q_lo\": 0.98,\n> > > + \"q_hi\": 1.0,\n> > > + \"y_target\":\n> > > + [\n> > > + 0, 0.5,\n> > > + 1000, 0.5\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"bound\": \"UPPER\",\n> > > + \"q_lo\": 0.98,\n> > > + \"q_hi\": 1.0,\n> > > + \"y_target\":\n> > > + [\n> > > + 0, 0.8,\n> > > + 1000, 0.8\n> > > + ]\n> > > + }\n> > > + ]\n> > > + },\n> > > + \"y_target\":\n> > > + [\n> > > + 0, 0.16,\n> > > + 1000, 0.165,\n> > > + 10000, 0.17\n> > > + ]\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.alsc\":\n> > > + {\n> > > + \"omega\": 1.3,\n> > > + \"n_iter\": 100,\n> > > + \"luminance_strength\": 0.8,\n> > > + \"calibrations_Cr\": [\n> > > + {\n> > > + \"ct\": 3000,\n> > > + \"table\":\n> > > + [\n> > > + 1.025, 1.016, 1.013, 1.011, 1.008, 1.005, 1.003, 1.001, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.027, 1.035,\n> > > + 1.025, 1.017, 1.013, 1.011, 1.008, 1.005, 1.003, 1.003, 1.004, 1.005, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> > > + 1.022, 1.017, 1.013, 1.009, 1.007, 1.005, 1.003, 1.003, 1.004, 1.006, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> > > + 1.019, 1.015, 1.011, 1.007, 1.005, 1.003, 1.001, 1.001, 1.003, 1.004, 1.007, 1.009, 1.015, 1.022, 1.028, 1.035,\n> > > + 1.018, 1.014, 1.009, 1.006, 1.004, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.021, 1.028, 1.035,\n> > > + 1.018, 1.013, 1.011, 1.006, 1.003, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.022, 1.028, 1.036,\n> > > + 1.018, 1.014, 1.011, 1.007, 1.004, 1.002, 1.001, 1.001, 1.001, 1.004, 1.007, 1.009, 1.015, 1.023, 1.029, 1.036,\n> > > + 1.019, 1.014, 1.012, 1.008, 1.005, 1.003, 1.002, 1.001, 1.003, 1.005, 1.008, 1.012, 1.016, 1.024, 1.031, 1.037,\n> > > + 1.021, 1.016, 1.013, 1.009, 1.008, 1.005, 1.003, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.026, 1.033, 1.039,\n> > > + 1.025, 1.021, 1.016, 1.013, 1.009, 1.008, 1.006, 1.006, 1.008, 1.011, 1.014, 1.019, 1.024, 1.031, 1.038, 1.046,\n> > > + 1.029, 1.025, 1.021, 1.018, 1.014, 1.013, 1.011, 1.011, 1.012, 1.015, 1.019, 1.023, 1.028, 1.035, 1.046, 1.051,\n> > > + 1.032, 1.029, 1.023, 1.021, 1.018, 1.015, 1.014, 1.014, 1.015, 1.018, 1.022, 1.027, 1.033, 1.041, 1.051, 1.054\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"ct\": 5000,\n> > > + \"table\":\n> > > + [\n> > > + 1.025, 1.011, 1.009, 1.005, 1.004, 1.003, 1.001, 1.001, 1.002, 1.006, 1.009, 1.012, 1.016, 1.021, 1.031, 1.041,\n> > > + 1.025, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.004, 1.007, 1.009, 1.013, 1.021, 1.028, 1.037, 1.041,\n> > > + 1.023, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.005, 1.007, 1.011, 1.014, 1.021, 1.028, 1.037, 1.048,\n> > > + 1.022, 1.012, 1.007, 1.005, 1.002, 1.001, 1.001, 1.001, 1.003, 1.005, 1.009, 1.014, 1.019, 1.028, 1.039, 1.048,\n> > > + 1.022, 1.011, 1.006, 1.003, 1.001, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.014, 1.021, 1.029, 1.039, 1.051,\n> > > + 1.022, 1.012, 1.007, 1.003, 1.002, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.015, 1.021, 1.031, 1.041, 1.053,\n> > > + 1.023, 1.013, 1.009, 1.005, 1.003, 1.003, 1.001, 1.002, 1.004, 1.006, 1.011, 1.015, 1.022, 1.031, 1.042, 1.056,\n> > > + 1.024, 1.015, 1.012, 1.008, 1.005, 1.004, 1.004, 1.004, 1.006, 1.009, 1.013, 1.018, 1.024, 1.034, 1.045, 1.057,\n> > > + 1.027, 1.017, 1.015, 1.012, 1.009, 1.007, 1.007, 1.008, 1.009, 1.013, 1.018, 1.023, 1.029, 1.038, 1.051, 1.061,\n> > > + 1.029, 1.023, 1.017, 1.015, 1.014, 1.012, 1.011, 1.011, 1.014, 1.018, 1.024, 1.029, 1.036, 1.044, 1.056, 1.066,\n> > > + 1.034, 1.028, 1.023, 1.022, 1.019, 1.019, 1.018, 1.018, 1.021, 1.025, 1.031, 1.035, 1.042, 1.053, 1.066, 1.074,\n> > > + 1.041, 1.034, 1.027, 1.025, 1.025, 1.023, 1.023, 1.023, 1.025, 1.031, 1.035, 1.041, 1.049, 1.059, 1.074, 1.079\n> > > + ]\n> > > + }\n> > > + ],\n> > > + \"calibrations_Cb\": [\n> > > + {\n> > > + \"ct\": 3000,\n> > > + \"table\":\n> > > + [\n> > > + 1.001, 1.001, 1.007, 1.015, 1.027, 1.034, 1.038, 1.041, 1.042, 1.043, 1.043, 1.043, 1.041, 1.039, 1.049, 1.054,\n> > > + 1.011, 1.011, 1.013, 1.023, 1.032, 1.039, 1.044, 1.047, 1.052, 1.056, 1.059, 1.059, 1.055, 1.051, 1.054, 1.056,\n> > > + 1.015, 1.015, 1.019, 1.032, 1.039, 1.044, 1.047, 1.052, 1.055, 1.059, 1.061, 1.066, 1.063, 1.058, 1.061, 1.064,\n> > > + 1.016, 1.017, 1.023, 1.032, 1.041, 1.045, 1.048, 1.053, 1.056, 1.061, 1.066, 1.069, 1.067, 1.064, 1.065, 1.068,\n> > > + 1.018, 1.019, 1.025, 1.033, 1.042, 1.045, 1.049, 1.054, 1.058, 1.063, 1.071, 1.072, 1.071, 1.068, 1.069, 1.071,\n> > > + 1.023, 1.024, 1.029, 1.035, 1.043, 1.048, 1.052, 1.057, 1.061, 1.065, 1.074, 1.075, 1.075, 1.072, 1.072, 1.075,\n> > > + 1.027, 1.028, 1.031, 1.038, 1.045, 1.051, 1.054, 1.059, 1.064, 1.068, 1.075, 1.079, 1.078, 1.075, 1.076, 1.081,\n> > > + 1.029, 1.031, 1.033, 1.044, 1.048, 1.054, 1.059, 1.064, 1.067, 1.073, 1.079, 1.082, 1.082, 1.079, 1.081, 1.085,\n> > > + 1.033, 1.033, 1.035, 1.047, 1.053, 1.058, 1.064, 1.067, 1.073, 1.079, 1.084, 1.086, 1.086, 1.084, 1.089, 1.091,\n> > > + 1.037, 1.037, 1.038, 1.049, 1.057, 1.062, 1.068, 1.073, 1.079, 1.084, 1.089, 1.092, 1.092, 1.092, 1.096, 1.104,\n> > > + 1.041, 1.041, 1.043, 1.051, 1.061, 1.068, 1.073, 1.079, 1.083, 1.089, 1.092, 1.094, 1.097, 1.099, 1.105, 1.115,\n> > > + 1.048, 1.044, 1.044, 1.051, 1.063, 1.071, 1.076, 1.082, 1.088, 1.091, 1.094, 1.097, 1.099, 1.104, 1.115, 1.126\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"ct\": 5000,\n> > > + \"table\":\n> > > + [\n> > > + 1.001, 1.001, 1.005, 1.011, 1.014, 1.018, 1.019, 1.019, 1.019, 1.021, 1.021, 1.021, 1.019, 1.017, 1.014, 1.014,\n> > > + 1.009, 1.009, 1.011, 1.014, 1.019, 1.024, 1.026, 1.029, 1.031, 1.032, 1.032, 1.031, 1.027, 1.023, 1.022, 1.022,\n> > > + 1.011, 1.012, 1.015, 1.018, 1.024, 1.026, 1.029, 1.032, 1.035, 1.036, 1.036, 1.034, 1.031, 1.027, 1.025, 1.025,\n> > > + 1.012, 1.013, 1.015, 1.019, 1.025, 1.029, 1.032, 1.035, 1.036, 1.038, 1.038, 1.036, 1.034, 1.029, 1.026, 1.026,\n> > > + 1.013, 1.014, 1.016, 1.019, 1.027, 1.031, 1.034, 1.037, 1.039, 1.039, 1.041, 1.039, 1.036, 1.031, 1.028, 1.027,\n> > > + 1.014, 1.014, 1.017, 1.021, 1.027, 1.033, 1.037, 1.039, 1.041, 1.041, 1.042, 1.042, 1.039, 1.033, 1.029, 1.028,\n> > > + 1.015, 1.015, 1.018, 1.021, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.042, 1.042, 1.039, 1.034, 1.029, 1.029,\n> > > + 1.015, 1.016, 1.018, 1.022, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.043, 1.043, 1.041, 1.035, 1.031, 1.031,\n> > > + 1.015, 1.016, 1.018, 1.022, 1.027, 1.032, 1.037, 1.041, 1.042, 1.042, 1.044, 1.043, 1.041, 1.036, 1.034, 1.033,\n> > > + 1.016, 1.017, 1.017, 1.022, 1.027, 1.032, 1.036, 1.039, 1.042, 1.042, 1.043, 1.043, 1.041, 1.039, 1.036, 1.034,\n> > > + 1.017, 1.017, 1.018, 1.022, 1.027, 1.031, 1.035, 1.039, 1.041, 1.042, 1.042, 1.042, 1.042, 1.039, 1.039, 1.039,\n> > > + 1.018, 1.017, 1.017, 1.021, 1.027, 1.031, 1.033, 1.038, 1.041, 1.041, 1.042, 1.042, 1.041, 1.041, 1.041, 1.041\n> > > + ]\n> > > + }\n> > > + ],\n> > > + \"luminance_lut\":\n> > > + [\n> > > + 2.102, 1.903, 1.658, 1.483, 1.358, 1.267, 1.202, 1.202, 1.202, 1.242, 1.323, 1.431, 1.585, 1.797, 2.096, 2.351,\n> > > + 1.996, 1.776, 1.549, 1.385, 1.273, 1.204, 1.138, 1.133, 1.133, 1.185, 1.252, 1.343, 1.484, 1.679, 1.954, 2.228,\n> > > + 1.923, 1.689, 1.474, 1.318, 1.204, 1.138, 1.079, 1.071, 1.071, 1.133, 1.185, 1.284, 1.415, 1.597, 1.854, 2.146,\n> > > + 1.881, 1.631, 1.423, 1.272, 1.159, 1.079, 1.051, 1.026, 1.046, 1.071, 1.144, 1.245, 1.369, 1.543, 1.801, 2.095,\n> > > + 1.867, 1.595, 1.391, 1.242, 1.131, 1.051, 1.013, 1.002, 1.013, 1.046, 1.121, 1.219, 1.343, 1.511, 1.752, 2.079,\n> > > + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.001, 1.001, 1.003, 1.045, 1.118, 1.217, 1.342, 1.511, 1.746, 2.079,\n> > > + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.011, 1.003, 1.011, 1.046, 1.118, 1.217, 1.343, 1.511, 1.746, 2.079,\n> > > + 1.884, 1.621, 1.411, 1.261, 1.149, 1.071, 1.048, 1.024, 1.046, 1.069, 1.141, 1.239, 1.369, 1.541, 1.781, 2.093,\n> > > + 1.913, 1.675, 1.459, 1.304, 1.191, 1.125, 1.071, 1.065, 1.069, 1.124, 1.181, 1.278, 1.413, 1.592, 1.842, 2.133,\n> > > + 1.981, 1.755, 1.529, 1.368, 1.251, 1.191, 1.125, 1.124, 1.124, 1.181, 1.242, 1.337, 1.479, 1.669, 1.935, 2.207,\n> > > + 2.078, 1.867, 1.625, 1.453, 1.344, 1.251, 1.202, 1.201, 1.201, 1.242, 1.333, 1.418, 1.571, 1.776, 2.063, 2.321,\n> > > + 2.217, 2.011, 1.747, 1.562, 1.431, 1.331, 1.278, 1.278, 1.278, 1.313, 1.407, 1.523, 1.686, 1.911, 2.226, 2.484\n> > > + ],\n> > > + \"sigma\": 0.00135,\n> > > + \"sigma_Cb\": 0.00279\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.contrast\":\n> > > + {\n> > > + \"ce_enable\": 1,\n> > > + \"gamma_curve\":\n> > > + [\n> > > + 0, 0,\n> > > + 1024, 5040,\n> > > + 2048, 9338,\n> > > + 3072, 12356,\n> > > + 4096, 15312,\n> > > + 5120, 18051,\n> > > + 6144, 20790,\n> > > + 7168, 23193,\n> > > + 8192, 25744,\n> > > + 9216, 27942,\n> > > + 10240, 30035,\n> > > + 11264, 32005,\n> > > + 12288, 33975,\n> > > + 13312, 35815,\n> > > + 14336, 37600,\n> > > + 15360, 39168,\n> > > + 16384, 40642,\n> > > + 18432, 43379,\n> > > + 20480, 45749,\n> > > + 22528, 47753,\n> > > + 24576, 49621,\n> > > + 26624, 51253,\n> > > + 28672, 52698,\n> > > + 30720, 53796,\n> > > + 32768, 54876,\n> > > + 36864, 57012,\n> > > + 40960, 58656,\n> > > + 45056, 59954,\n> > > + 49152, 61183,\n> > > + 53248, 62355,\n> > > + 57344, 63419,\n> > > + 61440, 64476,\n> > > + 65535, 65535\n> > > + ]\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.ccm\":\n> > > + {\n> > > + \"ccms\": [\n> > > + {\n> > > + \"ct\": 2698,\n> > > + \"ccm\":\n> > > + [\n> > > + 1.57227, -0.32596, -0.24631,\n> > > + -0.61264, 1.70791, -0.09526,\n> > > + -0.43254, 0.48489, 0.94765\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"ct\": 2930,\n> > > + \"ccm\":\n> > > + [\n> > > + 1.69455, -0.52724, -0.16731,\n> > > + -0.67131, 1.78468, -0.11338,\n> > > + -0.41609, 0.54693, 0.86916\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"ct\": 3643,\n> > > + \"ccm\":\n> > > + [\n> > > + 1.74041, -0.77553, 0.03512,\n> > > + -0.44073, 1.34131, 0.09943,\n> > > + -0.11035, -0.93919, 2.04954\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"ct\": 4605,\n> > > + \"ccm\":\n> > > + [\n> > > + 1.49865, -0.41638, -0.08227,\n> > > + -0.39445, 1.70114, -0.30669,\n> > > + 0.01319, -0.88009, 1.86689\n> > > + ]\n> > > + },\n> > > + {\n> > > + \"ct\": 5658,\n> > > + \"ccm\":\n> > > + [\n> > > + 1.38601, -0.23128, -0.15472,\n> > > + -0.37641, 1.70444, -0.32803,\n> > > + -0.01575, -0.71466, 1.73041\n> > > + ]\n> > > + }\n> > > + ]\n> > > + }\n> > > + },\n> > > + {\n> > > + \"rpi.sharpen\": { }\n> > > + }\n> > > + ]\n> > > +}\n> > > diff --git a/src/ipa/rpi/vc4/data/meson.build b/src/ipa/rpi/vc4/data/meson.build\n> > > index 94c0ee6e6b7b..7a8001ee4817 100644\n> > > --- a/src/ipa/rpi/vc4/data/meson.build\n> > > +++ b/src/ipa/rpi/vc4/data/meson.build\n> > > @@ -9,6 +9,7 @@ conf_files = files([\n> > > 'imx296_mono.json',\n> > > 'imx327.json',\n> > > 'imx378.json',\n> > > + 'imx415.json',\n> > > 'imx462.json',\n> > > 'imx477.json',\n> > > 'imx477_noir.json',\n> > > --\n> > > 2.43.0\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F41F0C3260\n\tfor ;\n\tWed, 8 Jan 2025 09:49:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAE97684E4;\n\tWed, 8 Jan 2025 10:49:05 +0100 (CET)","from mail-qt1-x831.google.com (mail-qt1-x831.google.com\n\t[IPv6:2607:f8b0:4864:20::831])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CA9C61891\n\tfor ;\n\tWed, 8 Jan 2025 10:49:03 +0100 (CET)","by mail-qt1-x831.google.com with SMTP id\n\td75a77b69052e-467a6781bc8so117557651cf.2\n\tfor ;\n\tWed, 08 Jan 2025 01:49:03 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Zo6/5Pd6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736329742; x=1736934542;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=VNlnzPjcQFzHRNZuDHuC5SgZRbvkzoTHXJHR+3oSIGE=;\n\tb=Zo6/5Pd65PRwcFnTiRgvKYfdwOWS6Dn2/yZfzeTFhPTe2DVskcyn1l22R68IxUNXjl\n\tick+K4mZrhYpvx8NCEaPB1Z87FT2EAptduPrutp810xBzot42ZRr+bvyFfVBBdRGgSso\n\tYWuI4/8N+18/X5iG2cEQ9/o5gv6/9axqDe1McLf8AsaXah1RDIKcQub3AE9ONAQqQyl4\n\tBmkedvZK5wrW/tEWI6WJqMmzf7eGe7TbnAUi8+Lb34mDhyJEwbzLH2bMps3Rl61xzg+Q\n\tcDw7IRbJw+8jLoBWK22t3y4UI+/Q+CZ/W6ilOZqWsNh4k5ZiB5c4RC/GRo5bGDGOh377\n\tqr3g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736329742; x=1736934542;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=VNlnzPjcQFzHRNZuDHuC5SgZRbvkzoTHXJHR+3oSIGE=;\n\tb=Ar+93ndVmbZlMGgkfrERFw6nADEO7/+nhGapT1lW0nTvm5SRWWrXDvl9DYSku+zsqV\n\tipVeCBbvyeZHoIuVVftOh2JNsLVCY84rKI3ef5fp76leBcJhJwFJt6+J4ICrFJDfnCtD\n\tqQQjOV3+d/sIUo9bmdwItCb/ZrvsE6OHlVlWNvJ4KpawXswAytgD8YtyrcIBAdRgHwwx\n\tGde3VNqiA4iZPGt6PxiPmZvsRMkTorlfbuvwsdt0z386azxV6LCoxRc6H/zUq1pU2XEg\n\tgCGV72gSW40BGC+XjHqpMB6TxuveD7eXoeuFemYC1EYBDeznb40VtucklIy1wCBynHNi\n\tisnw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXKliMqECyR7UDP4ZvkXleYjP5+Bt0KwQ3CuPjqbn3wBW+cX/t7Yaso6l9rX/fuO6Y0X3MDGXzlV+k5PhrL6t8=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yx280w/TsIN9F3pUoNn9umcINn51O4Y+JDWFqd++P+dFfupoHvy\n\tZpLCC1OZ5S7vX7vJOONk3olG7+qHMF7WkVHoPU15nl3xUfsk/sNItgU4kBFSqxn8bPErklxSRab\n\tFG/WZSP+dOBpWD94TPLPbNDfoKxtXbgMp422XZg==","X-Gm-Gg":"ASbGncsDHF0PtYQ/1dKToVXF/q+Kvvmpwo4wM5//E4KnMiuE2wX6D+FjwysADjB3mL9\n\tap7/MufLuXRgKRUDyM9w0+GH5ab4kmnBAsAavMvaKVzwTNtpXn67Rt6+U3NBMjWOE+a+aDQ==","X-Google-Smtp-Source":"AGHT+IG7zP/OqtNpZGnRj52+O4SXL0dHWNZuk7fKmDKr64s/tALMu5HDftqY50mMoFLS7FJroR8Ix/qtt1ebPKrhn4E=","X-Received":"by 2002:a05:622a:1312:b0:461:18f2:49be with SMTP id\n\td75a77b69052e-46c70ffe65fmr27269751cf.21.1736329741805;\n\tWed, 08 Jan 2025 01:49:01 -0800 (PST)","MIME-Version":"1.0","References":"<20250108090329.3185026-1-naush@raspberrypi.com>\n\t<20250108090329.3185026-3-naush@raspberrypi.com>\n\t<173632934198.2992722.3663993167462991165@ping.linuxembedded.co.uk>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Wed, 8 Jan 2025 09:48:51 +0000","X-Gm-Features":"AbW1kvY0TkBm9yTOPJxPfK_yF0Q6Aj9oNdLXcGYwpHv6XadyDYJwj9by9XVgsP0","Message-ID":"","Subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","To":"Naushir Patuck ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org, \n\tDave Stevenson ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32962,"web_url":"https://patchwork.libcamera.org/comment/32962/","msgid":"<173632989702.2992722.15769086482248304996@ping.linuxembedded.co.uk>","date":"2025-01-08T09:51:37","subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman (2025-01-08 09:48:51)\n> Hi everyone\n> \n> On Wed, 8 Jan 2025 at 09:47, Naushir Patuck wrote:\n> >\n> > Hi Kieran,\n> >\n> > Happy New Year!\n\nHappy new year indeed!\n\n> > On Wed, 8 Jan 2025 at 09:42, Kieran Bingham\n> > wrote:\n> > >\n> > > Hi Naush,\n> > >\n> > > Quoting Naushir Patuck (2025-01-08 09:03:22)\n> > > > From: Dave Stevenson \n> > > >\n> > > > Basic tuning done by David Plowman using a Waveshare SKU 28524\n> > > > \"IMX415-98 IR-CUT Camera\" module.\n> > > >\n> > > > Signed-off-by: Dave Stevenson \n> > >\n> > > Can I assume that you posting this one is an implicit RB or Acked-by tag\n> > > for the tuning content?\n> > >\n> > >\n> > > Acked-by: Kieran Bingham \n> >\n> > Sorry my bad. All the patches should also have:\n> >\n> > Reviewed-by: Naushir Patuck \n> \n> Also\n> \n> Reviewed-by: David Plowman \n> \n\nThanks - I'll push these through CI to merge!\n\n--\nKieran\n\n\n> David\n> \n> >\n> > >\n> > >\n> > > > ---\n> > > > src/ipa/rpi/vc4/data/imx415.json | 413 +++++++++++++++++++++++++++++++\n> > > > src/ipa/rpi/vc4/data/meson.build | 1 +\n> > > > 2 files changed, 414 insertions(+)\n> > > > create mode 100755 src/ipa/rpi/vc4/data/imx415.json\n> > > >\n> > > > diff --git a/src/ipa/rpi/vc4/data/imx415.json b/src/ipa/rpi/vc4/data/imx415.json\n> > > > new file mode 100755\n> > > > index 000000000000..6ed16b173074\n> > > > --- /dev/null\n> > > > +++ b/src/ipa/rpi/vc4/data/imx415.json\n> > > > @@ -0,0 +1,413 @@\n> > > > +{\n> > > > + \"version\": 2.0,\n> > > > + \"target\": \"bcm2835\",\n> > > > + \"algorithms\": [\n> > > > + {\n> > > > + \"rpi.black_level\":\n> > > > + {\n> > > > + \"black_level\": 3840\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.dpc\": { }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.lux\":\n> > > > + {\n> > > > + \"reference_shutter_speed\": 19230,\n> > > > + \"reference_gain\": 1.0,\n> > > > + \"reference_aperture\": 1.0,\n> > > > + \"reference_lux\": 1198,\n> > > > + \"reference_Y\": 14876\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.noise\":\n> > > > + {\n> > > > + \"reference_constant\": 17,\n> > > > + \"reference_slope\": 3.439\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.geq\":\n> > > > + {\n> > > > + \"offset\": 193,\n> > > > + \"slope\": 0.00902\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.sdn\": { }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.awb\":\n> > > > + {\n> > > > + \"priors\": [\n> > > > + {\n> > > > + \"lux\": 0,\n> > > > + \"prior\":\n> > > > + [\n> > > > + 2000, 1.0,\n> > > > + 3000, 0.0,\n> > > > + 13000, 0.0\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"lux\": 800,\n> > > > + \"prior\":\n> > > > + [\n> > > > + 2000, 0.0,\n> > > > + 6000, 2.0,\n> > > > + 13000, 2.0\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"lux\": 1500,\n> > > > + \"prior\":\n> > > > + [\n> > > > + 2000, 0.0,\n> > > > + 4000, 1.0,\n> > > > + 6000, 6.0,\n> > > > + 6500, 7.0,\n> > > > + 7000, 1.0,\n> > > > + 13000, 1.0\n> > > > + ]\n> > > > + }\n> > > > + ],\n> > > > + \"modes\":\n> > > > + {\n> > > > + \"auto\":\n> > > > + {\n> > > > + \"lo\": 2500,\n> > > > + \"hi\": 8000\n> > > > + },\n> > > > + \"incandescent\":\n> > > > + {\n> > > > + \"lo\": 2500,\n> > > > + \"hi\": 3000\n> > > > + },\n> > > > + \"tungsten\":\n> > > > + {\n> > > > + \"lo\": 3000,\n> > > > + \"hi\": 3500\n> > > > + },\n> > > > + \"fluorescent\":\n> > > > + {\n> > > > + \"lo\": 4000,\n> > > > + \"hi\": 4700\n> > > > + },\n> > > > + \"indoor\":\n> > > > + {\n> > > > + \"lo\": 3000,\n> > > > + \"hi\": 5000\n> > > > + },\n> > > > + \"daylight\":\n> > > > + {\n> > > > + \"lo\": 5500,\n> > > > + \"hi\": 6500\n> > > > + },\n> > > > + \"cloudy\":\n> > > > + {\n> > > > + \"lo\": 7000,\n> > > > + \"hi\": 8600\n> > > > + }\n> > > > + },\n> > > > + \"bayes\": 1,\n> > > > + \"ct_curve\":\n> > > > + [\n> > > > + 2698.0, 0.7681, 0.2026,\n> > > > + 2930.0, 0.7515, 0.2116,\n> > > > + 3643.0, 0.6355, 0.2858,\n> > > > + 4605.0, 0.4992, 0.4041,\n> > > > + 5658.0, 0.4498, 0.4574\n> > > > + ],\n> > > > + \"sensitivity_r\": 1.0,\n> > > > + \"sensitivity_b\": 1.0,\n> > > > + \"transverse_pos\": 0.0112,\n> > > > + \"transverse_neg\": 0.01424\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.agc\":\n> > > > + {\n> > > > + \"metering_modes\":\n> > > > + {\n> > > > + \"centre-weighted\":\n> > > > + {\n> > > > + \"weights\":\n> > > > + [\n> > > > + 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> > > > + ]\n> > > > + },\n> > > > + \"spot\":\n> > > > + {\n> > > > + \"weights\":\n> > > > + [\n> > > > + 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> > > > + ]\n> > > > + },\n> > > > + \"matrix\":\n> > > > + {\n> > > > + \"weights\":\n> > > > + [\n> > > > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> > > > + ]\n> > > > + }\n> > > > + },\n> > > > + \"exposure_modes\":\n> > > > + {\n> > > > + \"normal\":\n> > > > + {\n> > > > + \"shutter\": [ 100, 10000, 30000, 60000, 120000 ],\n> > > > + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> > > > + },\n> > > > + \"short\":\n> > > > + {\n> > > > + \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n> > > > + \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> > > > + }\n> > > > + },\n> > > > + \"constraint_modes\":\n> > > > + {\n> > > > + \"normal\": [\n> > > > + {\n> > > > + \"bound\": \"LOWER\",\n> > > > + \"q_lo\": 0.98,\n> > > > + \"q_hi\": 1.0,\n> > > > + \"y_target\":\n> > > > + [\n> > > > + 0, 0.5,\n> > > > + 1000, 0.5\n> > > > + ]\n> > > > + }\n> > > > + ],\n> > > > + \"highlight\": [\n> > > > + {\n> > > > + \"bound\": \"LOWER\",\n> > > > + \"q_lo\": 0.98,\n> > > > + \"q_hi\": 1.0,\n> > > > + \"y_target\":\n> > > > + [\n> > > > + 0, 0.5,\n> > > > + 1000, 0.5\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"bound\": \"UPPER\",\n> > > > + \"q_lo\": 0.98,\n> > > > + \"q_hi\": 1.0,\n> > > > + \"y_target\":\n> > > > + [\n> > > > + 0, 0.8,\n> > > > + 1000, 0.8\n> > > > + ]\n> > > > + }\n> > > > + ]\n> > > > + },\n> > > > + \"y_target\":\n> > > > + [\n> > > > + 0, 0.16,\n> > > > + 1000, 0.165,\n> > > > + 10000, 0.17\n> > > > + ]\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.alsc\":\n> > > > + {\n> > > > + \"omega\": 1.3,\n> > > > + \"n_iter\": 100,\n> > > > + \"luminance_strength\": 0.8,\n> > > > + \"calibrations_Cr\": [\n> > > > + {\n> > > > + \"ct\": 3000,\n> > > > + \"table\":\n> > > > + [\n> > > > + 1.025, 1.016, 1.013, 1.011, 1.008, 1.005, 1.003, 1.001, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.027, 1.035,\n> > > > + 1.025, 1.017, 1.013, 1.011, 1.008, 1.005, 1.003, 1.003, 1.004, 1.005, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> > > > + 1.022, 1.017, 1.013, 1.009, 1.007, 1.005, 1.003, 1.003, 1.004, 1.006, 1.009, 1.012, 1.017, 1.023, 1.029, 1.035,\n> > > > + 1.019, 1.015, 1.011, 1.007, 1.005, 1.003, 1.001, 1.001, 1.003, 1.004, 1.007, 1.009, 1.015, 1.022, 1.028, 1.035,\n> > > > + 1.018, 1.014, 1.009, 1.006, 1.004, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.021, 1.028, 1.035,\n> > > > + 1.018, 1.013, 1.011, 1.006, 1.003, 1.002, 1.001, 1.001, 1.001, 1.003, 1.006, 1.009, 1.015, 1.022, 1.028, 1.036,\n> > > > + 1.018, 1.014, 1.011, 1.007, 1.004, 1.002, 1.001, 1.001, 1.001, 1.004, 1.007, 1.009, 1.015, 1.023, 1.029, 1.036,\n> > > > + 1.019, 1.014, 1.012, 1.008, 1.005, 1.003, 1.002, 1.001, 1.003, 1.005, 1.008, 1.012, 1.016, 1.024, 1.031, 1.037,\n> > > > + 1.021, 1.016, 1.013, 1.009, 1.008, 1.005, 1.003, 1.003, 1.005, 1.008, 1.011, 1.014, 1.019, 1.026, 1.033, 1.039,\n> > > > + 1.025, 1.021, 1.016, 1.013, 1.009, 1.008, 1.006, 1.006, 1.008, 1.011, 1.014, 1.019, 1.024, 1.031, 1.038, 1.046,\n> > > > + 1.029, 1.025, 1.021, 1.018, 1.014, 1.013, 1.011, 1.011, 1.012, 1.015, 1.019, 1.023, 1.028, 1.035, 1.046, 1.051,\n> > > > + 1.032, 1.029, 1.023, 1.021, 1.018, 1.015, 1.014, 1.014, 1.015, 1.018, 1.022, 1.027, 1.033, 1.041, 1.051, 1.054\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"ct\": 5000,\n> > > > + \"table\":\n> > > > + [\n> > > > + 1.025, 1.011, 1.009, 1.005, 1.004, 1.003, 1.001, 1.001, 1.002, 1.006, 1.009, 1.012, 1.016, 1.021, 1.031, 1.041,\n> > > > + 1.025, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.004, 1.007, 1.009, 1.013, 1.021, 1.028, 1.037, 1.041,\n> > > > + 1.023, 1.014, 1.009, 1.007, 1.005, 1.004, 1.003, 1.003, 1.005, 1.007, 1.011, 1.014, 1.021, 1.028, 1.037, 1.048,\n> > > > + 1.022, 1.012, 1.007, 1.005, 1.002, 1.001, 1.001, 1.001, 1.003, 1.005, 1.009, 1.014, 1.019, 1.028, 1.039, 1.048,\n> > > > + 1.022, 1.011, 1.006, 1.003, 1.001, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.014, 1.021, 1.029, 1.039, 1.051,\n> > > > + 1.022, 1.012, 1.007, 1.003, 1.002, 1.001, 1.001, 1.001, 1.002, 1.005, 1.009, 1.015, 1.021, 1.031, 1.041, 1.053,\n> > > > + 1.023, 1.013, 1.009, 1.005, 1.003, 1.003, 1.001, 1.002, 1.004, 1.006, 1.011, 1.015, 1.022, 1.031, 1.042, 1.056,\n> > > > + 1.024, 1.015, 1.012, 1.008, 1.005, 1.004, 1.004, 1.004, 1.006, 1.009, 1.013, 1.018, 1.024, 1.034, 1.045, 1.057,\n> > > > + 1.027, 1.017, 1.015, 1.012, 1.009, 1.007, 1.007, 1.008, 1.009, 1.013, 1.018, 1.023, 1.029, 1.038, 1.051, 1.061,\n> > > > + 1.029, 1.023, 1.017, 1.015, 1.014, 1.012, 1.011, 1.011, 1.014, 1.018, 1.024, 1.029, 1.036, 1.044, 1.056, 1.066,\n> > > > + 1.034, 1.028, 1.023, 1.022, 1.019, 1.019, 1.018, 1.018, 1.021, 1.025, 1.031, 1.035, 1.042, 1.053, 1.066, 1.074,\n> > > > + 1.041, 1.034, 1.027, 1.025, 1.025, 1.023, 1.023, 1.023, 1.025, 1.031, 1.035, 1.041, 1.049, 1.059, 1.074, 1.079\n> > > > + ]\n> > > > + }\n> > > > + ],\n> > > > + \"calibrations_Cb\": [\n> > > > + {\n> > > > + \"ct\": 3000,\n> > > > + \"table\":\n> > > > + [\n> > > > + 1.001, 1.001, 1.007, 1.015, 1.027, 1.034, 1.038, 1.041, 1.042, 1.043, 1.043, 1.043, 1.041, 1.039, 1.049, 1.054,\n> > > > + 1.011, 1.011, 1.013, 1.023, 1.032, 1.039, 1.044, 1.047, 1.052, 1.056, 1.059, 1.059, 1.055, 1.051, 1.054, 1.056,\n> > > > + 1.015, 1.015, 1.019, 1.032, 1.039, 1.044, 1.047, 1.052, 1.055, 1.059, 1.061, 1.066, 1.063, 1.058, 1.061, 1.064,\n> > > > + 1.016, 1.017, 1.023, 1.032, 1.041, 1.045, 1.048, 1.053, 1.056, 1.061, 1.066, 1.069, 1.067, 1.064, 1.065, 1.068,\n> > > > + 1.018, 1.019, 1.025, 1.033, 1.042, 1.045, 1.049, 1.054, 1.058, 1.063, 1.071, 1.072, 1.071, 1.068, 1.069, 1.071,\n> > > > + 1.023, 1.024, 1.029, 1.035, 1.043, 1.048, 1.052, 1.057, 1.061, 1.065, 1.074, 1.075, 1.075, 1.072, 1.072, 1.075,\n> > > > + 1.027, 1.028, 1.031, 1.038, 1.045, 1.051, 1.054, 1.059, 1.064, 1.068, 1.075, 1.079, 1.078, 1.075, 1.076, 1.081,\n> > > > + 1.029, 1.031, 1.033, 1.044, 1.048, 1.054, 1.059, 1.064, 1.067, 1.073, 1.079, 1.082, 1.082, 1.079, 1.081, 1.085,\n> > > > + 1.033, 1.033, 1.035, 1.047, 1.053, 1.058, 1.064, 1.067, 1.073, 1.079, 1.084, 1.086, 1.086, 1.084, 1.089, 1.091,\n> > > > + 1.037, 1.037, 1.038, 1.049, 1.057, 1.062, 1.068, 1.073, 1.079, 1.084, 1.089, 1.092, 1.092, 1.092, 1.096, 1.104,\n> > > > + 1.041, 1.041, 1.043, 1.051, 1.061, 1.068, 1.073, 1.079, 1.083, 1.089, 1.092, 1.094, 1.097, 1.099, 1.105, 1.115,\n> > > > + 1.048, 1.044, 1.044, 1.051, 1.063, 1.071, 1.076, 1.082, 1.088, 1.091, 1.094, 1.097, 1.099, 1.104, 1.115, 1.126\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"ct\": 5000,\n> > > > + \"table\":\n> > > > + [\n> > > > + 1.001, 1.001, 1.005, 1.011, 1.014, 1.018, 1.019, 1.019, 1.019, 1.021, 1.021, 1.021, 1.019, 1.017, 1.014, 1.014,\n> > > > + 1.009, 1.009, 1.011, 1.014, 1.019, 1.024, 1.026, 1.029, 1.031, 1.032, 1.032, 1.031, 1.027, 1.023, 1.022, 1.022,\n> > > > + 1.011, 1.012, 1.015, 1.018, 1.024, 1.026, 1.029, 1.032, 1.035, 1.036, 1.036, 1.034, 1.031, 1.027, 1.025, 1.025,\n> > > > + 1.012, 1.013, 1.015, 1.019, 1.025, 1.029, 1.032, 1.035, 1.036, 1.038, 1.038, 1.036, 1.034, 1.029, 1.026, 1.026,\n> > > > + 1.013, 1.014, 1.016, 1.019, 1.027, 1.031, 1.034, 1.037, 1.039, 1.039, 1.041, 1.039, 1.036, 1.031, 1.028, 1.027,\n> > > > + 1.014, 1.014, 1.017, 1.021, 1.027, 1.033, 1.037, 1.039, 1.041, 1.041, 1.042, 1.042, 1.039, 1.033, 1.029, 1.028,\n> > > > + 1.015, 1.015, 1.018, 1.021, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.042, 1.042, 1.039, 1.034, 1.029, 1.029,\n> > > > + 1.015, 1.016, 1.018, 1.022, 1.027, 1.033, 1.037, 1.041, 1.041, 1.042, 1.043, 1.043, 1.041, 1.035, 1.031, 1.031,\n> > > > + 1.015, 1.016, 1.018, 1.022, 1.027, 1.032, 1.037, 1.041, 1.042, 1.042, 1.044, 1.043, 1.041, 1.036, 1.034, 1.033,\n> > > > + 1.016, 1.017, 1.017, 1.022, 1.027, 1.032, 1.036, 1.039, 1.042, 1.042, 1.043, 1.043, 1.041, 1.039, 1.036, 1.034,\n> > > > + 1.017, 1.017, 1.018, 1.022, 1.027, 1.031, 1.035, 1.039, 1.041, 1.042, 1.042, 1.042, 1.042, 1.039, 1.039, 1.039,\n> > > > + 1.018, 1.017, 1.017, 1.021, 1.027, 1.031, 1.033, 1.038, 1.041, 1.041, 1.042, 1.042, 1.041, 1.041, 1.041, 1.041\n> > > > + ]\n> > > > + }\n> > > > + ],\n> > > > + \"luminance_lut\":\n> > > > + [\n> > > > + 2.102, 1.903, 1.658, 1.483, 1.358, 1.267, 1.202, 1.202, 1.202, 1.242, 1.323, 1.431, 1.585, 1.797, 2.096, 2.351,\n> > > > + 1.996, 1.776, 1.549, 1.385, 1.273, 1.204, 1.138, 1.133, 1.133, 1.185, 1.252, 1.343, 1.484, 1.679, 1.954, 2.228,\n> > > > + 1.923, 1.689, 1.474, 1.318, 1.204, 1.138, 1.079, 1.071, 1.071, 1.133, 1.185, 1.284, 1.415, 1.597, 1.854, 2.146,\n> > > > + 1.881, 1.631, 1.423, 1.272, 1.159, 1.079, 1.051, 1.026, 1.046, 1.071, 1.144, 1.245, 1.369, 1.543, 1.801, 2.095,\n> > > > + 1.867, 1.595, 1.391, 1.242, 1.131, 1.051, 1.013, 1.002, 1.013, 1.046, 1.121, 1.219, 1.343, 1.511, 1.752, 2.079,\n> > > > + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.001, 1.001, 1.003, 1.045, 1.118, 1.217, 1.342, 1.511, 1.746, 2.079,\n> > > > + 1.867, 1.589, 1.385, 1.236, 1.125, 1.048, 1.011, 1.003, 1.011, 1.046, 1.118, 1.217, 1.343, 1.511, 1.746, 2.079,\n> > > > + 1.884, 1.621, 1.411, 1.261, 1.149, 1.071, 1.048, 1.024, 1.046, 1.069, 1.141, 1.239, 1.369, 1.541, 1.781, 2.093,\n> > > > + 1.913, 1.675, 1.459, 1.304, 1.191, 1.125, 1.071, 1.065, 1.069, 1.124, 1.181, 1.278, 1.413, 1.592, 1.842, 2.133,\n> > > > + 1.981, 1.755, 1.529, 1.368, 1.251, 1.191, 1.125, 1.124, 1.124, 1.181, 1.242, 1.337, 1.479, 1.669, 1.935, 2.207,\n> > > > + 2.078, 1.867, 1.625, 1.453, 1.344, 1.251, 1.202, 1.201, 1.201, 1.242, 1.333, 1.418, 1.571, 1.776, 2.063, 2.321,\n> > > > + 2.217, 2.011, 1.747, 1.562, 1.431, 1.331, 1.278, 1.278, 1.278, 1.313, 1.407, 1.523, 1.686, 1.911, 2.226, 2.484\n> > > > + ],\n> > > > + \"sigma\": 0.00135,\n> > > > + \"sigma_Cb\": 0.00279\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.contrast\":\n> > > > + {\n> > > > + \"ce_enable\": 1,\n> > > > + \"gamma_curve\":\n> > > > + [\n> > > > + 0, 0,\n> > > > + 1024, 5040,\n> > > > + 2048, 9338,\n> > > > + 3072, 12356,\n> > > > + 4096, 15312,\n> > > > + 5120, 18051,\n> > > > + 6144, 20790,\n> > > > + 7168, 23193,\n> > > > + 8192, 25744,\n> > > > + 9216, 27942,\n> > > > + 10240, 30035,\n> > > > + 11264, 32005,\n> > > > + 12288, 33975,\n> > > > + 13312, 35815,\n> > > > + 14336, 37600,\n> > > > + 15360, 39168,\n> > > > + 16384, 40642,\n> > > > + 18432, 43379,\n> > > > + 20480, 45749,\n> > > > + 22528, 47753,\n> > > > + 24576, 49621,\n> > > > + 26624, 51253,\n> > > > + 28672, 52698,\n> > > > + 30720, 53796,\n> > > > + 32768, 54876,\n> > > > + 36864, 57012,\n> > > > + 40960, 58656,\n> > > > + 45056, 59954,\n> > > > + 49152, 61183,\n> > > > + 53248, 62355,\n> > > > + 57344, 63419,\n> > > > + 61440, 64476,\n> > > > + 65535, 65535\n> > > > + ]\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.ccm\":\n> > > > + {\n> > > > + \"ccms\": [\n> > > > + {\n> > > > + \"ct\": 2698,\n> > > > + \"ccm\":\n> > > > + [\n> > > > + 1.57227, -0.32596, -0.24631,\n> > > > + -0.61264, 1.70791, -0.09526,\n> > > > + -0.43254, 0.48489, 0.94765\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"ct\": 2930,\n> > > > + \"ccm\":\n> > > > + [\n> > > > + 1.69455, -0.52724, -0.16731,\n> > > > + -0.67131, 1.78468, -0.11338,\n> > > > + -0.41609, 0.54693, 0.86916\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"ct\": 3643,\n> > > > + \"ccm\":\n> > > > + [\n> > > > + 1.74041, -0.77553, 0.03512,\n> > > > + -0.44073, 1.34131, 0.09943,\n> > > > + -0.11035, -0.93919, 2.04954\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"ct\": 4605,\n> > > > + \"ccm\":\n> > > > + [\n> > > > + 1.49865, -0.41638, -0.08227,\n> > > > + -0.39445, 1.70114, -0.30669,\n> > > > + 0.01319, -0.88009, 1.86689\n> > > > + ]\n> > > > + },\n> > > > + {\n> > > > + \"ct\": 5658,\n> > > > + \"ccm\":\n> > > > + [\n> > > > + 1.38601, -0.23128, -0.15472,\n> > > > + -0.37641, 1.70444, -0.32803,\n> > > > + -0.01575, -0.71466, 1.73041\n> > > > + ]\n> > > > + }\n> > > > + ]\n> > > > + }\n> > > > + },\n> > > > + {\n> > > > + \"rpi.sharpen\": { }\n> > > > + }\n> > > > + ]\n> > > > +}\n> > > > diff --git a/src/ipa/rpi/vc4/data/meson.build b/src/ipa/rpi/vc4/data/meson.build\n> > > > index 94c0ee6e6b7b..7a8001ee4817 100644\n> > > > --- a/src/ipa/rpi/vc4/data/meson.build\n> > > > +++ b/src/ipa/rpi/vc4/data/meson.build\n> > > > @@ -9,6 +9,7 @@ conf_files = files([\n> > > > 'imx296_mono.json',\n> > > > 'imx327.json',\n> > > > 'imx378.json',\n> > > > + 'imx415.json',\n> > > > 'imx462.json',\n> > > > 'imx477.json',\n> > > > 'imx477_noir.json',\n> > > > --\n> > > > 2.43.0\n> > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 874F7BD80A\n\tfor ;\n\tWed, 8 Jan 2025 09:51:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7819684E4;\n\tWed, 8 Jan 2025 10:51:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 887D261891\n\tfor ;\n\tWed, 8 Jan 2025 10:51:39 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABFCD3E;\n\tWed, 8 Jan 2025 10:50:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lUT6YmLc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736329846;\n\tbh=Tn3IsB4r6D7aWPmlJisEnaAl4eAlRVUA2B7q78lQdlM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lUT6YmLczVtO5fNQXPp4IX6rsPm8CQ0N840baLUuyanrH+yW2wnhsBi0uqQfpNG2a\n\tZ0M766xfRlY+oA+5fcA3XBo8gKNCSIyihMYcF52rkUlNgCTFIWYIVZk7a2DpNzuGqw\n\tYpku6WSPXc2ROuUMiIkfvI/gSQoItKvTaLkOI+3E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250108090329.3185026-1-naush@raspberrypi.com>\n\t<20250108090329.3185026-3-naush@raspberrypi.com>\n\t<173632934198.2992722.3663993167462991165@ping.linuxembedded.co.uk>\n\t\n\t","Subject":"Re: [PATCH v1 3/3] ipa: rpi: Add vc4 tuning files for imx415","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tDave Stevenson ","To":"David Plowman ,\n\tNaushir Patuck ","Date":"Wed, 08 Jan 2025 09:51:37 +0000","Message-ID":"<173632989702.2992722.15769086482248304996@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]