[{"id":32911,"web_url":"https://patchwork.libcamera.org/comment/32911/","msgid":"<20241230214110.GB31768@pendragon.ideasonboard.com>","date":"2024-12-30T21:41:10","subject":"Re: [PATCH] libcamera: add missing include to\n\tdma_buf_allocator.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sergei,\n\nThank you for the patch.\n\nOn Sat, Dec 28, 2024 at 07:11:19PM +0000, Sergei Trofimovich wrote:\n> Without the change the build fails on upcoming `gcc-15` as:\n> \n> In file included from ../src/libcamera/dma_buf_allocator.cpp:9:\n> ../include/libcamera/internal/dma_buf_allocator.h:66:19: error: 'uint64_t' has not been declared\n> 66 | void sync(uint64_t step);\n> | ^~~~~~~~\n\n\nThe patch is missing your Signed-off-by line. Please see\nhttps://libcamera.org/contributing.html#submitting-patches. Apart from\nthat, everything looks good.\n\nCould you please either resubmit the patch with the missing SoB line, or\nreply to this mail thread with the SoB ?\n\n> ---\n> include/libcamera/internal/dma_buf_allocator.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\n> index fc5de2c1..56341470 100644\n> --- a/include/libcamera/internal/dma_buf_allocator.h\n> +++ b/include/libcamera/internal/dma_buf_allocator.h\n> @@ -8,6 +8,7 @@\n> #pragma once\n> \n> #include \n> +#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 353BFBDCC1\n\tfor ;\n\tMon, 30 Dec 2024 21:41:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1882B684CC;\n\tMon, 30 Dec 2024 22:41:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F5A661894\n\tfor ;\n\tMon, 30 Dec 2024 22:41:10 +0100 (CET)","from pendragon.ideasonboard.com (85-76-70-5-nat.elisa-mobile.fi\n\t[85.76.70.5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 673D173B;\n\tMon, 30 Dec 2024 22:40:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HxR6stq4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1735594823;\n\tbh=+5Gn4aG9ZRezwd7u5pog9+RqgEGjULJ+4aJ+M+4A2Wc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HxR6stq4ci8bB0HibgJUpMRsijxo8Uv68evU1UnruMGW5wiGVCpzEtXKuzbNz8K4C\n\tMqBvCJtowtP1EbC2p/saOGgtJi4i/dJuLjYFkcXSEkNvgRQbCuZBRoh0+1j5AaslRI\n\tECWiMt3/8bg7mg12kL8ykz0h4yg/rbcILtVg/TPk=","Date":"Mon, 30 Dec 2024 23:41:10 +0200","From":"Laurent Pinchart ","To":"Sergei Trofimovich ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: add missing include to\n\tdma_buf_allocator.h","Message-ID":"<20241230214110.GB31768@pendragon.ideasonboard.com>","References":"<20241228191119.3159118-1-slyich@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241228191119.3159118-1-slyich@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32912,"web_url":"https://patchwork.libcamera.org/comment/32912/","msgid":"<20241230222739.5c2523a1@nz.home>","date":"2024-12-30T22:27:39","subject":"Re: [PATCH] libcamera: add missing include to\n\tdma_buf_allocator.h","submitter":{"id":203,"url":"https://patchwork.libcamera.org/api/people/203/","name":"Sergei Trofimovich","email":"slyich@gmail.com"},"content":"On Mon, 30 Dec 2024 23:41:10 +0200\nLaurent Pinchart wrote:\n\n> Hi Sergei,\n> \n> Thank you for the patch.\n> \n> On Sat, Dec 28, 2024 at 07:11:19PM +0000, Sergei Trofimovich wrote:\n> > Without the change the build fails on upcoming `gcc-15` as:\n> > \n> > In file included from ../src/libcamera/dma_buf_allocator.cpp:9:\n> > ../include/libcamera/internal/dma_buf_allocator.h:66:19: error: 'uint64_t' has not been declared\n> > 66 | void sync(uint64_t step);\n> > | ^~~~~~~~ \n> \n> \n> The patch is missing your Signed-off-by line. Please see\n> https://libcamera.org/contributing.html#submitting-patches. Apart from\n> that, everything looks good.\n> \n> Could you please either resubmit the patch with the missing SoB line, or\n> reply to this mail thread with the SoB ?\n\nAh, my apologies! Adding SoB as an email reply:\n\nSigned-off-by: Sergei Trofimovich \n\n> > ---\n> > include/libcamera/internal/dma_buf_allocator.h | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\n> > index fc5de2c1..56341470 100644\n> > --- a/include/libcamera/internal/dma_buf_allocator.h\n> > +++ b/include/libcamera/internal/dma_buf_allocator.h\n> > @@ -8,6 +8,7 @@\n> > #pragma once\n> > \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2315BD87C\n\tfor ;\n\tMon, 30 Dec 2024 22:27:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAA15684CD;\n\tMon, 30 Dec 2024 23:27:44 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C2E661894\n\tfor ;\n\tMon, 30 Dec 2024 23:27:42 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-43624b2d453so100175605e9.2\n\tfor ;\n\tMon, 30 Dec 2024 14:27:42 -0800 (PST)","from nz.home ([2a00:23c8:a613:101:729c:d1ff:fe4f:94a3])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4366128a62asm365077845e9.44.2024.12.30.14.27.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Dec 2024 14:27:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"H+HDcmcI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1735597662; x=1736202462;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:subject:cc:to:from:date:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=gswbWs1PFGaLqDs+Y6tWchC8BWbaTemxOA/zCCAy3kw=;\n\tb=H+HDcmcIhcv8pvqU7SyoJsjy+dB3k9u1xusEe/26Nx9MwiVyOpBOF7cNwrIvFCquwl\n\t5eRsfvJVKWpeGC/Sef7rYGDsJee9cELO0jlcNzwFmbn6gkMw7GuiFsJ0eiZLu4c1DOsK\n\tMzxi32nm7xyzgD/nGRGHrogIPeQURYBGkZ2P0z9gK3mAxSYKGogS1FTduMi/6eOI6muH\n\tgXSlue7iFglGhBJ0nR+80N+oEYXgMehZ58RgKZHa8bJ6PQYdiQVkGyMUjwdcQuB029sp\n\txIoV0ZJy9R4+p0/KqgwXxIxPrlWk7FY2UAG2eq62oF8J9c1ENSTsnDCmI+udu0O32ND1\n\tnJ+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1735597662; x=1736202462;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=gswbWs1PFGaLqDs+Y6tWchC8BWbaTemxOA/zCCAy3kw=;\n\tb=GqdouZEeVfDGYFa/zY8hV0svBtreWuZZC3DwDv7MYjvalVDRvnnOfGUsbbEf8GhpDn\n\tcndH3+KFvYPjPIECFm7LnxMAbp43Csgnj5t9FUNbTumiUV2h3Sr1aOrodcWdQpqM38jG\n\tzBgm6JBZEaiZRBPbvEsU5qZHtORweqyqHLZk+Z3+rN1C3eHjSxctQcFgdS1dGwLRwEFf\n\tSYfn8DhJBon7yd+7Yz6EB97bWAAEFyDEDlZty5odL/3N6rqDTdAtir4SIXTN6LyyEoKz\n\tjWMSSvs0uW9yhuVLDq08XnaN+vCMwk+PfF4ayPwangU/r9qloxGYlSOlOZg71crH0fkG\n\tZrfw==","X-Gm-Message-State":"AOJu0YzCK/73/wlkzITkLP9hxoYJi3ePQ6EmLugqNPp9vHFBwVtgWytM\n\tewQZjZYKm28/39gKdD5A8TXdJN2WHH2KOyt/gtuU/dgeev4lKhK2KgnAsw==","X-Gm-Gg":"ASbGncs8qIo5PNBP9BT76+QlJvTi1VWK9Gme8/RFaIKdgLTCLLdUon9wDCpF//slbIO\n\t3D2disiMKFRjRZmSg5i2pptjEY87y/s7VwUenZbHjb/WhaLiTqZfYoEvkYA6xXPhOPRFEghDKUv\n\ttn9gyMvy8jL1i4cBi8WAseNUsSp8kFX+XxLweCHsoxVXVDUupk4TF41c0Pe/4lDeprConxk8aGw\n\tUsF/3XFekIinkzFedhBfJs7SFhnBCnPSRmlue99uLyHoYYn","X-Google-Smtp-Source":"AGHT+IFhnFy29ySEJZQkHMsUPhc3o1ZE1gE9l6tE64swuOy+hCzXhmLfoWH4C5Qkr9q6tJ6ufFy5jg==","X-Received":"by 2002:a05:600c:a0a:b0:434:a04d:1670 with SMTP id\n\t5b1f17b1804b1-436678f5775mr357332965e9.0.1735597661639; \n\tMon, 30 Dec 2024 14:27:41 -0800 (PST)","Date":"Mon, 30 Dec 2024 22:27:39 +0000","From":"Sergei Trofimovich ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: add missing include to\n\tdma_buf_allocator.h","Message-ID":"<20241230222739.5c2523a1@nz.home>","In-Reply-To":"<20241230214110.GB31768@pendragon.ideasonboard.com>","References":"<20241228191119.3159118-1-slyich@gmail.com>\n\t<20241230214110.GB31768@pendragon.ideasonboard.com>","X-Mailer":"Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32922,"web_url":"https://patchwork.libcamera.org/comment/32922/","msgid":"<173589977648.3979975.10245173574451749550@ping.linuxembedded.co.uk>","date":"2025-01-03T10:22:56","subject":"Re: [PATCH] libcamera: add missing include to\n\tdma_buf_allocator.h","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Sergei Trofimovich (2024-12-30 22:27:39)\n> On Mon, 30 Dec 2024 23:41:10 +0200\n> Laurent Pinchart wrote:\n> \n> > Hi Sergei,\n> > \n> > Thank you for the patch.\n> > \n> > On Sat, Dec 28, 2024 at 07:11:19PM +0000, Sergei Trofimovich wrote:\n> > > Without the change the build fails on upcoming `gcc-15` as:\n> > > \n> > > In file included from ../src/libcamera/dma_buf_allocator.cpp:9:\n> > > ../include/libcamera/internal/dma_buf_allocator.h:66:19: error: 'uint64_t' has not been declared\n> > > 66 | void sync(uint64_t step);\n> > > | ^~~~~~~~ \n> > \n> > \n> > The patch is missing your Signed-off-by line. Please see\n> > https://libcamera.org/contributing.html#submitting-patches. Apart from\n> > that, everything looks good.\n> > \n> > Could you please either resubmit the patch with the missing SoB line, or\n> > reply to this mail thread with the SoB ?\n> \n> Ah, my apologies! Adding SoB as an email reply:\n> \n> Signed-off-by: Sergei Trofimovich \n\nReviewed-by: Kieran Bingham \n\n> \n> > > ---\n> > > include/libcamera/internal/dma_buf_allocator.h | 1 +\n> > > 1 file changed, 1 insertion(+)\n> > > \n> > > diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\n> > > index fc5de2c1..56341470 100644\n> > > --- a/include/libcamera/internal/dma_buf_allocator.h\n> > > +++ b/include/libcamera/internal/dma_buf_allocator.h\n> > > @@ -8,6 +8,7 @@\n> > > #pragma once\n> > > \n> > > #include \n> > > +#include \n> > > #include \n> > > #include \n> > > \n> > \n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart\n> \n> \n> -- \n> \n> Sergei","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA884C324C\n\tfor ;\n\tFri, 3 Jan 2025 10:23:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C84D684E7;\n\tFri, 3 Jan 2025 11:23:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C377684CD\n\tfor ;\n\tFri, 3 Jan 2025 11:22:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3CD9A44;\n\tFri, 3 Jan 2025 11:22:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T8XceWQp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1735899729;\n\tbh=tg4Ac0u2S7ob/ovW79XSMXBgFTnNVcdsS3M7CeFGFUE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=T8XceWQpVXiD+MhQv+RH3hnhBg7LW1e4ItL7rTRQMRdYFxkt3L6yCB4UaUK32P6Fl\n\tGZMUCg80MqKbk0ukRfKvxZXfJfA0v3Jf9vmkUAbHLLPmegdu1R1PiHHuee5vRBdwmu\n\tck155yVerC2YRAUsATY4/67QYoH4omMXdH66Gi20=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241230222739.5c2523a1@nz.home>","References":"<20241228191119.3159118-1-slyich@gmail.com>\n\t<20241230214110.GB31768@pendragon.ideasonboard.com>\n\t<20241230222739.5c2523a1@nz.home>","Subject":"Re: [PATCH] libcamera: add missing include to\n\tdma_buf_allocator.h","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tSergei Trofimovich ","Date":"Fri, 03 Jan 2025 10:22:56 +0000","Message-ID":"<173589977648.3979975.10245173574451749550@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]