[{"id":33405,"web_url":"https://patchwork.libcamera.org/comment/33405/","msgid":"","date":"2025-02-20T08:49:10","subject":"Re: [RFC PATCH 3/7] pipeline: rkisp1: Include frame number when\n\tpushing to delayed controls","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 05:26:49PM +0100, Stefan Klug wrote:\n\nMissing message... (but otherwise the code and the title are good)\n\n\nPaul\n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 35c793da9bba..71a07c6027b9 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -428,10 +428,10 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n> \t\tselfPath_->queueBuffer(info->selfPathBuffer);\n> }\n> \n> -void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,\n> +void RkISP1CameraData::setSensorControls(unsigned int frame,\n> \t\t\t\t\t const ControlList &sensorControls)\n> {\n> -\tdelayedCtrls_->push(sensorControls);\n> +\tdelayedCtrls_->push(frame, sensorControls);\n> }\n> \n> void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81D41BEFBE\n\tfor ;\n\tThu, 20 Feb 2025 08:49:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A73F68697;\n\tThu, 20 Feb 2025 09:49:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C203968692\n\tfor ;\n\tThu, 20 Feb 2025 09:49:17 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:4292:75df:25cd:1836])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73C68526;\n\tThu, 20 Feb 2025 09:47:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"icf2s1I/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740041274;\n\tbh=YMjbIQ0Afm7tDCrVI7KhH3oxryb+8DTUiiQMqt970H4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=icf2s1I/vJ0Dta4X/oXG5tvkx/4qld52edcg78Asd82RnNFNRoN1zf1VzN+X6dYeW\n\tCYubCeVYuo3DO8mcc/HarfxZzgmEu6XTG3k4iRojaM6YCKrweC/z8xoRvSze5KC765\n\t/lbCQ4CFV4rkxSUrwpMZKRsYcCZCGdVs2tbgCKKg=","Date":"Thu, 20 Feb 2025 17:49:10 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH 3/7] pipeline: rkisp1: Include frame number when\n\tpushing to delayed controls","Message-ID":"","References":"<20241220162724.756494-1-stefan.klug@ideasonboard.com>\n\t<20241220162724.756494-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241220162724.756494-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]