{"id":22443,"url":"https://patchwork.libcamera.org/api/patches/22443/?format=json","web_url":"https://patchwork.libcamera.org/patch/22443/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241220162724.756494-4-stefan.klug@ideasonboard.com>","date":"2024-12-20T16:26:49","name":"[RFC,3/7] pipeline: rkisp1: Include frame number when pushing to delayed controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"91e26a962a568ebada99c4573f5ba48869d4b66d","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22443/mbox/","series":[{"id":4925,"url":"https://patchwork.libcamera.org/api/series/4925/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4925","date":"2024-12-20T16:26:46","name":"Improve regulation on rkisp1","version":1,"mbox":"https://patchwork.libcamera.org/series/4925/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22443/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22443/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 204F0C327D\n\tfor ;\n\tFri, 20 Dec 2024 16:27:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C345A684BC;\n\tFri, 20 Dec 2024 17:27:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA717684AE\n\tfor ;\n\tFri, 20 Dec 2024 17:27:35 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4eeb:7fa7:1fd0:c13d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B85DC67;\n\tFri, 20 Dec 2024 17:26:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v8jR545r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734712016;\n\tbh=J1rNZ/NREyYKPTQu6aiTkxgNCZ3O1+ARk90EFyPe+DI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=v8jR545rSCzBnsAuiMlbRsOibKUfghgmswxNs8nef1AfEJH+Eo3UoBjOHl9tyVX7U\n\tyK4qJRcWIQzsDxq7iU+YwUQS9aDbayhli7puslaMsynz8wUVexQFcXK1GNfWTFOxwY\n\tbNGIpxgWFhIk7W0dRZRvM1Szl48AlyjZZkROG13Q=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[RFC PATCH 3/7] pipeline: rkisp1: Include frame number when pushing\n\tto delayed controls","Date":"Fri, 20 Dec 2024 17:26:49 +0100","Message-ID":"<20241220162724.756494-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241220162724.756494-1-stefan.klug@ideasonboard.com>","References":"<20241220162724.756494-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 35c793da9bba..71a07c6027b9 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -428,10 +428,10 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\tselfPath_->queueBuffer(info->selfPathBuffer);\n }\n \n-void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,\n+void RkISP1CameraData::setSensorControls(unsigned int frame,\n \t\t\t\t\t const ControlList &sensorControls)\n {\n-\tdelayedCtrls_->push(sensorControls);\n+\tdelayedCtrls_->push(frame, sensorControls);\n }\n \n void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)\n","prefixes":["RFC","3/7"]}