[{"id":33404,"web_url":"https://patchwork.libcamera.org/comment/33404/","msgid":"","date":"2025-02-20T08:47:58","subject":"Re: [RFC PATCH 2/7] libcamera: delayed_controls: Increase log level\n\tfor dummy pushes","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 05:26:48PM +0100, Stefan Klug wrote:\n> When an automatic no-op is queued a debug message is printed. Change the\n> debug level to warning, because that situation is actually an indication\n> of something going seriously out of sync.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/delayed_controls.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n> index 6c82d5058ae8..2f134cbe7fdd 100644\n> --- a/src/libcamera/delayed_controls.cpp\n> +++ b/src/libcamera/delayed_controls.cpp\n> @@ -303,7 +303,7 @@ void DelayedControls::applyControls(uint32_t sequence)\n> \twriteCount_ = sequence + 1;\n> \n> \twhile (writeCount_ > queueCount_) {\n> -\t\tLOG(DelayedControls, Debug)\n> +\t\tLOG(DelayedControls, Warning)\n> \t\t\t<< \"Queue is empty, auto queue no-op.\";\n> \t\tpush(queueCount_, {});\n> \t}\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FFB2BE175\n\tfor ;\n\tThu, 20 Feb 2025 08:48:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC7186869C;\n\tThu, 20 Feb 2025 09:48:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B451168692\n\tfor ;\n\tThu, 20 Feb 2025 09:48:06 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:4292:75df:25cd:1836])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69C5E526;\n\tThu, 20 Feb 2025 09:46:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZYnZzV/R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740041203;\n\tbh=ph1itgwi8Q1I34upfbuZM43aZKG04Ku+v43FaKtbefE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZYnZzV/R9h4gG4YeJ0A55dE3XVDfKgi/ssmu1tvpITtTJYKL92idKjDr4uiJlOcjE\n\tSOvklR5dPFjk5sjJCDd/QOSki4per5RVu8432UEd5KfoJ55c5ljHL0ZeyYrOGD+ol/\n\t+Fkr9L9GTO0MbPs5JK8YuCDbRI7jHftj+GLcG5Nc=","Date":"Thu, 20 Feb 2025 17:47:58 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH 2/7] libcamera: delayed_controls: Increase log level\n\tfor dummy pushes","Message-ID":"","References":"<20241220162724.756494-1-stefan.klug@ideasonboard.com>\n\t<20241220162724.756494-3-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241220162724.756494-3-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]