[{"id":32908,"web_url":"https://patchwork.libcamera.org/comment/32908/","msgid":"<20241220180055.GB2974@pendragon.ideasonboard.com>","date":"2024-12-20T18:00:55","subject":"Re: [PATCH] utils: gen-debug-controls: Output direction flag","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 05:25:28PM +0100, Stefan Klug wrote:\n> The yaml definitions for controls now require a direction attribute\n> which is not auto generated by gen-debug-controls.py. Fix that.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/gen-debug-controls.py | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\n> index 025850731c0b..272597f4874f 100755\n> --- a/utils/gen-debug-controls.py\n> +++ b/utils/gen-debug-controls.py\n> @@ -106,6 +106,7 @@ def main(argv):\n> \n> p = m.file.relative_to(root_dir)\n> desc = {'type': m.type,\n> + 'direction': 'out',\n> 'description': f'Debug control {m.name} found in {p}:{m.line}'}\n> if m.size is not None:\n> desc['size'] = m.size","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A6B9C3274\n\tfor ;\n\tFri, 20 Dec 2024 18:01:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 246E7684BB;\n\tFri, 20 Dec 2024 19:01:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 580E76808F\n\tfor ;\n\tFri, 20 Dec 2024 19:01:01 +0100 (CET)","from pendragon.ideasonboard.com (unknown [95.214.66.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5A3F16A;\n\tFri, 20 Dec 2024 19:00:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GjztWxc5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734717621;\n\tbh=kzKo4FirCmHDkHZo0XX9XWG618V1OjIslJR5r4ykvCo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GjztWxc5xDlvsEWUVxFqnbt20TqQj/Jnhp5BH7KU9/4O0BgFvVHOt41hV5l2o4iq5\n\t0jSq8EhaQgU/BzxGrQkvXkb6QyV+CrtzXHHFTt06B9cmyDBwdRPur8d5hCgbvrr35F\n\t8TQFo5faQv6i9Hogcf4+92KFtqQ7rbkRQk6IwidM=","Date":"Fri, 20 Dec 2024 20:00:55 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] utils: gen-debug-controls: Output direction flag","Message-ID":"<20241220180055.GB2974@pendragon.ideasonboard.com>","References":"<20241220162601.755377-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241220162601.755377-1-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32909,"web_url":"https://patchwork.libcamera.org/comment/32909/","msgid":"<173471797293.32744.11390874702205090943@ping.linuxembedded.co.uk>","date":"2024-12-20T18:06:12","subject":"Re: [PATCH] utils: gen-debug-controls: Output direction flag","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-12-20 16:25:28)\n> The yaml definitions for controls now require a direction attribute\n> which is not auto generated by gen-debug-controls.py. Fix that.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> utils/gen-debug-controls.py | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\n> index 025850731c0b..272597f4874f 100755\n> --- a/utils/gen-debug-controls.py\n> +++ b/utils/gen-debug-controls.py\n> @@ -106,6 +106,7 @@ def main(argv):\n> \n> p = m.file.relative_to(root_dir)\n> desc = {'type': m.type,\n> + 'direction': 'out',\n\n\nReviewed-by: Kieran Bingham \n\n> 'description': f'Debug control {m.name} found in {p}:{m.line}'}\n> if m.size is not None:\n> desc['size'] = m.size\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0B7EC327D\n\tfor ;\n\tFri, 20 Dec 2024 18:06:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0C57684C0;\n\tFri, 20 Dec 2024 19:06:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 362FF684A3\n\tfor ;\n\tFri, 20 Dec 2024 19:06:16 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96A4916A;\n\tFri, 20 Dec 2024 19:05:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P0ic7wPM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734717936;\n\tbh=YEblhlx/5UkBO44VCEmwiHFdw8ZLjaiA1RhIB39gSeA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=P0ic7wPMMcyylsXQbDm1S8u1+Js2MsCuCt7P4fk1rfgCxWxBP1euco5njklkYvL5c\n\tI9XAs0nYuYzS73Y5cs/wjCYLWYHN5/PnQUmCFV5qU6frOscKAdLGmBkfmQ294bT8OU\n\t9gQjCAzeL8SxwFI8rr3ox1CrGN8PcepuDESqnbaI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241220162601.755377-1-stefan.klug@ideasonboard.com>","References":"<20241220162601.755377-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH] utils: gen-debug-controls: Output direction flag","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 20 Dec 2024 18:06:12 +0000","Message-ID":"<173471797293.32744.11390874702205090943@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]