{"id":22435,"url":"https://patchwork.libcamera.org/api/patches/22435/?format=json","web_url":"https://patchwork.libcamera.org/patch/22435/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241220150759.709756-10-pobrn@protonmail.com>","date":"2024-12-20T15:08:41","name":"[RFC,v1,09/12] apps: lc-compliance: Check number of buffers in allocator","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7461e63fc4cf47fd2176897694d5274cc91e1b9a","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22435/mbox/","series":[{"id":4923,"url":"https://patchwork.libcamera.org/api/series/4923/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4923","date":"2024-12-20T15:08:03","name":"apps: lc-compliance: Multi-stream tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4923/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22435/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22435/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3E10C3272\n\tfor ;\n\tFri, 20 Dec 2024 15:08:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90A31684AF;\n\tFri, 20 Dec 2024 16:08:48 +0100 (CET)","from mail-10630.protonmail.ch (mail-10630.protonmail.ch\n\t[79.135.106.30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FF79684AC\n\tfor ;\n\tFri, 20 Dec 2024 16:08:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"QWUDwiFw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734707326; x=1734966526;\n\tbh=+iiPDfrcCv9OFJskYucvmMVv7O2CT3WTy/jBR5SZ7DE=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=QWUDwiFwr9d9tgR/pAlVMm+FTPYdKadMTILavWYgXqC/ZxcQ4pVn9HrBjxHGuzOYe\n\tn8llUSv4yGr50bW1PIZyfXpedroe0DXNyWE13QjZs2zWuqvH/m24zhZY5v6yhVt0nn\n\tMOgEYc9RRnC7zRnWaNyozPOHq5BlmJm7NyzxpczbbQvd2w3qXYP0SM754h3/EpmqSY\n\tMmNF38RZKp732jdzNr0U+bMYfCdYAbpopBbyb7k83jSJxdJkvg/S4QyP9lfQXWfByI\n\typqpZx0Tvsp52XIIy1cnHXT5GxwAvzpoF289gxZ2PV88z8RZAPRMIyeK8ePczeJJE/\n\thg29YArhi8kOw==","Date":"Fri, 20 Dec 2024 15:08:41 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[RFC PATCH v1 09/12] apps: lc-compliance: Check number of buffers in\n\tallocator","Message-ID":"<20241220150759.709756-10-pobrn@protonmail.com>","In-Reply-To":"<20241220150759.709756-1-pobrn@protonmail.com>","References":"<20241220150759.709756-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"7d51ce620a41cac21baa4869851f4faf520fd0e6","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do a consistency check to ensure that the return value\nmatches the number of buffers actually created.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/lc-compliance/helpers/capture.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex b473e0773..5cc7635f7 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -49,6 +49,7 @@ void Capture::start()\n \n \tASSERT_GE(count, 0) << \"Failed to allocate buffers\";\n \tEXPECT_EQ(count, config_->at(0).bufferCount) << \"Allocated less buffers than expected\";\n+\tASSERT_EQ(count, allocator_.buffers(stream).size()) << \"Unexpected number of buffers in allocator\";\n \n \tcamera_->requestCompleted.connect(this, &Capture::requestComplete);\n \n","prefixes":["RFC","v1","09/12"]}