[{"id":32949,"web_url":"https://patchwork.libcamera.org/comment/32949/","msgid":"<5q2neyjgx3g7xilk6tqixc5u4hxcf36urlo6tlt3spncmpw2to@34jv7ghguvz7>","date":"2025-01-07T16:50:26","subject":"Re: [RFC PATCH v1 07/12] apps: lc-compliance: Use array instead of\n\t`std::vector`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Fri, Dec 20, 2024 at 03:08:33PM +0000, Barnabás Pőcze wrote:\n> There is no reason to use `std::vector` for this static\n> data, a simple array will do fine.\n>\n> Signed-off-by: Barnabás Pőcze \n\nGTest provides overloads of ValuesIn for both raw arrays and\ncontainers. So this certainly doesn't hurt.\n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/apps/lc-compliance/tests/capture_test.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\n> index db196a949..97465a612 100644\n> --- a/src/apps/lc-compliance/tests/capture_test.cpp\n> +++ b/src/apps/lc-compliance/tests/capture_test.cpp\n> @@ -18,8 +18,9 @@ namespace {\n>\n> using namespace libcamera;\n>\n> -const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n> -const std::vector ROLES = {\n> +const int NUMREQUESTS[] = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n> +\n> +const StreamRole ROLES[] = {\n> \tStreamRole::Raw,\n> \tStreamRole::StillCapture,\n> \tStreamRole::VideoRecording,\n> --\n> 2.47.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DED80BD80A\n\tfor ;\n\tTue, 7 Jan 2025 16:50:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03378684E7;\n\tTue, 7 Jan 2025 17:50:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44C1A684D6\n\tfor ;\n\tTue, 7 Jan 2025 17:50:31 +0100 (CET)","from ideasonboard.com (mob-5-90-140-128.net.vodafone.it\n\t[5.90.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE853675;\n\tTue, 7 Jan 2025 17:49:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oeD3sC1g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736268579;\n\tbh=PB6kx2xmreNrac4iHSqhGUszZD55t2Dvk37F6xeEI+A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oeD3sC1gsCElDjdAYWtbiUP+WxJbnqT7pQR+5TqR93DKw2Bo2OxfpsckZ8xJp8ixv\n\tT/cMfK8Aq+e14oiTj9PgEfom5sDG5Ys0OnnjDlBi+QXkWaq8Ay1O9raQU0sTvaP+Ip\n\tXMd8of/eoljmzd2JxSZDeFtA5Wc/xGoc8oR/1tT8=","Date":"Tue, 7 Jan 2025 17:50:26 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 07/12] apps: lc-compliance: Use array instead of\n\t`std::vector`","Message-ID":"<5q2neyjgx3g7xilk6tqixc5u4hxcf36urlo6tlt3spncmpw2to@34jv7ghguvz7>","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-8-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-8-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32998,"web_url":"https://patchwork.libcamera.org/comment/32998/","msgid":"","date":"2025-01-09T22:17:42","subject":"Re: [RFC PATCH v1 07/12] apps: lc-compliance: Use array instead of\n\t`std::vector`","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 03:08:33PM +0000, Barnabás Pőcze wrote:\n> There is no reason to use `std::vector` for this static\n> data, a simple array will do fine.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/lc-compliance/tests/capture_test.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\n> index db196a949..97465a612 100644\n> --- a/src/apps/lc-compliance/tests/capture_test.cpp\n> +++ b/src/apps/lc-compliance/tests/capture_test.cpp\n> @@ -18,8 +18,9 @@ namespace {\n> \n> using namespace libcamera;\n> \n> -const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n> -const std::vector ROLES = {\n> +const int NUMREQUESTS[] = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n> +\n> +const StreamRole ROLES[] = {\n> \tStreamRole::Raw,\n> \tStreamRole::StillCapture,\n> \tStreamRole::VideoRecording,\n> -- \n> 2.47.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3B80C32EA\n\tfor ;\n\tThu, 9 Jan 2025 22:17:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2C6368516;\n\tThu, 9 Jan 2025 23:17:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5740961884\n\tfor ;\n\tThu, 9 Jan 2025 23:17:48 +0100 (CET)","from pyrite.rasen.tech (h175-177-049-030.catv02.itscom.jp\n\t[175.177.49.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A63C4C62;\n\tThu, 9 Jan 2025 23:16:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sxRKeOw6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736461014;\n\tbh=P3M65ZIMArAjKeOuzAipNqclW3iQDn4hOJvY5DkpqKk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sxRKeOw6hXYVoOfsLbntdmhkpqFJY7eIfsEibxJDTDcba9Fc2xO+ZWvCGJnedZzJf\n\tcmmfKmlsa8+Itz9NDfnbqH4R1HQCDtUYuXdigj38tnRnThM9DzZ5v7mCYfxpnUWnSR\n\txfvtKay1UvozTbnYwn1u0Gws/xElP6eOpCsCKyUk=","Date":"Fri, 10 Jan 2025 07:17:42 +0900","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 07/12] apps: lc-compliance: Use array instead of\n\t`std::vector`","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-8-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-8-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]