[{"id":32946,"web_url":"https://patchwork.libcamera.org/comment/32946/","msgid":"","date":"2025-01-07T16:31:00","subject":"Re: [RFC PATCH v1 04/12] apps: lc-compliance: Remove redundant\n\tgetter call","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Fri, Dec 20, 2024 at 03:08:20PM +0000, Barnabás Pőcze wrote:\n> Smart pointers overload `operator->()`, no reason to use `get()`.\n>\n> Signed-off-by: Barnabás Pőcze \n\nindeed\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/lc-compliance/main.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp\n> index 98f2573d0..cdd0bd515 100644\n> --- a/src/apps/lc-compliance/main.cpp\n> +++ b/src/apps/lc-compliance/main.cpp\n> @@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener\n> static void listCameras(CameraManager *cm)\n> {\n> \tfor (const std::shared_ptr &cam : cm->cameras())\n> -\t\tstd::cout << \"- \" << cam.get()->id() << std::endl;\n> +\t\tstd::cout << \"- \" << cam->id() << std::endl;\n> }\n>\n> static int initCamera(CameraManager *cm, OptionsParser::Options options)\n> --\n> 2.47.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32FABBD80A\n\tfor ;\n\tTue, 7 Jan 2025 16:31:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7FC4684DF;\n\tTue, 7 Jan 2025 17:31:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4989684CD\n\tfor ;\n\tTue, 7 Jan 2025 17:31:04 +0100 (CET)","from ideasonboard.com (mob-5-90-140-128.net.vodafone.it\n\t[5.90.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58BF8675;\n\tTue, 7 Jan 2025 17:30:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DhqwU71i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736267412;\n\tbh=8vNSjSxhb//ejQl2JG+nQpMwQ1Q1lW/PxjI5u/x8lBg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DhqwU71iuW0peLl4mF2U8Qdt+wp8tW67vkv0mkqP9Wn8cS/eAYEcoHDlblKH6f+fW\n\toM3c31uoPRQPGYTDH5B0zfLcla1wUPQOw7VBSGTJRnR1GdjemnlSvyKXHWyIiLBFSQ\n\tzYziyYryMYmWDdfXg2DN5O50C/YjJgYiaKtn8ssI=","Date":"Tue, 7 Jan 2025 17:31:00 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 04/12] apps: lc-compliance: Remove redundant\n\tgetter call","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-5-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-5-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32995,"web_url":"https://patchwork.libcamera.org/comment/32995/","msgid":"","date":"2025-01-09T22:16:06","subject":"Re: [RFC PATCH v1 04/12] apps: lc-compliance: Remove redundant\n\tgetter call","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 03:08:20PM +0000, Barnabás Pőcze wrote:\n> Smart pointers overload `operator->()`, no reason to use `get()`.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/lc-compliance/main.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp\n> index 98f2573d0..cdd0bd515 100644\n> --- a/src/apps/lc-compliance/main.cpp\n> +++ b/src/apps/lc-compliance/main.cpp\n> @@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener\n> static void listCameras(CameraManager *cm)\n> {\n> \tfor (const std::shared_ptr &cam : cm->cameras())\n> -\t\tstd::cout << \"- \" << cam.get()->id() << std::endl;\n> +\t\tstd::cout << \"- \" << cam->id() << std::endl;\n> }\n> \n> static int initCamera(CameraManager *cm, OptionsParser::Options options)\n> -- \n> 2.47.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46EDFC32EA\n\tfor ;\n\tThu, 9 Jan 2025 22:16:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF65D68506;\n\tThu, 9 Jan 2025 23:16:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0B4E684E0\n\tfor ;\n\tThu, 9 Jan 2025 23:16:12 +0100 (CET)","from pyrite.rasen.tech (h175-177-049-030.catv02.itscom.jp\n\t[175.177.49.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 478C4C62;\n\tThu, 9 Jan 2025 23:15:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YS356cWV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736460919;\n\tbh=CypG/KF0SFQc1q1++REIK+btnc20ctnzhJDDF/eVHJ0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YS356cWVwiRZdsjJ+Yp878E1QAj/wYp9P+TBLkJSmMkcugyCQrwtdjDzv3cW92jIW\n\tQxxZ05K1oKNL+dSymGnbzGfWIEUtAgbGoIK6pghdmpFMJgmb8ZUPVh0CNlhCZxILTR\n\tTO9ydxKPZu4rOfZLEKr8DtzGLVBT+qwLZmDBhk1k=","Date":"Fri, 10 Jan 2025 07:16:06 +0900","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 04/12] apps: lc-compliance: Remove redundant\n\tgetter call","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-5-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-5-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]