[{"id":32944,"web_url":"https://patchwork.libcamera.org/comment/32944/","msgid":"","date":"2025-01-07T16:29:12","subject":"Re: [RFC PATCH v1 02/12] apps: lc-compliance: Put tests into\n\tanonymous namespace","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Fri, Dec 20, 2024 at 03:08:12PM +0000, Barnabás Pőcze wrote:\n> There is no reason for these symbols to be global.\n>\n> Signed-off-by: Barnabás Pőcze \n\nLikewise\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\n> index ad3a1da2f..db196a949 100644\n> --- a/src/apps/lc-compliance/tests/capture_test.cpp\n> +++ b/src/apps/lc-compliance/tests/capture_test.cpp\n> @@ -14,6 +14,8 @@\n>\n> #include \"environment.h\"\n>\n> +namespace {\n> +\n> using namespace libcamera;\n>\n> const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n> @@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests,\n> \t\t\t testing::Combine(testing::ValuesIn(ROLES),\n> \t\t\t\t\t testing::ValuesIn(NUMREQUESTS)),\n> \t\t\t SingleStream::nameParameters);\n> +\n> +} /* namespace */\n> --\n> 2.47.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD534C32DC\n\tfor ;\n\tTue, 7 Jan 2025 16:29:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61345684E4;\n\tTue, 7 Jan 2025 17:29:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16716684CD\n\tfor ;\n\tTue, 7 Jan 2025 17:29:16 +0100 (CET)","from ideasonboard.com (mob-5-90-140-128.net.vodafone.it\n\t[5.90.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3837675;\n\tTue, 7 Jan 2025 17:28:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tVgSgPEz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736267303;\n\tbh=hSNnGK4GCrHIogKqwbE/cHQX1g84TpiTZ+Hc1LgfNKw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tVgSgPEzcibnLCf+KUgbON8kmrVOyfjMORl1qhT0YHrOJqvIS/InmPLwWEC7siI+v\n\tVmbjLVSozicmUgkbXCleKwdFd2yEu5qGPfy1GaElpYIwTmPR/iEG20E1ElHu3AYbmh\n\tVtKpexHhDpHjYTCZxfGgnEdeA+fZn9jrFx1joGBc=","Date":"Tue, 7 Jan 2025 17:29:12 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 02/12] apps: lc-compliance: Put tests into\n\tanonymous namespace","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-3-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-3-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32994,"web_url":"https://patchwork.libcamera.org/comment/32994/","msgid":"","date":"2025-01-09T22:15:39","subject":"Re: [RFC PATCH v1 02/12] apps: lc-compliance: Put tests into\n\tanonymous namespace","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 03:08:12PM +0000, Barnabás Pőcze wrote:\n> There is no reason for these symbols to be global.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\n> index ad3a1da2f..db196a949 100644\n> --- a/src/apps/lc-compliance/tests/capture_test.cpp\n> +++ b/src/apps/lc-compliance/tests/capture_test.cpp\n> @@ -14,6 +14,8 @@\n> \n> #include \"environment.h\"\n> \n> +namespace {\n> +\n> using namespace libcamera;\n> \n> const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n> @@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests,\n> \t\t\t testing::Combine(testing::ValuesIn(ROLES),\n> \t\t\t\t\t testing::ValuesIn(NUMREQUESTS)),\n> \t\t\t SingleStream::nameParameters);\n> +\n> +} /* namespace */\n> -- \n> 2.47.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F919C32EA\n\tfor ;\n\tThu, 9 Jan 2025 22:15:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5471A684EA;\n\tThu, 9 Jan 2025 23:15:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52D0D61880\n\tfor ;\n\tThu, 9 Jan 2025 23:15:46 +0100 (CET)","from pyrite.rasen.tech (h175-177-049-030.catv02.itscom.jp\n\t[175.177.49.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2C84C62;\n\tThu, 9 Jan 2025 23:14:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XdOs//mw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736460892;\n\tbh=B9HkJqFnN7hVzobinG0yPFfTFv82oEN53eJW6fIzuZk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XdOs//mwvbWO0vAyHfHORJ/nIsw+GIk8gKTs4BBEf4LDBzgWtyqiyUTAyRufeJqmD\n\tSQ691ItIM2ozZYQdwJYDSHLma7vJaJGga79sgqdED6S0MxIlfCWkqo0R+EYBXBxUar\n\tRCu7tke1FzJirpxnmVnnobB2M3qiaN5TJPrtKELw=","Date":"Fri, 10 Jan 2025 07:15:39 +0900","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 02/12] apps: lc-compliance: Put tests into\n\tanonymous namespace","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-3-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-3-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]