{"id":22428,"url":"https://patchwork.libcamera.org/api/patches/22428/?format=json","web_url":"https://patchwork.libcamera.org/patch/22428/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241220150759.709756-3-pobrn@protonmail.com>","date":"2024-12-20T15:08:12","name":"[RFC,v1,02/12] apps: lc-compliance: Put tests into anonymous namespace","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4d9647de8cb417422e3beacc1d4edb64648b8948","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22428/mbox/","series":[{"id":4923,"url":"https://patchwork.libcamera.org/api/series/4923/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4923","date":"2024-12-20T15:08:03","name":"apps: lc-compliance: Multi-stream tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4923/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22428/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22428/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9972FC32A3\n\tfor ;\n\tFri, 20 Dec 2024 15:08:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7E796849F;\n\tFri, 20 Dec 2024 16:08:20 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 486E36848B\n\tfor ;\n\tFri, 20 Dec 2024 16:08:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"OtkMhzlC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734707296; x=1734966496;\n\tbh=TEMqMhwBjwgv1GXGoLDXfpOM5BvQk1Ljn2pIyE6G96c=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=OtkMhzlCgJwTmd8jRxVrlI+CWTkwa2m0vKYGdhcQ1BNQ210u4hasa5E3Efg6b27E4\n\trShCytd0AW0K+xvx6YVVFpSllM+du8aci/PdE4WfV73pDqAaVjxfcQ5r982Fd2RmZE\n\tUzTDan/2UV3EA7ZtscKLif+tvz4mi0cyBrHlvTb4YskxRuUcgRMUV2Zhjoo458TrCX\n\tiLqftJXHeP+xkdtaFZyV48SG7AzyoVUuqosuPDxjDPjzdBxkknxGPUj9PvsbD1sxj9\n\t3ApnyNQ4Iz4wkUzfk3GxLNxFwEXY+UxGmxRmkLT+cCx1BG2NcfbgAbNGCKP/aE54Kp\n\t7YDwXxam2Z0DQ==","Date":"Fri, 20 Dec 2024 15:08:12 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[RFC PATCH v1 02/12] apps: lc-compliance: Put tests into anonymous\n\tnamespace","Message-ID":"<20241220150759.709756-3-pobrn@protonmail.com>","In-Reply-To":"<20241220150759.709756-1-pobrn@protonmail.com>","References":"<20241220150759.709756-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"706dd424fabac6076807cf2bf3c39129d3faab2e","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason for these symbols to be global.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\nindex ad3a1da2f..db196a949 100644\n--- a/src/apps/lc-compliance/tests/capture_test.cpp\n+++ b/src/apps/lc-compliance/tests/capture_test.cpp\n@@ -14,6 +14,8 @@\n \n #include \"environment.h\"\n \n+namespace {\n+\n using namespace libcamera;\n \n const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n@@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests,\n \t\t\t testing::Combine(testing::ValuesIn(ROLES),\n \t\t\t\t\t testing::ValuesIn(NUMREQUESTS)),\n \t\t\t SingleStream::nameParameters);\n+\n+} /* namespace */\n","prefixes":["RFC","v1","02/12"]}