[{"id":32943,"web_url":"https://patchwork.libcamera.org/comment/32943/","msgid":"","date":"2025-01-07T16:27:37","subject":"Re: [RFC PATCH v1 01/12] apps: lc-compliance: Initialize\n\t`CameraManager` pointer in `Environment`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabas,\n surely doesn't hurt\n\nReviewed-by: Jacopo Mondi \n\nOn Fri, Dec 20, 2024 at 03:08:08PM +0000, Barnabás Pőcze wrote:\n> Do not leave it unitialized.\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/apps/lc-compliance/environment.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h\n> index 543e5372f..834c722ef 100644\n> --- a/src/apps/lc-compliance/environment.h\n> +++ b/src/apps/lc-compliance/environment.h\n> @@ -23,5 +23,5 @@ private:\n> \tEnvironment() = default;\n>\n> \tstd::string cameraId_;\n> -\tlibcamera::CameraManager *cm_;\n> +\tlibcamera::CameraManager *cm_ = nullptr;\n> };\n> --\n> 2.47.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 455ABC32DC\n\tfor ;\n\tTue, 7 Jan 2025 16:27:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7635D684CD;\n\tTue, 7 Jan 2025 17:27:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC34F684CD\n\tfor ;\n\tTue, 7 Jan 2025 17:27:40 +0100 (CET)","from ideasonboard.com (mob-5-90-140-128.net.vodafone.it\n\t[5.90.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 448D7675;\n\tTue, 7 Jan 2025 17:26:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ooBaoTVs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736267208;\n\tbh=H+vPwk3ZK10yphiLgTYgMDjcvnsqgzbMhwwEY4BKkyQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ooBaoTVsK5LkqJKvP+tyhklszRCGFg2T8/u2HoVDeaVork1KypeuS1BCd90FnlWqV\n\tLxjrkvZKN7QMkjSuVI1/F1PQ31cnFalC03XjtT9lR2HEkyrtw9bSgO/dnPOhTTfSXS\n\txAZKRktf65zuGYQXj1MZgekgKSxOdMuOZZR23vzo=","Date":"Tue, 7 Jan 2025 17:27:37 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 01/12] apps: lc-compliance: Initialize\n\t`CameraManager` pointer in `Environment`","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-2-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-2-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32993,"web_url":"https://patchwork.libcamera.org/comment/32993/","msgid":"","date":"2025-01-09T22:15:11","subject":"Re: [RFC PATCH v1 01/12] apps: lc-compliance: Initialize\n\t`CameraManager` pointer in `Environment`","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 20, 2024 at 03:08:08PM +0000, Barnabás Pőcze wrote:\n> Do not leave it unitialized.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/lc-compliance/environment.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h\n> index 543e5372f..834c722ef 100644\n> --- a/src/apps/lc-compliance/environment.h\n> +++ b/src/apps/lc-compliance/environment.h\n> @@ -23,5 +23,5 @@ private:\n> \tEnvironment() = default;\n> \n> \tstd::string cameraId_;\n> -\tlibcamera::CameraManager *cm_;\n> +\tlibcamera::CameraManager *cm_ = nullptr;\n> };\n> -- \n> 2.47.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81718C32EA\n\tfor ;\n\tThu, 9 Jan 2025 22:15:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D246B684EA;\n\tThu, 9 Jan 2025 23:15:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9297761880\n\tfor ;\n\tThu, 9 Jan 2025 23:15:19 +0100 (CET)","from pyrite.rasen.tech (h175-177-049-030.catv02.itscom.jp\n\t[175.177.49.30])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D9A1C62;\n\tThu, 9 Jan 2025 23:14:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RpExsV3g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736460865;\n\tbh=G2NhNyvukYy9Nq4BElUvOpcU5a05PStVFMzLDwmFWOI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RpExsV3gB38Ot2o3oPoQQEEENIMxfNX0F+vupkRK8wgti2RvOqJFxdzO9+3Qyful5\n\tyRNBqBm2doVot7L7Nn0HLbUiP2PCE30DCLuY7XSKKJ/hQbctBFx1PCsO7lrluPvyfm\n\topekUhiLtHoGSvycMg7+rK2oe54PfhcEzECs7P7o=","Date":"Fri, 10 Jan 2025 07:15:11 +0900","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 01/12] apps: lc-compliance: Initialize\n\t`CameraManager` pointer in `Environment`","Message-ID":"","References":"<20241220150759.709756-1-pobrn@protonmail.com>\n\t<20241220150759.709756-2-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241220150759.709756-2-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]