{"id":22427,"url":"https://patchwork.libcamera.org/api/patches/22427/?format=json","web_url":"https://patchwork.libcamera.org/patch/22427/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241220150759.709756-2-pobrn@protonmail.com>","date":"2024-12-20T15:08:08","name":"[RFC,v1,01/12] apps: lc-compliance: Initialize `CameraManager` pointer in `Environment`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d249066b0c87b722871e3bcc3a3b0dcf89afc54b","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22427/mbox/","series":[{"id":4923,"url":"https://patchwork.libcamera.org/api/series/4923/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4923","date":"2024-12-20T15:08:03","name":"apps: lc-compliance: Multi-stream tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4923/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22427/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22427/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8F5EC32A3\n\tfor ;\n\tFri, 20 Dec 2024 15:08:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67F64684A0;\n\tFri, 20 Dec 2024 16:08:16 +0100 (CET)","from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14A3A6849E\n\tfor ;\n\tFri, 20 Dec 2024 16:08:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"MLoo/+/B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734707291; x=1734966491;\n\tbh=jZy8XuWNRqLwwW3t3QvEKlj3uyBz5Bvo2lxFkZ+OqRA=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=MLoo/+/BGheQsn4ebnDC5kHX6ZveSmWZbprF42D8oxeaWge+4goug/ffg9lZW0U+V\n\tbHS3f04U2Lrs19aPkQ6kUbLLZt5LVxlpJrjGEE+osXUNG3sZ3ePjOMaxHoCC1WtliB\n\tOX/esV++xG1ceO8zvWbHgh8v4YtVSOcBMdfJVEoa693UJMlqoBg1aFQU2VDMsSmWrP\n\tX5yvbKaqb44GYFkzHDUV4eH07dVCrR9Iw8uvLQ/ORmj1D6ms0jg9Ln5vJOEuWLcVak\n\t5JMMeSYVQ9cqtCI6gH7k6/Kt8C9pJqpzoU493toy6oXjJwuBMJn6maC1bYsvABzXWQ\n\t9NuvJn2enmksg==","Date":"Fri, 20 Dec 2024 15:08:08 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[RFC PATCH v1 01/12] apps: lc-compliance: Initialize `CameraManager`\n\tpointer in `Environment`","Message-ID":"<20241220150759.709756-2-pobrn@protonmail.com>","In-Reply-To":"<20241220150759.709756-1-pobrn@protonmail.com>","References":"<20241220150759.709756-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"d35015acd4474a8ed00a445135960d9c883d29c7","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do not leave it unitialized.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/lc-compliance/environment.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h\nindex 543e5372f..834c722ef 100644\n--- a/src/apps/lc-compliance/environment.h\n+++ b/src/apps/lc-compliance/environment.h\n@@ -23,5 +23,5 @@ private:\n \tEnvironment() = default;\n \n \tstd::string cameraId_;\n-\tlibcamera::CameraManager *cm_;\n+\tlibcamera::CameraManager *cm_ = nullptr;\n };\n","prefixes":["RFC","v1","01/12"]}