{"id":22422,"url":"https://patchwork.libcamera.org/api/patches/22422/?format=json","web_url":"https://patchwork.libcamera.org/patch/22422/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241219211010.103310-5-mzamazal@redhat.com>","date":"2024-12-19T21:10:09","name":"[v2,4/5] ipa: simple: Report black levels in metadata","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"78bb67b4b1c87c63be2cf99bf5cb1205f622adbf","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22422/mbox/","series":[{"id":4920,"url":"https://patchwork.libcamera.org/api/series/4920/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4920","date":"2024-12-19T21:10:05","name":"ipa: simple: Introduce metadata reporting","version":2,"mbox":"https://patchwork.libcamera.org/series/4920/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22422/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22422/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 238D2C330A\n\tfor ;\n\tThu, 19 Dec 2024 21:10:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1D4B6848B;\n\tThu, 19 Dec 2024 22:10:40 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7277268480\n\tfor ;\n\tThu, 19 Dec 2024 22:10:36 +0100 (CET)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-34-Mncjq_R9Ngq4p7cPtU7ovA-1;\n\tThu, 19 Dec 2024 16:10:32 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 5CDCB19560BC; Thu, 19 Dec 2024 21:10:31 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.37])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 9D1E5300F9B5; Thu, 19 Dec 2024 21:10:29 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ZFO9tsMF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1734642635;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tNwTlbdunWD81spcI8ViHFWeu26EmXM8el1o5/75Now=;\n\tb=ZFO9tsMFhP4PpmX1xy876e0HwStgipXJydateit7hCQ8t20BR8EZ3BksraCnrjJxd3nTZ5\n\t+hU5Ijfjowp5YZ3qSs9qynlEpwOFtVNjASXqD/1o0n/gRzIsd72iofXVCdboyya+0N8J+k\n\tXtddwifMp3RJ6fA6ZJUGAMkKHI+qJu0=","X-MC-Unique":"Mncjq_R9Ngq4p7cPtU7ovA-1","X-Mimecast-MFC-AGG-ID":"Mncjq_R9Ngq4p7cPtU7ovA","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ,\n\tMilan Zamazal ","Subject":"[PATCH v2 4/5] ipa: simple: Report black levels in metadata","Date":"Thu, 19 Dec 2024 22:10:09 +0100","Message-ID":"<20241219211010.103310-5-mzamazal@redhat.com>","In-Reply-To":"<20241219211010.103310-1-mzamazal@redhat.com>","References":"<20241219211010.103310-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"P7iTrLL_8GtAkzpfdPhYblnQSyoPvagDtII3AxirQN4_1734642631","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nProvide the determined black level values in the metadata\nto add to the completed requests.\n\nSigned-off-by: Kieran Bingham \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/blc.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 1d7d370b..d5759f92 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -11,6 +11,8 @@\n \n #include \n \n+#include \"control_ids.h\"\n+\n namespace libcamera {\n \n namespace ipa::soft::algorithms {\n@@ -49,8 +51,13 @@ void BlackLevel::process(IPAContext &context,\n \t\t\t [[maybe_unused]] const uint32_t frame,\n \t\t\t IPAFrameContext &frameContext,\n \t\t\t const SwIspStats *stats,\n-\t\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t\t ControlList &metadata)\n {\n+\t/* Assign each of the R G G B channels as the same black level. */\n+\tconst int32_t blackLevel = context.activeState.blc.level * 256;\n+\tconst int32_t blackLevels[] = { blackLevel, blackLevel, blackLevel, blackLevel };\n+\tmetadata.set(controls::SensorBlackLevels, blackLevels);\n+\n \tif (context.configuration.black.level.has_value())\n \t\treturn;\n \n","prefixes":["v2","4/5"]}