{"id":22414,"url":"https://patchwork.libcamera.org/api/patches/22414/?format=json","web_url":"https://patchwork.libcamera.org/patch/22414/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241219175729.293782-7-stefan.klug@ideasonboard.com>","date":"2024-12-19T17:57:23","name":"[v6,6/9] libtuning: Fix access to color member in ctt_awb.awb()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b9d65832b9696229a9e28b69a2377ba739494cce","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22414/mbox/","series":[{"id":4919,"url":"https://patchwork.libcamera.org/api/series/4919/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4919","date":"2024-12-19T17:57:17","name":"rkisp1: Add manual colour temperature control","version":6,"mbox":"https://patchwork.libcamera.org/series/4919/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22414/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22414/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2202CC3309\n\tfor ;\n\tThu, 19 Dec 2024 17:57:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D9CC6848C;\n\tThu, 19 Dec 2024 18:57:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB6076846F\n\tfor ;\n\tThu, 19 Dec 2024 18:57:49 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:783:85f9:c998:cb11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA7F36D6;\n\tThu, 19 Dec 2024 18:57:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WBBXzON8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734631031;\n\tbh=EnI4zDdJeJn5HH+Gq2nY3+8buAk7TKwwaH8oVRx13tQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WBBXzON8gv4W/Tsd+awNLzHD1XanpRfJ2INxSnMPDb5cP0turdm3HHyujudtCMO+l\n\t+HRalci4BNbdDBW8pM8hzCSeT+mY9Lsp6mTLaFQvtGG/zciqr4RIZnTTkDI1u2oGsK\n\tCL1o9L/ueqNtJALlSJLVo4fzH8qrwAQecPqrwjeM=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tPaul Elder ,\n\tLaurent Pinchart ","Subject":"[PATCH v6 6/9] libtuning: Fix access to color member in\n\tctt_awb.awb()","Date":"Thu, 19 Dec 2024 18:57:23 +0100","Message-ID":"<20241219175729.293782-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241219175729.293782-1-stefan.klug@ideasonboard.com>","References":"<20241219175729.293782-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The color temperature member of the image object was named \"col\" in the\npast. Now it is named \"color\" (which is still not very expressive).\nThere are still a few unspotted accesses to the col member. Fix them to\naccess the color member.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\n utils/tuning/libtuning/ctt_awb.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/tuning/libtuning/ctt_awb.py b/utils/tuning/libtuning/ctt_awb.py\nindex b996daba0213..240f37e644bb 100644\n--- a/utils/tuning/libtuning/ctt_awb.py\n+++ b/utils/tuning/libtuning/ctt_awb.py\n@@ -77,7 +77,7 @@ def awb(imgs, cal_cr_list, cal_cb_list, plot):\n r_g_hat = r_g/(1+r_g+b_g)\n b_g_hat = b_g/(1+r_g+b_g)\n logger.info(f' r_hat : {r_g_hat:.4f} b_hat : {b_g_hat:.4f}')\n- rbs_hat.append((r_g_hat, b_g_hat, Img.col))\n+ rbs_hat.append((r_g_hat, b_g_hat, Img.color))\n rb_raw.append((r_g, b_g))\n \n logger.info('Finished processing images')\n@@ -305,7 +305,7 @@ def get_alsc_patches(Img, colour_cals, grey=True):\n patches = Img.patches\n if grey:\n cen_coords = Img.cen_coords[3::4]\n- col = Img.col\n+ col = Img.color\n r_patchs = patches[0][3::4] - Img.blacklevel_16\n b_patchs = patches[3][3::4] - Img.blacklevel_16\n \"\"\"\n","prefixes":["v6","6/9"]}