{"id":22404,"url":"https://patchwork.libcamera.org/api/patches/22404/?format=json","web_url":"https://patchwork.libcamera.org/patch/22404/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241219005958.16856-1-kieran.bingham@ideasonboard.com>","date":"2024-12-19T00:59:58","name":"libcamera: camera_sensor_properties: ov5675: Set correct delays","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0d4ae9931bc50d0a3fb761163221583c104cd6a9","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22404/mbox/","series":[{"id":4915,"url":"https://patchwork.libcamera.org/api/series/4915/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4915","date":"2024-12-19T00:59:58","name":"libcamera: camera_sensor_properties: ov5675: Set correct delays","version":1,"mbox":"https://patchwork.libcamera.org/series/4915/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22404/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22404/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE747C32FE\n\tfor ;\n\tThu, 19 Dec 2024 01:00:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E76F96845C;\n\tThu, 19 Dec 2024 02:00:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 684F7680B3\n\tfor ;\n\tThu, 19 Dec 2024 02:00:03 +0100 (CET)","from charm.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5057A163;\n\tThu, 19 Dec 2024 01:59:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XXownAI/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734569964;\n\tbh=fcE6lHvqdPG0Wdlx7MLI2FypgzV0f7M1zn0luKSYwj0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XXownAI/ncQN+BK8XcZ/o3zPYyZf+YdgK8f5w20U5IAZdQnXTE/xtQbSjLGiqihC8\n\tNADx6oIg4QuP+XC7TDDvv1vMRxkjnJSWnS4pBjUsj88rOMqgh5Fon3lZgTptFLbJ4q\n\t9+dBKYX7Tialp05yWYkWKL137gw5VouzQNTdaOY8=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"bryan.odonoghue@linaro.org,\n\tKieran Bingham ","Subject":"[PATCH] libcamera: camera_sensor_properties: ov5675: Set correct\n\tdelays","Date":"Thu, 19 Dec 2024 00:59:58 +0000","Message-ID":"<20241219005958.16856-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.47.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The OV5675 uses different delays for gain and exposure than are configured\nin the default sensorDelays utilised by the CameraSensorLegacy.\n\nEmpirical testing using a Lenovo X13s shows that the exposure delay is\nonly a single frame, and the current setting of 2 frame delay produces\nexceedingly frequent oscillations in the image exposure.\n\nUpdate the OV5675 sensor delays table accordingly.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/sensor/camera_sensor_properties.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex bd1fc86977ce..813878386a35 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -360,7 +360,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n-\t\t\t.sensorDelays = { },\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 1,\n+\t\t\t\t.gainDelay = 1,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t },\n \t\t} },\n \t\t{ \"ov5693\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n","prefixes":[]}