[{"id":307,"web_url":"https://patchwork.libcamera.org/comment/307/","msgid":"<9987519.vLeXhDBjcN@avalon>","date":"2019-01-14T16:52:16","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix unknown log level\n\trepresentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Monday, 14 January 2019 12:02:56 EET Kieran Bingham wrote:\n> Commit 99a3e7bcfb38 (\"libcamera: log: Add a LogFatal log level\")\n> expanded the text representation of the log levels to support the FATAL\n> string, but left the default unknown match at four characters.\n> \n> This code should never expect to be executed, but for completeness match\n> the string lengths by adding an extra character to the result.\n> \n> Fixes: 99a3e7bcfb38 (\"libcamera: log: Add a LogFatal log level\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/log.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 281e31d963f5..9b2ae1bac8c8 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -77,7 +77,7 @@ static const char *log_severity_name(LogSeverity severity)\n> if (static_cast(severity) < ARRAY_SIZE(names))\n> \t\treturn names[severity];\n> \telse\n> -\t\treturn \"UNKN\";\n> +\t\treturn \"UNKWN\";\n> }\n> \n> /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 733AB60B21\n\tfor ;\n\tMon, 14 Jan 2019 17:51:02 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BEF6C530;\n\tMon, 14 Jan 2019 17:51:01 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547484661;\n\tbh=Z02USVO6KX/DauwGwu2Z95CkMsOqWdvU0HhMmK/9E1k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=C5mnsgJZwu7Emm2y+ll43e76oDrprpXJvAxGfaVeZ+TJqX8GdYbv8l/Qq9rsjJ+tO\n\tKc11yp6TUIWKJyCW4yCVsAa+p0wEAJk9xjpIjvmnwnbDrqbjqmoQ3tJB7KOxHSCjXw\n\tJksbImuAYbsipK3wJlOECthSK0y4waMAAt6q7FZs=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Jan 2019 18:52:16 +0200","Message-ID":"<9987519.vLeXhDBjcN@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190114100256.17777-1-kieran.bingham@ideasonboard.com>","References":"<20190114100256.17777-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix unknown log level\n\trepresentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 14 Jan 2019 16:51:02 -0000"}}]