[{"id":32880,"web_url":"https://patchwork.libcamera.org/comment/32880/","msgid":"<20241219015146.GO5518@pendragon.ideasonboard.com>","date":"2024-12-19T01:51:46","subject":"Re: [libcamera-ci] [PATCH v1] Eliminate duplicate keys in YAML","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Wed, Dec 18, 2024 at 01:45:55PM +0100, Barnabás Pőcze wrote:\n> The key `artifacts` occurs twice in the `test-unit` dictionary.\n> Gitlab accepts this, but as if only the second occurrence was\n> present, so the meson logs are not saved as artifacts. Merge\n> the two artifact specifications to fix this.\n> \n> Fixes: 075d5a5cd22ecd (\"Enable junit artifact generation for test-unit job\")\n> Signed-off-by: Barnabás Pőcze \n\nOops.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> gitlab-ci.yml | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index ec19f55..48c18d5 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -394,6 +394,8 @@ test-unit:\n> expire_in: 1 week\n> paths:\n> - build/meson-logs/\n> + reports:\n> + junit: build/meson-logs/testlog.junit.xml\n> variables:\n> BUILD_TYPE: debug\n> MESON_OPTIONS: >-\n> @@ -408,9 +410,6 @@ test-unit:\n> -D qcam=disabled\n> -D test=true\n> -D v4l2=true\n> - artifacts:\n> - reports:\n> - junit: build/meson-logs/testlog.junit.xml\n> \n> test-lc-compliance:virtual:\n> extends:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88FB4C3273\n\tfor ;\n\tThu, 19 Dec 2024 01:51:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FD036845E;\n\tThu, 19 Dec 2024 02:51:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5442A680B3\n\tfor ;\n\tThu, 19 Dec 2024 02:51:51 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADE15415;\n\tThu, 19 Dec 2024 02:51:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sV8loOjz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734573072;\n\tbh=5mhiOJDmVUeJSH+87KFmOhpJJ1A+YMQNSHyjJpTAszc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sV8loOjzDTCGndCzThvekLD5ppfV3zCf2ST4OTxBf9mfO1tWhDn3A/hwmcoabXV7t\n\tTV3VNTA5Ao9K79Orkx/ds+Lw1FKoXP8mulvGLYIQ615AVhu6qziLKqXytYlh01aajD\n\t6Vq5/X6WSmCpgbC7tjn99l5SVTTZmPLevrn0R1Mo=","Date":"Thu, 19 Dec 2024 03:51:46 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-ci] [PATCH v1] Eliminate duplicate keys in YAML","Message-ID":"<20241219015146.GO5518@pendragon.ideasonboard.com>","References":"<20241218124555.330740-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241218124555.330740-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]