{"id":22394,"url":"https://patchwork.libcamera.org/api/patches/22394/?format=json","web_url":"https://patchwork.libcamera.org/patch/22394/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241218083610.2397879-4-naush@raspberrypi.com>","date":"2024-12-18T08:34:20","name":"[v2,3/4] ipa: rpi: Add a HW property to determine if the data buffer is strided","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"08f12b6493b14c9a3abb07784cc7ff08d7434d92","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22394/mbox/","series":[{"id":4910,"url":"https://patchwork.libcamera.org/api/series/4910/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4910","date":"2024-12-18T08:34:17","name":"Raspberry Pi: Various changes","version":2,"mbox":"https://patchwork.libcamera.org/series/4910/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22394/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22394/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0900C3305\n\tfor ;\n\tWed, 18 Dec 2024 08:36:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 838A668083;\n\tWed, 18 Dec 2024 09:36:25 +0100 (CET)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D82E68083\n\tfor ;\n\tWed, 18 Dec 2024 09:36:19 +0100 (CET)","by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-385db79aafbso549517f8f.1\n\tfor ;\n\tWed, 18 Dec 2024 00:36:19 -0800 (PST)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-388c804a2f9sm13585781f8f.77.2024.12.18.00.36.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 18 Dec 2024 00:36:17 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"OHA82nAd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1734510978; x=1735115778;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=;\n\tb=OHA82nAdfXrytQjZafDmt57XhZEgMq70KPs4pJsv722OxO5Z91xEE4d+BA5yY0DAUj\n\tIyAzstd7dYOtogQDLaOf45mC1ao5K/6Qwp4LwhgJaoSFn4WGUbqINIa7EzRsimPYtTLh\n\tiSLMfHMPFozsmXqB7A0auLb3GjlSqkjYSifaG7pbB6eyV+mx4HJC6BC8zGancoUvkbbf\n\tFkpM7FQm4lJkzYBFW07CzcUMGywMWJdX+FMn4E+7ra+b9Rh8g1N6GFtg2u3sLwdTRtLH\n\t094rbJuOOyir207cJC0SVRRYSaE0fy21foQl+Zrc8OPUQLg0QPtcaGP/wQm3NC09+FYD\n\tul+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1734510978; x=1735115778;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=;\n\tb=CDlguyUJ1rlopvhX/hbbSccOMPIVaKCxkq9G2FJSAHFjOJY3CKePUXlwZYknDqCp2X\n\tqiH3yMA/BlFrGQEEf2B4VQ0rhQ62Ja17oLLr166U/AE6th7VSsiFR59bAqljxafqlFs8\n\tOvPwUeNfEDz+eGpTrT9uf0rOQe+LqJfIRgY94EHcqqkqY/XUyOIEjHX9770XkqmUikWW\n\tcGdgCKovhr/F/P8G+uONG7++FrRA08b9F4jhLKMuNyitLaSCBrZnxJq0xwEDeYKq5c7l\n\tqEA1/Hi90VJBGAOvlcbsbV5JTuNUxrXANMzpWww1nnQzU7iQTBUq/WVYQLFlHtcwpE8Q\n\t4fjA==","X-Gm-Message-State":"AOJu0YzIKqvyEvZ26gKqNbIMOseGs9u3gk2MLg5T9WD0MzZUCEEavjCf\n\tEDSBs9Kbd31v8uDSwjyxmQsGepoqJ2REJ1jn4GlKBLeeoJb/1TxlDHCdMiOUE51S3ArKhOqKOID\n\ty","X-Gm-Gg":"ASbGncteqHTI8G1T3e8CHljVMjnqkM9UXK6ft+1wNd0Ksm93bXSdhG9Xsmox/pxOTAb\n\tJAFpNEqFp9PDYvpRFcEDoJ/gY43teCWxLyjVftFHYg1Kzz9O7OaNeaPZwY1gJ8v02DeBouWJn2W\n\tZ4Vfnu3TNBxydHQg6HPScWVIt6dr5EWAHKm53FzrP45mOFjWhnKEdkuMJtSIN+4bdwd+kYklFQ1\n\tc4w/0jSu0MMr2oaGl+yC9ATnzt8fl7SIzJj1qYWtWoDuLUSUEr5HiTKaEJ0XUV9CF50CDbLmVq/","X-Google-Smtp-Source":"AGHT+IHPnOq2KonQgYZnb4Z9LbsnRplXfPysJ6Y85Eu8aXQD8gtp0u6s8lYtSXAQThR2mFqqGeGoDA==","X-Received":"by 2002:a05:6000:18a3:b0:374:ca43:ac00 with SMTP id\n\tffacd0b85a97d-388e4d4b5f3mr599613f8f.4.1734510978372; \n\tWed, 18 Dec 2024 00:36:18 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tDavid Plowman ,\n\tLaurent Pinchart ","Subject":"[PATCH v2 3/4] ipa: rpi: Add a HW property to determine if the data\n\tbuffer is strided","Date":"Wed, 18 Dec 2024 08:34:20 +0000","Message-ID":"<20241218083610.2397879-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241218083610.2397879-1-naush@raspberrypi.com>","References":"<20241218083610.2397879-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This property (dataBufferStrided) indicates if the CSI-2 hardware writes\nto the embedded/metadata buffer directly, or if it treats the buffer\nlike an image buffer and strides the metadata lines.\n\nUnicam writes this buffer strided, while the PiSP Frontend writes to it\ndirectly. This information will be relevant to data parsers in the\nhelpers where the data is structured in lines.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/ipa/rpi/controller/controller.cpp | 2 ++\n src/ipa/rpi/controller/controller.h | 1 +\n 2 files changed, 3 insertions(+)","diff":"diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\nindex e0131018e7b2..651fff632400 100644\n--- a/src/ipa/rpi/controller/controller.cpp\n+++ b/src/ipa/rpi/controller/controller.cpp\n@@ -39,6 +39,7 @@ static const std::map HardwareConfigMap\n \t\t\t.pipelineWidth = 13,\n \t\t\t.statsInline = false,\n \t\t\t.minPixelProcessingTime = 0s,\n+\t\t\t.dataBufferStrided = true,\n \t\t}\n \t},\n \t{\n@@ -71,6 +72,7 @@ static const std::map HardwareConfigMap\n \t\t\t * frames wider than ~16,000 pixels.\n \t\t\t */\n \t\t\t.minPixelProcessingTime = 1.0us / 380,\n+\t\t\t.dataBufferStrided = false,\n \t\t}\n \t},\n };\ndiff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h\nindex eff520bd61de..fdb46557de9c 100644\n--- a/src/ipa/rpi/controller/controller.h\n+++ b/src/ipa/rpi/controller/controller.h\n@@ -49,6 +49,7 @@ public:\n \t\tunsigned int pipelineWidth;\n \t\tbool statsInline;\n \t\tlibcamera::utils::Duration minPixelProcessingTime;\n+\t\tbool dataBufferStrided;\n \t};\n \n \tController();\n","prefixes":["v2","3/4"]}