[{"id":32791,"web_url":"https://patchwork.libcamera.org/comment/32791/","msgid":"<20241216232342.GA19635@pendragon.ideasonboard.com>","date":"2024-12-16T23:23:42","subject":"Re: [libcamera-ci] [RFC PATCH v2 2/4] Add `libevent` runtime\n\tlibraries to the container","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Dec 16, 2024 at 06:28:25PM +0100, Barnabás Pőcze wrote:\n> `libevent` is needed for some components, specifically `cam`\n> and `lc-compliance`. Installing `libevent-dev` would be more\n> convenient, but it is not doable at the moment because that\n> package is not multiarch compatible. So only install the\n> necessary runtime libraries.\n> \n> Build jobs already install `libevent-dev` when necessary before\n> building libcamera, but this change enables the aforementioned\n> components to be usable in different jobs as well.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .gitlab-ci/setup-container.sh | 3 +++\n> gitlab-ci.yml | 2 +-\n> 2 files changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh\n> index d2909c7..0658368 100755\n> --- a/.gitlab-ci/setup-container.sh\n> +++ b/.gitlab-ci/setup-container.sh\n> @@ -103,6 +103,9 @@ case $FDO_DISTRIBUTION_VERSION in\n> 'bookworm')\n> \t# libclang-rt-dev for the clang ASan runtime.\n> \tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libclang-rt-dev )\n> +\t# For cam and lc-compliance\n> +\t# libevent-dev cannot be used here, see build-libcamera-common.sh\n> +\tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libevent-2.1-7 libevent-pthreads-2.1-7 )\n> \t;;\n> 'trixie')\n> \t# gcc 13 to expand compilation testing coverage.\n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index 6d26680..f679d6e 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -65,7 +65,7 @@ include:\n> .libcamera-ci.debian:12:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> - FDO_DISTRIBUTION_TAG: '2024-12-12.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-16.1'\n> \n> .libcamera-ci.debian:13:\n> variables:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52CF8C326C\n\tfor ;\n\tMon, 16 Dec 2024 23:24:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64E1D67FB1;\n\tTue, 17 Dec 2024 00:24:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BBBB67F1B\n\tfor ;\n\tTue, 17 Dec 2024 00:23:59 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A11A514;\n\tTue, 17 Dec 2024 00:23:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rBhi/iC7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734391402;\n\tbh=Itg2FpV3DxtisN7g4shu6RWZRXcrAhbepXRfla1A+XQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rBhi/iC7xMmpf9WHKqPs2AhNbWMfeyTm3Ggl3sEpz65walsh25ghXL8+vNQ9Oeml9\n\t0cyRKS7baNRf599vVEmUtLZg9oPdqkqVWkPpht+LiKuLjFFo9lKolpPRejtrn+mQrv\n\tXIlbZeo30743hlgSNec5evNIbtxvlLfdEZlLzS0o=","Date":"Tue, 17 Dec 2024 01:23:42 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-ci] [RFC PATCH v2 2/4] Add `libevent` runtime\n\tlibraries to the container","Message-ID":"<20241216232342.GA19635@pendragon.ideasonboard.com>","References":"<20241216172827.1055088-1-barnabas.pocze@ideasonboard.com>\n\t<20241216172827.1055088-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241216172827.1055088-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]