{"id":22363,"url":"https://patchwork.libcamera.org/api/patches/22363/?format=json","web_url":"https://patchwork.libcamera.org/patch/22363/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241216154124.203650-18-stefan.klug@ideasonboard.com>","date":"2024-12-16T15:40:57","name":"[v4,17/20] pipeline: rkisp1: make RkISP1CameraConfiguration a friend of the pipeline handler","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b4442c02ed86ef47d31dbbc5d8d4a4371436759d","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22363/mbox/","series":[{"id":4896,"url":"https://patchwork.libcamera.org/api/series/4896/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4896","date":"2024-12-16T15:40:40","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":4,"mbox":"https://patchwork.libcamera.org/series/4896/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22363/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22363/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFAF2C32F6\n\tfor ;\n\tMon, 16 Dec 2024 15:42:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E78967F9C;\n\tMon, 16 Dec 2024 16:42:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BB3167F72\n\tfor ;\n\tMon, 16 Dec 2024 16:42:33 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bfdf:3a3c:e45:66e3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96362A30;\n\tMon, 16 Dec 2024 16:41:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ag2O+Voo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734363716;\n\tbh=L81KN7R/BOj6ABWZJ0ZS63M/EB8ev+WtAxJ7qGap3rU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ag2O+Vooi5599fT6P32k00vFM0ARMpijRElYPq+qoq0ojwMDod5ZhPsa3frS8YC2q\n\trcUAQWQ7hEtGD+GnmbkEGLyJWO1CH3uoWqO/DkXTQECh7z94AP6UtvamcvvNaYJ09f\n\txhSIAmWvM5Ohm4335L6arh+A32x0lDrOcZ6LqB7k=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"[PATCH v4 17/20] pipeline: rkisp1: make RkISP1CameraConfiguration a\n\tfriend of the pipeline handler","Date":"Mon, 16 Dec 2024 16:40:57 +0100","Message-ID":"<20241216154124.203650-18-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","References":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For the validate() implementation, the RkISP1CameraConfiguration needs\naccess to dewarper related members of the PipelineHandlerRkISP1 object.\nAllow this access by adding const versions of the pipe accessors and\nmaking RkISP1CameraConfiguration a friend of PipelineHandlerRkISP1.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n\n---\nChanges in v4:\n- Changed commit title prefix to pipeline:\n- Collected tags\n\nChanges in v3:\n- Added this patch\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 14d4bb9a929b..55b839e76d06 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -98,6 +98,7 @@ public:\n \t}\n \n \tPipelineHandlerRkISP1 *pipe();\n+\tconst PipelineHandlerRkISP1 *pipe() const;\n \tint loadIPA(unsigned int hwRevision);\n \n \tStream mainPathStream_;\n@@ -176,6 +177,7 @@ private:\n \t}\n \n \tfriend RkISP1CameraData;\n+\tfriend RkISP1CameraConfiguration;\n \tfriend RkISP1Frames;\n \n \tint initLinks(Camera *camera, const CameraSensor *sensor,\n@@ -363,6 +365,11 @@ PipelineHandlerRkISP1 *RkISP1CameraData::pipe()\n \treturn static_cast(Camera::Private::pipe());\n }\n \n+const PipelineHandlerRkISP1 *RkISP1CameraData::pipe() const\n+{\n+\treturn static_cast(Camera::Private::pipe());\n+}\n+\n int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n {\n \tipa_ = IPAManager::createIPA(pipe(), 1, 1);\n","prefixes":["v4","17/20"]}