{"id":22362,"url":"https://patchwork.libcamera.org/api/patches/22362/?format=json","web_url":"https://patchwork.libcamera.org/patch/22362/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241216154124.203650-17-stefan.klug@ideasonboard.com>","date":"2024-12-16T15:40:56","name":"[v4,16/20] libcamera: camera: Add a const version of the pipe() function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1f3c654bb35746e23e3d484b0819d1d0047b2d9c","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22362/mbox/","series":[{"id":4896,"url":"https://patchwork.libcamera.org/api/series/4896/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4896","date":"2024-12-16T15:40:40","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":4,"mbox":"https://patchwork.libcamera.org/series/4896/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22362/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22362/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64F52C32F6\n\tfor ;\n\tMon, 16 Dec 2024 15:42:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCFC067F93;\n\tMon, 16 Dec 2024 16:42:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0B1B67F93\n\tfor ;\n\tMon, 16 Dec 2024 16:42:30 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bfdf:3a3c:e45:66e3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E59D675;\n\tMon, 16 Dec 2024 16:41:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"roIgIrYz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734363714;\n\tbh=Y9XUc6pwUUcTXOgIfSoHiwBcpxDYPAnAd21x0kQKGzA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=roIgIrYzZ5VxUL43ofKbjWYoJN8OIa1VLmu2cRoP8dkAcj9yRHSVyQeciaFLttkwq\n\tRsSkxKSY3w0GjTu3FO58FnU9iZn+RLr/HUPGpFPlOzOkKEjlYlTZitbEnJVKPj95SY\n\t9IPJedzWbDyLiZHSodo9atM9MxsOcNIFxfwei6zY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"[PATCH v4 16/20] libcamera: camera: Add a const version of the\n\tpipe() function","Date":"Mon, 16 Dec 2024 16:40:56 +0100","Message-ID":"<20241216154124.203650-17-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","References":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Allow access to the pipeline handler on a const instance of\nCamera::Private.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n\n---\nChanges in v4:\n- Collected tags\n- Updated title\n\nChanges in v3:\n- Added this patch\n---\n include/libcamera/internal/camera.h | 1 +\n src/libcamera/camera.cpp | 5 +++++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 0add0428bb5d..2bb00bbcb644 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -32,6 +32,7 @@ public:\n \t~Private();\n \n \tPipelineHandler *pipe() { return pipe_.get(); }\n+\tconst PipelineHandler *pipe() const { return pipe_.get(); }\n \n \tstd::list queuedRequests_;\n \tControlInfoMap controlInfo_;\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 4c865a46af53..69a7ee5353f1 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -603,6 +603,11 @@ Camera::Private::~Private()\n * \\return The pipeline handler that created this camera\n */\n \n+/**\n+ * \\fn Camera::Private::pipe() const\n+ * \\copydoc Camera::Private::pipe()\n+ */\n+\n /**\n * \\fn Camera::Private::validator()\n * \\brief Retrieve the control validator related to this camera\n","prefixes":["v4","16/20"]}