[{"id":2967,"web_url":"https://patchwork.libcamera.org/comment/2967/","msgid":"<20191027234106.GE28970@pendragon.ideasonboard.com>","date":"2019-10-27T23:41:06","subject":"Re: [libcamera-devel] [PATCH 5/6] test: object-invoke: invoke\n\tmethod in blocking mode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Oct 27, 2019 at 09:33:34PM +0100, Jacopo Mondi wrote:\n> Change the object-invoke test to perform the second method invocation\n> operation in blocking mode.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> test/object-invoke.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp\n> index 6e0e24b146f0..4ae8c91ab7f0 100644\n> --- a/test/object-invoke.cpp\n> +++ b/test/object-invoke.cpp\n> @@ -102,8 +102,7 @@ protected:\n> \t\tthread_.start();\n> \n> \t\tobject.invokeMethod(&InvokedObject::method,\n> -\t\t\t\t InvocationTypeAuto, 42);\n> -\t\tthis_thread::sleep_for(chrono::milliseconds(100));\n> +\t\t\t\t InvocationTypeBlocking, 42);\n\nThe indentation is wrong here.\n\nWith this change, I think you can remote #include at the top of\nthe file. Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> \n> \t\tswitch (object.status()) {\n> \t\tcase InvokedObject::NoCall:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D51E66017C\n\tfor ;\n\tMon, 28 Oct 2019 00:41:14 +0100 (CET)","from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 596BA325;\n\tMon, 28 Oct 2019 00:41:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572219674;\n\tbh=PhLP3oZKRtUwjuo6pkaYHWY6fXE9G5NzlAI0DVIDs2o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JjUynEhNBWCFLulPYbuBw9olDeEB53+Uq9qlozPz4S+bqIgDXfdvFmNAB+y8gJ77H\n\tekeAFMy0XWGVxhDj2O1D/kmDL99BiqowBH6oWe6B7RUf5H1qsBOOnEvCve/t+vDta+\n\tAKHM9n24JXD2T2KanHtbQMuYyAgovd8lBknFdHU0=","Date":"Mon, 28 Oct 2019 01:41:06 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191027234106.GE28970@pendragon.ideasonboard.com>","References":"<20191027203335.26888-1-jacopo@jmondi.org>\n\t<20191027203335.26888-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191027203335.26888-6-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/6] test: object-invoke: invoke\n\tmethod in blocking mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Oct 2019 23:41:15 -0000"}}]