[{"id":32775,"web_url":"https://patchwork.libcamera.org/comment/32775/","msgid":"","date":"2024-12-16T17:48:24","subject":"Re: [PATCH v4 06/20] libcamera: converter_v4l2_m2m: Add missing\n\toverride specifier","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Mon, Dec 16, 2024 at 04:40:46PM +0100, Stefan Klug wrote:\n> In preparation to adding new functions and overrides to the\n> V4L2M2MDevice class add an override specifier to all overridden\n> functions in the class. This prevents -Winconsistent-missing-override\n> warnings.\n>\n> Signed-off-by: Stefan Klug \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n>\n> Changes in v4:\n> - Added this patch\n> ---\n> .../internal/converter/converter_v4l2_m2m.h | 25 ++++++++++---------\n> 1 file changed, 13 insertions(+), 12 deletions(-)\n>\n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 0bc0d053e2c4..9b8e43ff0b91 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -38,28 +38,29 @@ class V4L2M2MConverter : public Converter\n> public:\n> \tV4L2M2MConverter(MediaDevice *media);\n>\n> -\tint loadConfiguration([[maybe_unused]] const std::string &filename) { return 0; }\n> -\tbool isValid() const { return m2m_ != nullptr; }\n> +\tint loadConfiguration([[maybe_unused]] const std::string &filename) override { return 0; }\n> +\tbool isValid() const override { return m2m_ != nullptr; }\n>\n> -\tstd::vector formats(PixelFormat input);\n> -\tSizeRange sizes(const Size &input);\n> +\tstd::vector formats(PixelFormat input) override;\n> +\tSizeRange sizes(const Size &input) override;\n>\n> \tstd::tuple\n> -\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size);\n> +\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size) override;\n>\n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector> &outputCfg);\n> +\t\t const std::vector>\n> +\t\t &outputCfg) override;\n> \tint exportBuffers(const Stream *stream, unsigned int count,\n> -\t\t\t std::vector> *buffers);\n> +\t\t\t std::vector> *buffers) override;\n>\n> -\tint start();\n> -\tvoid stop();\n> +\tint start() override;\n> +\tvoid stop() override;\n>\n> \tint queueBuffers(FrameBuffer *input,\n> -\t\t\t const std::map &outputs);\n> +\t\t\t const std::map &outputs) override;\n>\n> -\tint setInputCrop(const Stream *stream, Rectangle *rect);\n> -\tstd::pair inputCropBounds(const Stream *stream);\n> +\tint setInputCrop(const Stream *stream, Rectangle *rect) override;\n> +\tstd::pair inputCropBounds(const Stream *stream) override;\n>\n> private:\n> \tclass V4L2M2MStream : protected Loggable\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84CACC32F6\n\tfor ;\n\tMon, 16 Dec 2024 17:48:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8D2E67F93;\n\tMon, 16 Dec 2024 18:48:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E66E867F7F\n\tfor ;\n\tMon, 16 Dec 2024 18:48:27 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D344675;\n\tMon, 16 Dec 2024 18:47:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PDaGOr6Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734371271;\n\tbh=+hvjn5BjHoDXrZiDUAmdm+YBnBOcXb40HbdJaJ3J8gE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PDaGOr6YfMOdi6IyFD2X3EroJGe0ImRuR4U7hEW9tzUrYKEsBUXrrf82ynCJx+cqa\n\t6acJbP298K1Zy+DdQfWdc0WYHF1xWZir+UoVmPHq9Igb2yBZvYQep6pf590AaVs20L\n\tjw9NuNODzkxE89aYsmoYr67aBOh26wjX74r68+Sc=","Date":"Mon, 16 Dec 2024 18:48:24 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 06/20] libcamera: converter_v4l2_m2m: Add missing\n\toverride specifier","Message-ID":"","References":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>\n\t<20241216154124.203650-7-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241216154124.203650-7-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32795,"web_url":"https://patchwork.libcamera.org/comment/32795/","msgid":"","date":"2024-12-17T03:32:59","subject":"Re: [PATCH v4 06/20] libcamera: converter_v4l2_m2m: Add missing\n\toverride specifier","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Mon, Dec 16, 2024 at 04:40:46PM +0100, Stefan Klug wrote:\n> In preparation to adding new functions and overrides to the\n\ns/In preparation to/In preparation for/\n\n> V4L2M2MDevice class add an override specifier to all overridden\n\ns/ add/, add/\n\n> functions in the class. This prevents -Winconsistent-missing-override\n> warnings.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v4:\n> - Added this patch\n> ---\n> .../internal/converter/converter_v4l2_m2m.h | 25 ++++++++++---------\n> 1 file changed, 13 insertions(+), 12 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 0bc0d053e2c4..9b8e43ff0b91 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -38,28 +38,29 @@ class V4L2M2MConverter : public Converter\n> public:\n> \tV4L2M2MConverter(MediaDevice *media);\n> \n> -\tint loadConfiguration([[maybe_unused]] const std::string &filename) { return 0; }\n> -\tbool isValid() const { return m2m_ != nullptr; }\n> +\tint loadConfiguration([[maybe_unused]] const std::string &filename) override { return 0; }\n> +\tbool isValid() const override { return m2m_ != nullptr; }\n> \n> -\tstd::vector formats(PixelFormat input);\n> -\tSizeRange sizes(const Size &input);\n> +\tstd::vector formats(PixelFormat input) override;\n> +\tSizeRange sizes(const Size &input) override;\n> \n> \tstd::tuple\n> -\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size);\n> +\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size) override;\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector> &outputCfg);\n> +\t\t const std::vector>\n> +\t\t &outputCfg) override;\n> \tint exportBuffers(const Stream *stream, unsigned int count,\n> -\t\t\t std::vector> *buffers);\n> +\t\t\t std::vector> *buffers) override;\n> \n> -\tint start();\n> -\tvoid stop();\n> +\tint start() override;\n> +\tvoid stop() override;\n> \n> \tint queueBuffers(FrameBuffer *input,\n> -\t\t\t const std::map &outputs);\n> +\t\t\t const std::map &outputs) override;\n> \n> -\tint setInputCrop(const Stream *stream, Rectangle *rect);\n> -\tstd::pair inputCropBounds(const Stream *stream);\n> +\tint setInputCrop(const Stream *stream, Rectangle *rect) override;\n> +\tstd::pair inputCropBounds(const Stream *stream) override;\n> \n> private:\n> \tclass V4L2M2MStream : protected Loggable\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EE65C32F6\n\tfor ;\n\tTue, 17 Dec 2024 03:33:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18C2E67FB3;\n\tTue, 17 Dec 2024 04:33:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50A0661899\n\tfor ;\n\tTue, 17 Dec 2024 04:33:08 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:1a78:c005:412c:c675])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46B473E;\n\tTue, 17 Dec 2024 04:32:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J6tfnH0m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734406351;\n\tbh=g4sUZOi0oEbjss/Usk8qe1uk3+EEV/qTMEhSwTgE9Vw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J6tfnH0mdWN/4URXZ7lvjoeuc9pRO09+POEcCWdf9GayPKmifWT4UKsUykxFUFZnh\n\t+otbT4L0kVstet7R68z3LYm/mrZIvfDbP6cRS/354/FHKFH2TZzzgu6EWmU4ic0OgQ\n\tWwD9qC3thSZhgu2rWfGUed8Dp4vaZeXD0gUrY7+I=","Date":"Tue, 17 Dec 2024 12:32:59 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 06/20] libcamera: converter_v4l2_m2m: Add missing\n\toverride specifier","Message-ID":"","References":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>\n\t<20241216154124.203650-7-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241216154124.203650-7-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]