[{"id":32749,"web_url":"https://patchwork.libcamera.org/comment/32749/","msgid":"<z6iudt4gbyn4f2sttc6ipru3tjvekgidzbxsiw5o3dg3ddefqg@66eevedohuxd>","date":"2024-12-16T07:38:44","subject":"Re: [libcamera-ci] [PATCH] Enable clang build on Debian trixie","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Sun, Dec 15, 2024 at 11:22:54PM +0200, Laurent Pinchart wrote:\n> Debian stable ships a relatively old clang version. Add a build test\n> with the most recent available clang version on trixie.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n> Successful CI run for the libcamera master branch:\n> https://gitlab.freedesktop.org/pinchartl/libcamera/-/pipelines/1330345\n> ---\n>  gitlab-ci.yml | 7 +++++++\n>  1 file changed, 7 insertions(+)\n>\n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index c78235ec1e52d571..06ab27dc0af0d9df 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -224,6 +224,13 @@ build-full:debian:13:\n>        - ARCH: amd64\n>          CC: gcc-14\n>          CXX: g++-14\n> +      - ARCH: amd64\n> +        CC: clang\n> +        CXX: clang++\n> +        MESON_OPTIONS: >-\n> +          ${MESON_ALL_OPTIONS}\n> +          ${MESON_CLANG_OPTIONS}\n> +          -D qcam=disabled\n\nJust wondering why we don't need these options for gcc, but mostly for\nmy education.\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n  j\n\n>\n>  # Build each commit in the branch individually to detect compilation breakages.\n>  build-history:\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40706C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Dec 2024 07:38:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7091167F37;\n\tMon, 16 Dec 2024 08:38:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D00F62C8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Dec 2024 08:38:47 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8421313C;\n\tMon, 16 Dec 2024 08:38:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f6ZycBP0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734334690;\n\tbh=bFXZ1W34PF9j3GwCA5LUh6ZrGOtnlu9500Yt25BcnAo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f6ZycBP0nH7dtT241bBq0BxQrfNg/tKQkWIH17lu5NRIPrLqlKPbYocFxJL2q9a9r\n\tRp0nMTFg4WAW6FB28f5EujvhvACwq9TmRO/S3HUEeVb+Bmk0T5SEs6ZidyOyFmjG2K\n\t6VG203Xstba5+6SX7zlH4p4Bh4KrE2xb3EeWb9J8=","Date":"Mon, 16 Dec 2024 08:38:44 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>","Subject":"Re: [libcamera-ci] [PATCH] Enable clang build on Debian trixie","Message-ID":"<z6iudt4gbyn4f2sttc6ipru3tjvekgidzbxsiw5o3dg3ddefqg@66eevedohuxd>","References":"<20241215212254.19987-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241215212254.19987-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":32753,"web_url":"https://patchwork.libcamera.org/comment/32753/","msgid":"<20241216095051.GF32204@pendragon.ideasonboard.com>","date":"2024-12-16T09:50:51","subject":"Re: [libcamera-ci] [PATCH] Enable clang build on Debian trixie","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 16, 2024 at 08:38:44AM +0100, Jacopo Mondi wrote:\n> On Sun, Dec 15, 2024 at 11:22:54PM +0200, Laurent Pinchart wrote:\n> > Debian stable ships a relatively old clang version. Add a build test\n> > with the most recent available clang version on trixie.\n> >\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> > Successful CI run for the libcamera master branch:\n> > https://gitlab.freedesktop.org/pinchartl/libcamera/-/pipelines/1330345\n> > ---\n> >  gitlab-ci.yml | 7 +++++++\n> >  1 file changed, 7 insertions(+)\n> >\n> > diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> > index c78235ec1e52d571..06ab27dc0af0d9df 100644\n> > --- a/gitlab-ci.yml\n> > +++ b/gitlab-ci.yml\n> > @@ -224,6 +224,13 @@ build-full:debian:13:\n> >        - ARCH: amd64\n> >          CC: gcc-14\n> >          CXX: g++-14\n> > +      - ARCH: amd64\n> > +        CC: clang\n> > +        CXX: clang++\n> > +        MESON_OPTIONS: >-\n> > +          ${MESON_ALL_OPTIONS}\n> > +          ${MESON_CLANG_OPTIONS}\n> > +          -D qcam=disabled\n> \n> Just wondering why we don't need these options for gcc, but mostly for\n> my education.\n\ngit log and git blame have the answer :-)\n\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> \n> >  # Build each commit in the branch individually to detect compilation breakages.\n> >  build-history:","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A420C32F9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Dec 2024 09:51:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49AD667F4B;\n\tMon, 16 Dec 2024 10:51:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5DF260136\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Dec 2024 10:51:07 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E96913C;\n\tMon, 16 Dec 2024 10:50:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UMqjcEzc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734342631;\n\tbh=hguruAQmUB7JkOQP7euKcSMnLaleA6QHrKAxRDo99rY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UMqjcEzc/mmeWobdL6z7qGp7sHPBD1trxS2amXBvAXuAlZ3gqaJFQgvRoALDWwTh6\n\tzyvAgShOXbxH+GytA+AKnpOZX5HNIMH+i9UWGdR1ZzDgHWLPR0Ryvrj8NxwK9On9R5\n\tJWUaq0lKGINvE5ib63WRRHDQ2z1AuZFa+Ir2iK4Y=","Date":"Mon, 16 Dec 2024 11:50:51 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>","Subject":"Re: [libcamera-ci] [PATCH] Enable clang build on Debian trixie","Message-ID":"<20241216095051.GF32204@pendragon.ideasonboard.com>","References":"<20241215212254.19987-1-laurent.pinchart@ideasonboard.com>\n\t<z6iudt4gbyn4f2sttc6ipru3tjvekgidzbxsiw5o3dg3ddefqg@66eevedohuxd>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<z6iudt4gbyn4f2sttc6ipru3tjvekgidzbxsiw5o3dg3ddefqg@66eevedohuxd>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]