[{"id":32731,"web_url":"https://patchwork.libcamera.org/comment/32731/","msgid":"","date":"2024-12-15T18:20:57","subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Another thing: FrameBufferAllocator does not consider it an error\nif the underlying Camera's `exportFrameBuffers()` returns.\nThis should be clarified.\n\n\n2024. december 15., vasárnap 19:18 keltezéssel, Barnabás Pőcze írta:\n\n> `FrameBufferAllocator::allocate()` might return a negative error code,\n> but currently this is handled the same way as success. So instead\n> of continuing, abort the construction.\n> \n> Signed-off-by: Barnabás Pőcze pobrn@protonmail.com\n> \n> ---\n> src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\n> index 7e4c904da..b0c84893a 100644\n> --- a/src/gstreamer/gstlibcameraallocator.cpp\n> +++ b/src/gstreamer/gstlibcameraallocator.cpp\n> @@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr camera,\n> \n> Stream *stream = streamCfg.stream();\n> \n> ret = self->fb_allocator->allocate(stream);\n> \n> - if (ret == 0)\n> + if (ret <= 0)\n> return nullptr;\n> \n> GQueue *pool = g_queue_new();\n> --\n> 2.47.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F4AEC32F6\n\tfor ;\n\tSun, 15 Dec 2024 18:21:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C46D67F0B;\n\tSun, 15 Dec 2024 19:21:07 +0100 (CET)","from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88C2367F06\n\tfor ;\n\tSun, 15 Dec 2024 19:21:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"oxvMT/ru\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734286865; x=1734546065;\n\tbh=lWvAJ5N5fjR5bNkp6CNv4tS8dAAWg6zTBxF6duGLsB8=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=oxvMT/ruUqZ0SUsggULpSDHO8S1oinwQROD2DsYOzrNwWyOQqxxnp9AzNWE8zxYhQ\n\tFX56sK7VqiBMxf6FxVKu8A/fZL9x4hAI3v/tyv9CtoCTqOpA2qVUfxQEXRe0fE6Dnh\n\tZeXAbHONHQ+vb5snle7y/AN/x4cMFmCX+byb5OVuHQSa3/OkHjA2t9W0ny8jWXzEB+\n\tAmEvBP5bOCTKe0BqRp+lu+4nSZjy0TEzqAaz6aYJyZ2adTHnh7FU4OIn1KUIShYgH7\n\tNBiqUCHR9AhrQpRw3UjItexC0Y3xc8RBT6M8ZNC34oSHI4MW0xTat0lt9sPggvPYMW\n\t8Jt3ducurvlRQ==","Date":"Sun, 15 Dec 2024 18:20:57 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","Message-ID":"","In-Reply-To":"<20241215181835.802589-1-pobrn@protonmail.com>","References":"<20241215181835.802589-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"ad43a7b64473112943da59a26e368c43fae612e1","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32739,"web_url":"https://patchwork.libcamera.org/comment/32739/","msgid":"<20241215213642.GR9975@pendragon.ideasonboard.com>","date":"2024-12-15T21:36:42","subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Sun, Dec 15, 2024 at 06:18:38PM +0000, Barnabás Pőcze wrote:\n> `FrameBufferAllocator::allocate()` might return a negative error code,\n> but currently this is handled the same way as success. So instead\n> of continuing, abort the construction.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\n> index 7e4c904da..b0c84893a 100644\n> --- a/src/gstreamer/gstlibcameraallocator.cpp\n> +++ b/src/gstreamer/gstlibcameraallocator.cpp\n> @@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr camera,\n> \t\tStream *stream = streamCfg.stream();\n> \n> \t\tret = self->fb_allocator->allocate(stream);\n> -\t\tif (ret == 0)\n> +\t\tif (ret <= 0)\n> \t\t\treturn nullptr;\n> \n> \t\tGQueue *pool = g_queue_new();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3A11C32F6\n\tfor ;\n\tSun, 15 Dec 2024 21:37:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1857067F26;\n\tSun, 15 Dec 2024 22:37:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8175C67F1B\n\tfor ;\n\tSun, 15 Dec 2024 22:37:00 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48ED999F;\n\tSun, 15 Dec 2024 22:36:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j3aGK1EL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734298584;\n\tbh=rsKJUsFBalcpkRGQLjMJQopSTgCPJSQL+nk5sswTzxY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j3aGK1ELOVfIhuR5Th6cXOd9SclQttv3XdVKQS59z3jZ6IzhN73NwOjQgWG2Nv6Wh\n\tUuWByQZho4jsGIa0UR2JPBYjtOIYfTEzD6RvUZlKKM+GFi5x/Rb7xjHQ2y3hMYMeFS\n\tC6HBhcYTOW527oieR3yVKtCzVdZlM4Bs+cLf+Qe0=","Date":"Sun, 15 Dec 2024 23:36:42 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","Message-ID":"<20241215213642.GR9975@pendragon.ideasonboard.com>","References":"<20241215181835.802589-1-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241215181835.802589-1-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32740,"web_url":"https://patchwork.libcamera.org/comment/32740/","msgid":"<20241215213806.GS9975@pendragon.ideasonboard.com>","date":"2024-12-15T21:38:06","subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Dec 15, 2024 at 06:20:57PM +0000, Barnabás Pőcze wrote:\n> Another thing: FrameBufferAllocator does not consider it an error\n> if the underlying Camera's `exportFrameBuffers()` returns.\n\nI'd be worried if the function never returned :-) Did you mean if it\nreturns 0 ? Maybe we could return -ENOMEM in that case, and document\nthat 0 is not a valid return value ?\n\n> This should be clarified.\n> \n> 2024. december 15., vasárnap 19:18 keltezéssel, Barnabás Pőcze írta:\n> \n> > `FrameBufferAllocator::allocate()` might return a negative error code,\n> > but currently this is handled the same way as success. So instead\n> > of continuing, abort the construction.\n> > \n> > Signed-off-by: Barnabás Pőcze pobrn@protonmail.com\n> > \n> > ---\n> > src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\n> > index 7e4c904da..b0c84893a 100644\n> > --- a/src/gstreamer/gstlibcameraallocator.cpp\n> > +++ b/src/gstreamer/gstlibcameraallocator.cpp\n> > @@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr camera,\n> > \n> > Stream *stream = streamCfg.stream();\n> > \n> > ret = self->fb_allocator->allocate(stream);\n> > \n> > - if (ret == 0)\n> > + if (ret <= 0)\n> > return nullptr;\n> > \n> > GQueue *pool = g_queue_new();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EFDCC32F6\n\tfor ;\n\tSun, 15 Dec 2024 21:38:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AF9467F26;\n\tSun, 15 Dec 2024 22:38:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5547E67F1B\n\tfor ;\n\tSun, 15 Dec 2024 22:38:23 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F29199F;\n\tSun, 15 Dec 2024 22:37:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZA0Ng9ce\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734298667;\n\tbh=rWAehm+hI9S18wg+iXk5+WHAX1vWp/LiiSDRFQh0pBM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZA0Ng9cev08tbf3p1NLSpU7LRbOpM5MH4TUFU3povs7figYxGyQzEbX83NaI/Jfqm\n\tKHMBGlmDhjClfb5f2TGCR64WMKT+EwVaGMAPiInHxHFLwwj3zEfYkuMotg7bT0S3xm\n\tntrSzxVVddHWm9N7a54GomsdWudYxc+/P4M5qoVc=","Date":"Sun, 15 Dec 2024 23:38:06 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","Message-ID":"<20241215213806.GS9975@pendragon.ideasonboard.com>","References":"<20241215181835.802589-1-pobrn@protonmail.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32741,"web_url":"https://patchwork.libcamera.org/comment/32741/","msgid":"","date":"2024-12-15T21:41:36","subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2024. december 15., vasárnap 22:38 keltezéssel, Laurent Pinchart írta:\n\n> On Sun, Dec 15, 2024 at 06:20:57PM +0000, Barnabás Pőcze wrote:\n> \n> > Another thing: FrameBufferAllocator does not consider it an error\n> > if the underlying Camera's `exportFrameBuffers()` returns.\n> \n> \n> I'd be worried if the function never returned :-) Did you mean if it\n> returns 0 ? Maybe we could return -ENOMEM in that case, and document\n> that 0 is not a valid return value ?\n\nYes, \"returns 0\" is what I wanted to write.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> > This should be clarified.\n> > \n> > 2024. december 15., vasárnap 19:18 keltezéssel, Barnabás Pőcze írta:\n> > \n> > > `FrameBufferAllocator::allocate()` might return a negative error code,\n> > > but currently this is handled the same way as success. So instead\n> > > of continuing, abort the construction.\n> > > \n> > > Signed-off-by: Barnabás Pőcze pobrn@protonmail.com\n> > > \n> > > ---\n> > > src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\n> > > index 7e4c904da..b0c84893a 100644\n> > > --- a/src/gstreamer/gstlibcameraallocator.cpp\n> > > +++ b/src/gstreamer/gstlibcameraallocator.cpp\n> > > @@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr camera,\n> > > \n> > > Stream *stream = streamCfg.stream();\n> > > \n> > > ret = self->fb_allocator->allocate(stream);\n> > > \n> > > - if (ret == 0)\n> > > + if (ret <= 0)\n> > > return nullptr;\n> > > \n> > > GQueue *pool = g_queue_new();\n> \n> \n> --\n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52A4FC32F5\n\tfor ;\n\tSun, 15 Dec 2024 21:41:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 799DC67F1B;\n\tSun, 15 Dec 2024 22:41:44 +0100 (CET)","from mail-10628.protonmail.ch (mail-10628.protonmail.ch\n\t[79.135.106.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AF6B67F1B\n\tfor ;\n\tSun, 15 Dec 2024 22:41:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"jerEz6E7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734298901; x=1734558101;\n\tbh=jZthYRRekpGUWqJfR1VJXDGwcATIsQHv4Svoliyhqd4=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=jerEz6E7lsydLP8MmNkkXayF2zHd9z3r/ZzUpzFJOP6fp2mK7xE4sG04nxWgiP9N1\n\tsCDv5cZOjWENFJ3R4afHVCgzIZgAUTUNxtboFGQHzsFEf3nI4W8emKFRFiYvck1ViF\n\tFkoG2m/caRv62ow+KZ/zUVRNmRiSB+nsZMWtlAk+w2CpTM2Zvg/CFxJeKMaiHrLiTw\n\t6ryPhAscXiMD3Ks9taVo6VioL0kJhbElf8czHiDoqsO8SeIpQu0RiSkPUeu8NBsXLV\n\tRmBLkCV/n8eiKMxXuzYJ7/yF5gsmnvZ5mC61jd2EFqatnh8YY8NcL1ncHQfZ5ZDw4F\n\tWTg+TbXHGv5YQ==","Date":"Sun, 15 Dec 2024 21:41:36 +0000","To":"Laurent Pinchart ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/2] gstreamer: allocator: Recognize\n\tFrameBufferAllocator errors","Message-ID":"","In-Reply-To":"<20241215213806.GS9975@pendragon.ideasonboard.com>","References":"<20241215181835.802589-1-pobrn@protonmail.com>\n\t\n\t<20241215213806.GS9975@pendragon.ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"9c0a28a5fb7b3949023b1ace23f17a8fb938f46e","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]