[{"id":32719,"web_url":"https://patchwork.libcamera.org/comment/32719/","msgid":"","date":"2024-12-13T10:35:00","subject":"Re: [PATCH 6/6] ipa: rpi: Provide the camera helper with the\n\thardware configuration","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch.\n\nOn Fri, 13 Dec 2024 at 09:46, Naushir Patuck wrote:\n>\n> Add a CamHelper::setHwConfig() helper used by the IPA to set the\n> hardware configuartion in use by the pipeline. This will be needed by\n\ns/configuartion/configuration/ (sorry!)\n\nOther than that:\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> the IMX500 camera helper in a future commit to determine if the\n> metadata buffer is strided.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/cam_helper/cam_helper.cpp | 5 +++++\n> src/ipa/rpi/cam_helper/cam_helper.h | 2 ++\n> src/ipa/rpi/common/ipa_base.cpp | 1 +\n> 3 files changed, 8 insertions(+)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper.cpp b/src/ipa/rpi/cam_helper/cam_helper.cpp\n> index 6493e88232a4..1422a02e9953 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper.cpp\n> @@ -156,6 +156,11 @@ void CamHelper::setCameraMode(const CameraMode &mode)\n> }\n> }\n>\n> +void CamHelper::setHwConfig(const Controller::HardwareConfig &hwConfig)\n> +{\n> + hwConfig_ = hwConfig;\n> +}\n> +\n> void CamHelper::getDelays(int &exposureDelay, int &gainDelay,\n> int &vblankDelay, int &hblankDelay) const\n> {\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper.h b/src/ipa/rpi/cam_helper/cam_helper.h\n> index 4a4ab5e68cba..fb7eb3202e79 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper.h\n> +++ b/src/ipa/rpi/cam_helper/cam_helper.h\n> @@ -76,6 +76,7 @@ public:\n> CamHelper(std::unique_ptr parser, unsigned int frameIntegrationDiff);\n> virtual ~CamHelper();\n> void setCameraMode(const CameraMode &mode);\n> + void setHwConfig(const Controller::HardwareConfig &hwConfig);\n> virtual void prepare(libcamera::Span buffer,\n> Metadata &metadata);\n> virtual void process(StatisticsPtr &stats, Metadata &metadata);\n> @@ -108,6 +109,7 @@ protected:\n>\n> std::unique_ptr parser_;\n> CameraMode mode_;\n> + Controller::HardwareConfig hwConfig_;\n>\n> private:\n> /*\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index b3656cbc730b..a7d27ef66ec4 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -161,6 +161,7 @@ int32_t IpaBase::init(const IPASettings &settings, const InitParams ¶ms, Ini\n> lensPresent_ = params.lensPresent;\n>\n> controller_.initialise();\n> + helper_->setHwConfig(controller_.getHardwareConfig());\n>\n> /* Return the controls handled by the IPA */\n> ControlInfoMap::Map ctrlMap = ipaControls;\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2899C32EA\n\tfor ;\n\tFri, 13 Dec 2024 10:35:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 539E567EF2;\n\tFri, 13 Dec 2024 11:35:13 +0100 (CET)","from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com\n\t[IPv6:2607:f8b0:4864:20::82b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B50D618AD\n\tfor ;\n\tFri, 13 Dec 2024 11:35:12 +0100 (CET)","by mail-qt1-x82b.google.com with SMTP id\n\td75a77b69052e-46792996074so18662481cf.0\n\tfor ;\n\tFri, 13 Dec 2024 02:35:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ihEIhD0F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1734086111; x=1734690911;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=wOLU7CYoQIRhi1bntdhW2U2c2zm+2VdY5/Bhr8bjaXM=;\n\tb=ihEIhD0F83YsqGSawFS0nZdzP1tSoSzyLtxtJZksablynntpEWaaIld5CbPk8SmVcs\n\tS5tlPeScrZs9cZVLsog0xE0KniLCIbY7VyPyVcAu2Bmd2N8hZW63xBf1HYILusz25/Ep\n\tZyGbbpIkWTL8fb8viSCyiG5STOpCx7CXkDt1Z+Gt7w96kfHBqyfLcQIdhkR6WTPTSM3W\n\tjX/s0kLIbjD1y6ebYMS9cR3ED98DuJuFeWBreg55wJ4ndn30AlLc0uod6AUGOYyPPLjH\n\tIrFMKdkesByth11rz6BHziJURk8s1iZ7Ua1iIyD++3VqclUgoM9eZEljIs8jXRvmSLUp\n\taYjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1734086111; x=1734690911;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=wOLU7CYoQIRhi1bntdhW2U2c2zm+2VdY5/Bhr8bjaXM=;\n\tb=KcE7Yz0pQs25bEwQXGUXvqKM4iBOHy1CD7Wx9c3gpDGL5Hw/WUMXvDn4E2YUy94r7X\n\tlXpHatQe1GDDRxkgefPzboTdyNzL+VFsjstmtuCIa/n5WN5YcBGNLdbRrNNilb1e3vTz\n\tR3250VHuoGfbmu4OX4T6VxB7M8zmkEQ9ChInmNBd2FbU5SpqbLIOu1XLy30gN57EROl7\n\tQ+z65xp74gu9jXg0dHju0/1L6kHW8wQojxIXHHh2TlirBBgZK0vgOovEeP52RUP3RHwN\n\tgDq3BUZNt9SSSz8vitn0lq6pwBglwj1sdjvKMQiWJjL2vjQ3nY59a8uNgLTwKcj1appl\n\tJglw==","X-Gm-Message-State":"AOJu0YyhGzvJYrDY/J60TWEriNqQvjUncjJnvzMDeqju/M6RsWs6AViW\n\tCcDURo3baxrjZzQB6RDcxYge4qvYZNux8OKQPvYJX4tGAIQ+hStjflHubodo8zqfBODEOs/tkSn\n\toxm9scJ8mugTFmtCDY1LXRP0r9+LRiO24qq6WUQzLctLqAswZBk8=","X-Gm-Gg":"ASbGnctly5IydEvY4Uozj3I+BcY7aEd172KDTJzPN1QFSDxWSNKG9mZEZbxkpNtrmJt\n\tD5ZHQw9dUxp5xINEQkuExkXdTviRevMcVVQu9hA==","X-Google-Smtp-Source":"AGHT+IF3BxyRy2faRxouls/2DN+k1Cc0ajJnm5eY0JQToODuHtiAPbyvAGyQkddIH4YZwWWKwEMMvRTQmwPyc+ZNxsY=","X-Received":"by 2002:a05:622a:1884:b0:467:8541:a969 with SMTP id\n\td75a77b69052e-467a575b255mr26215031cf.14.1734086111158;\n\tFri, 13 Dec 2024 02:35:11 -0800 (PST)","MIME-Version":"1.0","References":"<20241213094602.2083174-1-naush@raspberrypi.com>\n\t<20241213094602.2083174-7-naush@raspberrypi.com>","In-Reply-To":"<20241213094602.2083174-7-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 13 Dec 2024 10:35:00 +0000","Message-ID":"","Subject":"Re: [PATCH 6/6] ipa: rpi: Provide the camera helper with the\n\thardware configuration","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]