{"id":22308,"url":"https://patchwork.libcamera.org/api/patches/22308/?format=json","web_url":"https://patchwork.libcamera.org/patch/22308/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241213094602.2083174-4-naush@raspberrypi.com>","date":"2024-12-13T09:38:26","name":"[3/6] ipa: rpi: Add a HW property to determine if the data buffer is strided","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c6f4cb530041f2e3fe884092d0acaf1b857f04c1","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22308/mbox/","series":[{"id":4881,"url":"https://patchwork.libcamera.org/api/series/4881/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4881","date":"2024-12-13T09:38:23","name":"Raspberry Pi: Various changes","version":1,"mbox":"https://patchwork.libcamera.org/series/4881/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22308/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22308/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D735C32EA\n\tfor ;\n\tFri, 13 Dec 2024 09:46:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6D6267EF4;\n\tFri, 13 Dec 2024 10:46:14 +0100 (CET)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92A2567EE0\n\tfor ;\n\tFri, 13 Dec 2024 10:46:10 +0100 (CET)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-436246b1f9bso1996515e9.1\n\tfor ;\n\tFri, 13 Dec 2024 01:46:10 -0800 (PST)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4362557c502sm43989105e9.11.2024.12.13.01.46.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Dec 2024 01:46:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QWCCSakX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1734083170; x=1734687970;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=NhZXilb32109MmYRaMgOMB8Dlf9MNDOUyVd5nWppRWI=;\n\tb=QWCCSakXTu6iAePo4+NS6nE+t2VN1F5jNcqdVJJ8Ys4d7GwmO4eHZNL+7CnmQ+3wbY\n\twCVnZgG5W30Gautq2VrMMQC8ta6sM5K4Ub9gJyst1UMO0lN2OWDctmpSriPNcoegwgCj\n\tyKMEFsy+/P8NkafZumCaRMeQiPEWAA17oAmUqIN5BFdA0/wh8W56CMfUGslkRg3gJNZM\n\t0p3JV8ZFR+bOku4/acVHzFzYfCjxDsM4EXzthDfQ3ZCxfQU48d5tSpXD6kNniy9QkGe2\n\tRSV2n8UEXf3QJAt1Gpg8yC0bzhqzAeADwm06dxX4ACgoDd0aNxvM+GMa07hoV7Qa6ltI\n\t/tPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1734083170; x=1734687970;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=NhZXilb32109MmYRaMgOMB8Dlf9MNDOUyVd5nWppRWI=;\n\tb=iJ5qULVumKTl2iKliOJoknYdQTcMub50qnbDY2arzoAWFJ8Q/CbFSx39U3Z5Yxk4Lj\n\ttaxHiYLGK8CGrz1EuFTJ5evd2bSHpH1pakYRFSXx7B3YhX3mNn/C2K7y26ttmDnP+GY1\n\tdVySG3Ikbki1SzNSjsablfTU4K1MTiprP9myFoRz90PjT0mmwxFBHOeSCJZxwecMf+96\n\tMf7oBupSh7BNozOVBsXgDpv/DWtVUj9yE9Y2fqoZ1GmdW+c/dqirN0g50h7UCPJTy9uS\n\tvnLuOsPegqLU07dsk3cCArV4wCLyWBrSCL9l7UxRYqyuM49lywt1fj83EQ+phKI1IxXj\n\tj5Ww==","X-Gm-Message-State":"AOJu0YzEGz3S7ivcVB7XJc51cz2d1PxnxEbDdx91Gc6Ij0pxcdT/nGx/\n\t/sQnAFR/F3CvPp1oJATwJXC7zRhr6+lYse3o2l7irkMdTXtlfEqgpTn6KEJwwbIOrfRE53EcwPt\n\t9","X-Gm-Gg":"ASbGncueQ0T/hMKr6Xoc0Hk4wHycj5idoainq4RavGjrhho/kUKAw9WYyLUN45k/M+A\n\tLvBcCijxpXbqR35ikIeNwF06fEdOS34D6tinD0uaj18A1DQmXJqYws5Iw/zEeAIFot19+OPaqwp\n\tpZX/FUOiLrlfZkV4Z2qgw7Q9f3Z0DY3Qo8fzoJCrERXHKUFvM4vkIqRpolxnmSQtQOmJz0CGrPG\n\t2VLaZ7jKTrGxlzkz8nboTwT1Y7hOtmIy8kHjK8YB5I5+VFdKx4JkvXpcEt6rWpkiuPbcU7rBEyh","X-Google-Smtp-Source":"AGHT+IFjcK+/PGuXECU6MqsSj1gItW/RWzcnAZjiluQ5w4DEz0CpPvAGInDB1jdg8wHu3IWAdwrfyA==","X-Received":"by 2002:a05:600c:6d96:b0:431:4983:e8fe with SMTP id\n\t5b1f17b1804b1-4362aab9cafmr5239755e9.9.1734083169813; \n\tFri, 13 Dec 2024 01:46:09 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH 3/6] ipa: rpi: Add a HW property to determine if the data\n\tbuffer is strided","Date":"Fri, 13 Dec 2024 09:38:26 +0000","Message-ID":"<20241213094602.2083174-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241213094602.2083174-1-naush@raspberrypi.com>","References":"<20241213094602.2083174-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This property (cfeDataBufferStrided) indicates if the CSI-2 hardware\nwrites to the embedded/metadata buffer directly, or if it treats the\nbuffer like an image buffer and strides the metadata lines.\n\nUnicam write this buffer strided, while the PiSP Frontend writes to it\ndirectly. This information will be relevant to data parsers in the\nhelpers where the data is structured in lines.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/controller/controller.cpp | 2 ++\n src/ipa/rpi/controller/controller.h | 1 +\n 2 files changed, 3 insertions(+)","diff":"diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\nindex e0131018e7b2..3bce88b9281e 100644\n--- a/src/ipa/rpi/controller/controller.cpp\n+++ b/src/ipa/rpi/controller/controller.cpp\n@@ -39,6 +39,7 @@ static const std::map HardwareConfigMap\n \t\t\t.pipelineWidth = 13,\n \t\t\t.statsInline = false,\n \t\t\t.minPixelProcessingTime = 0s,\n+\t\t\t.cfeDataBufferStrided = true,\n \t\t}\n \t},\n \t{\n@@ -71,6 +72,7 @@ static const std::map HardwareConfigMap\n \t\t\t * frames wider than ~16,000 pixels.\n \t\t\t */\n \t\t\t.minPixelProcessingTime = 1.0us / 380,\n+\t\t\t.cfeDataBufferStrided = false,\n \t\t}\n \t},\n };\ndiff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h\nindex eff520bd61de..64f93f414524 100644\n--- a/src/ipa/rpi/controller/controller.h\n+++ b/src/ipa/rpi/controller/controller.h\n@@ -49,6 +49,7 @@ public:\n \t\tunsigned int pipelineWidth;\n \t\tbool statsInline;\n \t\tlibcamera::utils::Duration minPixelProcessingTime;\n+\t\tbool cfeDataBufferStrided;\n \t};\n \n \tController();\n","prefixes":["3/6"]}