[{"id":32692,"web_url":"https://patchwork.libcamera.org/comment/32692/","msgid":"<173399950781.32744.9787297391314794742@ping.linuxembedded.co.uk>","date":"2024-12-12T10:31:47","subject":"Re: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame\n\tintegration diff value","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman (2024-12-12 10:24:15)\n> This is the minimum permitted difference between the frame length and\n> coarse exposure (both measured in lines). The correct value, taken\n> from the datasheet, is 48.\n\nThank you,\n\nHappy to accept an RB tag from anyone else at Raspberry Pi who might\nhave access to the datasheet, but also I trust you :D - and no one\noutside of Raspberry Pi (well, ok maybe Sony) could comment on this so\nsimply:\n\nAcked-by: Kieran Bingham \n\nWill merge later after giving a bit of time for anyone else at RPi to\ncomment, but I'll take no comment as an ack too!\n\n--\nKieran\n\n\n> Signed-off-by: David Plowman \n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> index ec83d9fd..16a017e9 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> @@ -66,7 +66,7 @@ private:\n> * Smallest difference between the frame length and integration time,\n> * in units of lines.\n> */\n> - static constexpr int frameIntegrationDiff = 22;\n> + static constexpr int frameIntegrationDiff = 48;\n> /* Maximum frame length allowable for long exposure calculations. */\n> static constexpr int frameLengthMax = 0xffdc;\n> /* Largest long exposure scale factor given as a left shift on the frame length. */\n> -- \n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8995BD80A\n\tfor ;\n\tThu, 12 Dec 2024 10:31:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB73867EC7;\n\tThu, 12 Dec 2024 11:31:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43BC567E6D\n\tfor ;\n\tThu, 12 Dec 2024 11:31:50 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A866229;\n\tThu, 12 Dec 2024 11:31:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ppPpcoF0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733999476;\n\tbh=7i9801E5WyS+QVHb8go9oaTsgNlL1ZZ+2vB/IuFh8FE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ppPpcoF0Bcqgv2OfN+DpoOhRuplQNA1WUA7YLtymPfOpXLLODk82OiCi8zat1LxUU\n\tCV+HXzkK/nOjUbluARLcf2nvFoj8oeb1OTUh5q5HN9H2NgZyhLOiygLjag9l91QoV1\n\t0oMvPAHCeuDs/aPvjSK33okKraScQ2zjqWqPlULc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241212102415.8057-1-david.plowman@raspberrypi.com>","References":"<20241212102415.8057-1-david.plowman@raspberrypi.com>","Subject":"Re: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame\n\tintegration diff value","From":"Kieran Bingham ","Cc":"David Plowman ","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 12 Dec 2024 10:31:47 +0000","Message-ID":"<173399950781.32744.9787297391314794742@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32693,"web_url":"https://patchwork.libcamera.org/comment/32693/","msgid":"","date":"2024-12-12T10:32:48","subject":"Re: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame\n\tintegration diff value","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThanks for the fix!\n\nOn Thu, 12 Dec 2024 at 10:24, David Plowman\n wrote:\n>\n> This is the minimum permitted difference between the frame length and\n> coarse exposure (both measured in lines). The correct value, taken\n> from the datasheet, is 48.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> index ec83d9fd..16a017e9 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> @@ -66,7 +66,7 @@ private:\n> * Smallest difference between the frame length and integration time,\n> * in units of lines.\n> */\n> - static constexpr int frameIntegrationDiff = 22;\n> + static constexpr int frameIntegrationDiff = 48;\n> /* Maximum frame length allowable for long exposure calculations. */\n> static constexpr int frameLengthMax = 0xffdc;\n> /* Largest long exposure scale factor given as a left shift on the frame length. */\n> --\n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED84ABD80A\n\tfor ;\n\tThu, 12 Dec 2024 10:33:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B145167EC7;\n\tThu, 12 Dec 2024 11:33:26 +0100 (CET)","from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com\n\t[IPv6:2607:f8b0:4864:20::b2a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCE1D67E6D\n\tfor ;\n\tThu, 12 Dec 2024 11:33:24 +0100 (CET)","by mail-yb1-xb2a.google.com with SMTP id\n\t3f1490d57ef6-e3f5c9a213fso58842276.3\n\tfor ;\n\tThu, 12 Dec 2024 02:33:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rfvPmtzO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733999604; x=1734604404;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=i34G5NgQRk4xj72X9KekOcaSzfNizk3cxeTkiky/rQE=;\n\tb=rfvPmtzOuuM2DOVzBoCCTgZFkV/OO0bb0FY74PrXR66PORj28BqnwRxg9ezmzoTbxT\n\t4GvPGPy8JPej+U8rpk451h+tIWzBam5+IA6qpFDqyvHUyblqhjIw3fscblokKEJqK+wB\n\t4sdel/dV5CKDxGo/1hV4hb8LO9iJ+rg/Jl1qmQXctb2L8ASa70CwdBx/GRf/x6epHmOU\n\tvTBrvX9cepdo80AKCpoX3iWg7vcAsdfo3D+7qUeiT/DoD9Whhske2CWY7KznnZ4Z9bic\n\toUkDPAp6fr7UIIgDkbiTxLemw3r2QvjM/ZbKUPqZ4pKftWbizb0OBlGW4MuRYHHEYkCN\n\tqe5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733999604; x=1734604404;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=i34G5NgQRk4xj72X9KekOcaSzfNizk3cxeTkiky/rQE=;\n\tb=I8rhU/ZNoEoVUgzRzODPBlQk9e7Nres+28QlOO8d5dKEj/fnFENSBMUEtNFdfqRADv\n\tmHLHxf3/7QzE/qKG1i13XCd203yAuIMmPBQnZxClLFgLLvShJuxGUGYbi7ZUPLQQ6n8A\n\ta/eY1rJyWLvpV2RE1QeaHvBv94UhVVo8p5NRh1fHGZr83o2+9idyDy/mKdt37LJXxrDD\n\tBdyYf1Ho8ippsL+hmUpYblUMf+ByfmiGcvYe1Fo3I9JlPexn+323Ot1eCT/+hnX7oliO\n\tmU6vy+GHFi7FwDn7i++PhKyKgLluE6rgroTGXYej1LDFXLqXzCJIibmRP4knmYaLdnFb\n\thEFg==","X-Gm-Message-State":"AOJu0YwtekJJYZU2lNSGrF1mzfItuRWaRbNv6FplpKShRmGNf1/mB4RB\n\tTDzdeE33DcbNg5rFcyJoOjhykvReehtU0loUf0q8eCgWtmz+4wGlFzQR54HVLTkEnp20sUUXKSg\n\tq1YnrRdr3j/ZibZcg6rnheBrFXHrwf2nxL9qWwg==","X-Gm-Gg":"ASbGncskDtJ9xzZp51E7tr6KjBogHkeZjxLxdie96N2gswdzDP6qjgFM18nPN0jl7jy\n\tQryqowSWUYy1Gw+FDID8ooGHAA26hzBhwUuk1UrEH8pcfM6WOnPPlIbqfBA26LP2xK5/6Cg==","X-Google-Smtp-Source":"AGHT+IFJj1fEPsJ8VlCX5qGyhu0fBNgRgRWb48H9BwjmEriabnYg/XO+KbzKJRno12aac2MaB8dWq7re3b9R/KoAUDA=","X-Received":"by 2002:a05:6902:e05:b0:e38:b8bb:fb7d with SMTP id\n\t3f1490d57ef6-e3da28b2f56mr1003266276.11.1733999603826;\n\tThu, 12 Dec 2024 02:33:23 -0800 (PST)","MIME-Version":"1.0","References":"<20241212102415.8057-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20241212102415.8057-1-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Thu, 12 Dec 2024 10:32:48 +0000","Message-ID":"","Subject":"Re: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame\n\tintegration diff value","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32695,"web_url":"https://patchwork.libcamera.org/comment/32695/","msgid":"<173399974648.32744.17445020014071678443@ping.linuxembedded.co.uk>","date":"2024-12-12T10:35:46","subject":"Re: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame\n\tintegration diff value","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2024-12-12 10:32:48)\n> Hi David,\n> \n> Thanks for the fix!\n> \n> On Thu, 12 Dec 2024 at 10:24, David Plowman\n> wrote:\n> >\n> > This is the minimum permitted difference between the frame length and\n> > coarse exposure (both measured in lines). The correct value, taken\n> > from the datasheet, is 48.\n> >\n> > Signed-off-by: David Plowman \n> \n> Reviewed-by: Naushir Patuck \n\nThanks,\n\nMerging.\n\n\n> \n> > ---\n> > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > index ec83d9fd..16a017e9 100644\n> > --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > @@ -66,7 +66,7 @@ private:\n> > * Smallest difference between the frame length and integration time,\n> > * in units of lines.\n> > */\n> > - static constexpr int frameIntegrationDiff = 22;\n> > + static constexpr int frameIntegrationDiff = 48;\n> > /* Maximum frame length allowable for long exposure calculations. */\n> > static constexpr int frameLengthMax = 0xffdc;\n> > /* Largest long exposure scale factor given as a left shift on the frame length. */\n> > --\n> > 2.39.5\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F15EC3260\n\tfor ;\n\tThu, 12 Dec 2024 10:35:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E15D767ED0;\n\tThu, 12 Dec 2024 11:35:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54C4467E6D\n\tfor ;\n\tThu, 12 Dec 2024 11:35:49 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE46D229;\n\tThu, 12 Dec 2024 11:35:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vB35YvYF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733999715;\n\tbh=6S3ygbf7CXWRY0ioH++2GWqtLEAsE3c/CUVqk1O3PrM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vB35YvYFezxXRa959FXk3wrggZoKQNq3NrY6hARLFpN61Kshpi6qlhXOuwwhRJUof\n\tTX3zQqWvmF/NPWydVkSldTtqyjV4UgDuswdmvnX9pdUlQ+aY/z4jYXksD4w/ELz7BR\n\tkGwE5Gmx9lwHdNO+6lNGY8vukHjlFJqr/SrRQjDg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20241212102415.8057-1-david.plowman@raspberrypi.com>\n\t","Subject":"Re: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame\n\tintegration diff value","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"David Plowman ,\n\tNaushir Patuck ","Date":"Thu, 12 Dec 2024 10:35:46 +0000","Message-ID":"<173399974648.32744.17445020014071678443@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]