{"id":22299,"url":"https://patchwork.libcamera.org/api/patches/22299/?format=json","web_url":"https://patchwork.libcamera.org/patch/22299/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241212102415.8057-1-david.plowman@raspberrypi.com>","date":"2024-12-12T10:24:15","name":"ipa: rpi: cam_helper: imx708: Correct the frame integration diff value","commit_ref":"8e15010b7dfa9c2a68dd57f924b5603784be0e09","pull_url":null,"state":"accepted","archived":false,"hash":"6b5cd12d1943028d0adf701b3caad38d67a0a586","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22299/mbox/","series":[{"id":4877,"url":"https://patchwork.libcamera.org/api/series/4877/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4877","date":"2024-12-12T10:24:15","name":"ipa: rpi: cam_helper: imx708: Correct the frame integration diff value","version":1,"mbox":"https://patchwork.libcamera.org/series/4877/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22299/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22299/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5C66C3260\n\tfor ;\n\tThu, 12 Dec 2024 10:24:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F2C867ECC;\n\tThu, 12 Dec 2024 11:24:22 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1995B67EBF\n\tfor ;\n\tThu, 12 Dec 2024 11:24:20 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-4361d5dcf5bso4517475e9.3\n\tfor ;\n\tThu, 12 Dec 2024 02:24:20 -0800 (PST)","from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:c68a:6be1:5ba3:eddd])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-436255800f6sm12051855e9.18.2024.12.12.02.24.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Dec 2024 02:24:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"oSNecjB1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733999059; x=1734603859;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=5mcXS7UEHS3XMI0dNWbg+zMcd+IAmgGQoEiI5dQqKU8=;\n\tb=oSNecjB1aBMUjxlQGC87QanEEaMCW2vhRTcdpHDDn42yz7eOiY6wqbvnlydiPDAL87\n\teV6bj2Fp673G4q0NCmarD+8jjDpYycyeqiEwuDb6bGxNU/tXj48icqMC2UELsmWcx5p3\n\t6NoH7MKenNCR7Bhb+LyUPR/emwr9v+OafFl5iFiAM7ISsPJSyDO0wSeHOFTa0MjkLYec\n\t0Yv2fODvk9fay8MFNjVoLvLsFPVW4v0nJtxXtUxRULkIegEUNCjy/tI30E+sSu1tE3x9\n\t10A1yo9a9Vjnzwqabmmrx6Gri2L4P4OH1wR1CYcaS2KyQT+APGhu8OkQr58pIz/jGqxN\n\tQ4FA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733999059; x=1734603859;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=5mcXS7UEHS3XMI0dNWbg+zMcd+IAmgGQoEiI5dQqKU8=;\n\tb=VwCrQ1Ya/JOY5p+WcPgm/JeuDZJigLrlNKU1AjsohLcdMhY4ScPN4q86ol6QjoACqc\n\tXFqpx5ZeHAYxp5hXv46WzIME993F/zuUufc9ZEatnG+aNBGF6dZLxCqMWqurA8UsCYn7\n\tT5dAA/FuEI4j/pIBEc03y1LqBknOui1UwyeZqEbok7/+htGWvdumIKtNg1BxtwMh4Gbm\n\telI6ZoIynuKoCMZj4tfwK5ST3BBxIjMDLGJVTxg8W0Ld3Ak80CGSrGFpr5mMvpbRN6Ku\n\tKk75ihk0sq3/lxrqIeA/okOYp7sVryurkvSrorEFHfPAHHiTqPeubnapX//xCoQ0jjjS\n\tKK2w==","X-Gm-Message-State":"AOJu0Yzk7JRl6A8t/Ruzd5OepI92sipM1bsh+aBThZBwhFIZF3UfTFuk\n\tm6aNxlTgVQp3lHqBwx4gSerZjY6aTiK5dkPPQJF3/8l1GzmAyY6eLa5gtxwz12V7g0yvcq9+eIc\n\tY","X-Gm-Gg":"ASbGncuorXBjz2CiiwWAUXP64h9rvzlmy7yZJxjXyIo4b+ToZHCIKPkK2XG8+SmF+JC\n\tljrvR+kc5c8ffQodX2tZloaSzyPyXWZ+t5DhpanVwxJ4EmwbYVyHS8qr2K7FfbZSNWW7f4ZJcI6\n\tuLLAcWe2G0ijdOYIJuseQPF0q/0vakKTaEl+An337FT+gsJfgHsacH4wbyravKeiGkwxBKugJMJ\n\t2GJP9pZcejIVUTII0RBO+bEGWpaXMlReEV9U+w+WSFrvHpXic2VzfJFFi4GEC1G9Q4ottBC4kTD\n\tYhst+RUiPXKI","X-Google-Smtp-Source":"AGHT+IHCjxDxwovLD81nZKNE9+S99wMV0W9LOJfeE35jM9+LEuapPtyAqGizOnDTt66KCeBLMCXg0A==","X-Received":"by 2002:a05:600c:3b13:b0:434:f335:849 with SMTP id\n\t5b1f17b1804b1-4362288371emr21994855e9.29.1733999059365; \n\tThu, 12 Dec 2024 02:24:19 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ","Subject":"[PATCH] ipa: rpi: cam_helper: imx708: Correct the frame integration\n\tdiff value","Date":"Thu, 12 Dec 2024 10:24:15 +0000","Message-Id":"<20241212102415.8057-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.5","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This is the minimum permitted difference between the frame length and\ncoarse exposure (both measured in lines). The correct value, taken\nfrom the datasheet, is 48.\n\nSigned-off-by: David Plowman \n---\n src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\nindex ec83d9fd..16a017e9 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n@@ -66,7 +66,7 @@ private:\n \t * Smallest difference between the frame length and integration time,\n \t * in units of lines.\n \t */\n-\tstatic constexpr int frameIntegrationDiff = 22;\n+\tstatic constexpr int frameIntegrationDiff = 48;\n \t/* Maximum frame length allowable for long exposure calculations. */\n \tstatic constexpr int frameLengthMax = 0xffdc;\n \t/* Largest long exposure scale factor given as a left shift on the frame length. */\n","prefixes":[]}