[{"id":32682,"web_url":"https://patchwork.libcamera.org/comment/32682/","msgid":"<20241211164703.GD24546@pendragon.ideasonboard.com>","date":"2024-12-11T16:47:03","subject":"Re: [PATCH v1 2/3] libcamera: virtual: Query number of planes\n\tcorrectly","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Wed, Dec 11, 2024 at 03:25:50PM +0000, Barnabás Pőcze wrote:\n> `PixelFormatInfo::planes.size()` always returns 3 since `planes` is\n> an array, but that is not the number of planes of the pixel format.\n> Use the `numPlanes()` getter instead.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\n> index 3126bdd7d..aae94efee 100644\n> --- a/src/libcamera/pipeline/virtual/virtual.cpp\n> +++ b/src/libcamera/pipeline/virtual/virtual.cpp\n> @@ -278,7 +278,7 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n> \n> \tstd::vector planeSizes;\n> -\tfor (size_t i = 0; i < info.planes.size(); ++i)\n> +\tfor (size_t i = 0; i < info.numPlanes(); ++i)\n> \t\tplaneSizes.push_back(info.planeSize(config.size, i));\n> \n> \treturn dmaBufAllocator_.exportBuffers(config.bufferCount, planeSizes, buffers);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9CACBD80A\n\tfor ;\n\tWed, 11 Dec 2024 16:47:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03F0967EB2;\n\tWed, 11 Dec 2024 17:47:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3B5E618AE\n\tfor ;\n\tWed, 11 Dec 2024 17:47:19 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B5A021C;\n\tWed, 11 Dec 2024 17:46:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lTuS3GYb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733935606;\n\tbh=nBHCFHgssHIYlwvjsudKA8qdf554yBBxZvjt5JgPi6s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lTuS3GYbCxRwwNMgdyDccDuZ9jHXX956SWbzvF3tQcgScTENi9zBFpeZJAfaG74q7\n\tpm6yrS2Ef93XtHUI+kzgJMc1CrUVUmO86aGACoRyTQFBRS5oJI5pkfRAm9YVHImamC\n\t4YP/fzyS+kEC1QFhsgaLAo7blgCr3ia0NtJYd41w=","Date":"Wed, 11 Dec 2024 18:47:03 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 2/3] libcamera: virtual: Query number of planes\n\tcorrectly","Message-ID":"<20241211164703.GD24546@pendragon.ideasonboard.com>","References":"<20241211152542.1095857-1-pobrn@protonmail.com>\n\t<20241211152542.1095857-2-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241211152542.1095857-2-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32823,"web_url":"https://patchwork.libcamera.org/comment/32823/","msgid":"<173445173824.32744.2522869690786768844@ping.linuxembedded.co.uk>","date":"2024-12-17T16:08:58","subject":"Re: [PATCH v1 2/3] libcamera: virtual: Query number of planes\n\tcorrectly","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-12-11 15:25:50)\n> `PixelFormatInfo::planes.size()` always returns 3 since `planes` is\n> an array, but that is not the number of planes of the pixel format.\n> Use the `numPlanes()` getter instead.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\n> index 3126bdd7d..aae94efee 100644\n> --- a/src/libcamera/pipeline/virtual/virtual.cpp\n> +++ b/src/libcamera/pipeline/virtual/virtual.cpp\n> @@ -278,7 +278,7 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,\n> const PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n> \n> std::vector planeSizes;\n> - for (size_t i = 0; i < info.planes.size(); ++i)\n> + for (size_t i = 0; i < info.numPlanes(); ++i)\n> planeSizes.push_back(info.planeSize(config.size, i));\n> \n> return dmaBufAllocator_.exportBuffers(config.bufferCount, planeSizes, buffers);\n> -- \n> 2.47.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57E74C32F6\n\tfor ;\n\tTue, 17 Dec 2024 16:09:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A13C67FE2;\n\tTue, 17 Dec 2024 17:09:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3015D67FDD\n\tfor ;\n\tTue, 17 Dec 2024 17:09:01 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBDB64C7;\n\tTue, 17 Dec 2024 17:08:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sWPZGvwT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734451704;\n\tbh=hpjmHHBUPEQBAwlpfW40LrGTG/Y1NPLjLrL9dAw7UxQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=sWPZGvwTgkF/4+4C6vKaeH2kNPu0t0KmLkqBtN0QV7/uJrGd9QDmhcTX6HAnnWyRu\n\t6g6tXo0lC8JqHZh/2bfDUGwcDB1puY8tgoCdA935DcSeGlIWX22oVfNOS/jL1+yiAk\n\t+Yyu0bqzz7kVhIYBevi1leNl3PeOdLKCbAWDBOv0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241211152542.1095857-2-pobrn@protonmail.com>","References":"<20241211152542.1095857-1-pobrn@protonmail.com>\n\t<20241211152542.1095857-2-pobrn@protonmail.com>","Subject":"Re: [PATCH v1 2/3] libcamera: virtual: Query number of planes\n\tcorrectly","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 Dec 2024 16:08:58 +0000","Message-ID":"<173445173824.32744.2522869690786768844@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]