{"id":22288,"url":"https://patchwork.libcamera.org/api/patches/22288/?format=json","web_url":"https://patchwork.libcamera.org/patch/22288/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241211152542.1095857-1-pobrn@protonmail.com>","date":"2024-12-11T15:25:45","name":"[v1,1/3] libcamera: virtual: Avoid some copies","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"adaa35b809edf0c67079f01483e777bdb848f499","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22288/mbox/","series":[{"id":4874,"url":"https://patchwork.libcamera.org/api/series/4874/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4874","date":"2024-12-11T15:25:45","name":"[v1,1/3] libcamera: virtual: Avoid some copies","version":1,"mbox":"https://patchwork.libcamera.org/series/4874/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22288/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22288/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D96BCBD80A\n\tfor ;\n\tWed, 11 Dec 2024 15:25:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE93B618AE;\n\tWed, 11 Dec 2024 16:25:52 +0100 (CET)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF953618AE\n\tfor ;\n\tWed, 11 Dec 2024 16:25:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"BcIHm8Qu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1733930750; x=1734189950;\n\tbh=TGWjDxXM60xccBAJlriHxnD/+p3vnWahO7X0XBWXAWc=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=BcIHm8Qutz+iB3OXPnV1+gzw8YdfxorzxrLx4tzQSZNeLisH78xUXMij0uaSw5GY3\n\tgjr7pBoBL0i8mRt/vDYL3Gap7PxQ6xNmNQ36IufrHAlhQV6TyS9sqZiAyZV7U6x86f\n\tgOPXaeHVib3tgCu6/NzO89/Ks3FKvPLIhODTX1aWB1rCHkY51UDygIMPRsC8mLY6yD\n\t+JfK9LR/Jf/BUqcAola9Topwah0/W+WZjHG6JbQ0G3twKEcfXSvBX3ulVidR2l1GHU\n\tyo2jnad0wk5WJZy3H42xiCthnYGY4M1OiQO/UkeuRXdTUoIXcX8upruDcR95PoMCaS\n\t4Tz8R17kZctvA==","Date":"Wed, 11 Dec 2024 15:25:45 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1 1/3] libcamera: virtual: Avoid some copies","Message-ID":"<20241211152542.1095857-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"74cf5cd1adcf4322cd9da40c46e28a2097628f84","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason make copies, these functions return\nconst lvalue references, access the data through those.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/virtual/image_frame_generator.cpp | 2 +-\n src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 2 +-\n src/libcamera/pipeline/virtual/virtual.cpp | 3 +--\n 3 files changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.cpp b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\nindex 277efbb09..d1545b5d9 100644\n--- a/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n@@ -129,7 +129,7 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff\n \n \tMappedFrameBuffer mappedFrameBuffer(buffer, MappedFrameBuffer::MapFlag::Write);\n \n-\tauto planes = mappedFrameBuffer.planes();\n+\tconst auto &planes = mappedFrameBuffer.planes();\n \n \t/* Loop only around the number of images available */\n \tframeIndex_ %= imageFrameDatas_.size();\ndiff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\nindex 7bc2b338c..47d341919 100644\n--- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n@@ -25,7 +25,7 @@ int TestPatternGenerator::generateFrame(const Size &size,\n \tMappedFrameBuffer mappedFrameBuffer(buffer,\n \t\t\t\t\t MappedFrameBuffer::MapFlag::Write);\n \n-\tauto planes = mappedFrameBuffer.planes();\n+\tconst auto &planes = mappedFrameBuffer.planes();\n \n \tshiftLeft(size);\n \ndiff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex 1b7cd5cb3..3126bdd7d 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -275,8 +275,7 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,\n \t\treturn -ENOBUFS;\n \n \tconst StreamConfiguration &config = stream->configuration();\n-\n-\tauto info = PixelFormatInfo::info(config.pixelFormat);\n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n \n \tstd::vector planeSizes;\n \tfor (size_t i = 0; i < info.planes.size(); ++i)\n","prefixes":["v1","1/3"]}