{"id":22286,"url":"https://patchwork.libcamera.org/api/patches/22286/?format=json","web_url":"https://patchwork.libcamera.org/patch/22286/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241211041617.1979087-1-chenghaoyang@chromium.org>","date":"2024-12-11T04:16:08","name":"[v2] DmaBufAllocator: Make DmaSyncer non-copyable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0a07e3f7fd683bd35f300182937b7c6bf69f679f","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22286/mbox/","series":[{"id":4872,"url":"https://patchwork.libcamera.org/api/series/4872/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4872","date":"2024-12-11T04:16:08","name":"[v2] DmaBufAllocator: Make DmaSyncer non-copyable","version":2,"mbox":"https://patchwork.libcamera.org/series/4872/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22286/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22286/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9C86BD80A\n\tfor ;\n\tWed, 11 Dec 2024 04:16:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDD0A67E95;\n\tWed, 11 Dec 2024 05:16:43 +0100 (CET)","from mail-pl1-x634.google.com (mail-pl1-x634.google.com\n\t[IPv6:2607:f8b0:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56EB0618AA\n\tfor ;\n\tWed, 11 Dec 2024 05:16:24 +0100 (CET)","by mail-pl1-x634.google.com with SMTP id\n\td9443c01a7336-2166651f752so23740085ad.3\n\tfor ;\n\tTue, 10 Dec 2024 20:16:24 -0800 (PST)","from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-215f8f29bcbsm97261235ad.262.2024.12.10.20.16.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Dec 2024 20:16:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Fd4O/hgv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1733890582; x=1734495382;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=MUpO+Ayn7Uuo+yrRoTUsvo+gZIvzgEsmVVl5FJlHn28=;\n\tb=Fd4O/hgvWzWEQzvGAELK9gy/4ESRgpcAEeDk5gRUYK2R5EXgr9s5Ls3J8Bj2AJ7GEA\n\tnd4517V8fi0xWPPn1KOw4Tjxf/7URFN9DRwGws8M7nXOQvtfE/pJrZqfKDLzVq6kV5HP\n\tMcP7aNPhPWmMyvE2EKKawE6OUpdDhbzHkZ7zA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733890582; x=1734495382;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=MUpO+Ayn7Uuo+yrRoTUsvo+gZIvzgEsmVVl5FJlHn28=;\n\tb=VNtRkhjvPavj+WSJKK/T6ZPe2WjWz2O8+lx4Ahqz0LjUt7kxZL7cutdX/twmadxFiC\n\tlKRsYVNak8skztcBh5eN8QgUUsAJ285+sHLpi3FzrMsVxsA/rLILCQHyO5Z30JQi3lDx\n\twWHx0Uvs2JN0U1D2ckhNB2pQ/p7fsf5mxJXzCl7f2/XGjY1afCV4I/d4fnVzolIiVZME\n\tx/6EAsLulXWYTE1XT8/izRp1VV+qlNamTJE4SbLU1kfcpuPIqE30Inx+brP2gQpWQBdw\n\tPKAgBApCOEhSGh7klt2uncwXdhBOBbs0afuzusDos2BX5gKxLVswy+awLAfxBSNGHvwA\n\tBnxA==","X-Gm-Message-State":"AOJu0YyiKi+gTLbFfUGYrpIb46/izK/p3WW4taj3KRwJW1mbTKEb2PSA\n\tneKPVo3OiCz+XaBapXEpxO26FYC3QW64lMj70hO703dkJ6/FUQwNCNdcM8yqka48VxkHIWGktpk\n\t=","X-Gm-Gg":"ASbGncuSbHo0JIV+pO/46n+iZD7Ipn27YL/cBnZNdIZ2izipsnfJuMdnaPj1/C7n6U5\n\t9HPCoC1rW0XVJzXK2VrtEdb4QpI8OZLMXi40S0qzla4hw7FrJuxsZ5ocnvyWtyltK81v+kgn/Mm\n\t/KzeX2qarmAuLZ9YWRvJQgIPo3AW6gVCiaUuDGrMRuSc3uGUfc8CSyQFI5AtAK/IOHO/u5To66s\n\tudjMrSHilfu3ISWP79S98y70Wp/giieHNMuooSAsqVyRTptdtNHunXiPvtyrnXki8sZOC+nDRZW\n\tnHz4YNx6HdsHvAr8V3BerA0HSeVe8KptI9ygL9QDmXQQAYkn00SwPVDyVizZ","X-Google-Smtp-Source":"AGHT+IHhNxwcJwJqLfD/+DwVZi87nNKCmcSQbih5fK//khxHatKHE5t/4cFFMZfRYo8OuAMfywQjaQ==","X-Received":"by 2002:a17:903:2282:b0:215:431f:268f with SMTP id\n\td9443c01a7336-217783984bbmr28202925ad.10.1733890582220; \n\tTue, 10 Dec 2024 20:16:22 -0800 (PST)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tKieran Bingham ","Subject":"[PATCH v2] DmaBufAllocator: Make DmaSyncer non-copyable","Date":"Wed, 11 Dec 2024 04:16:08 +0000","Message-ID":"<20241211041617.1979087-1-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.47.0.338.g60cca15819-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As DmaSyncer does sync start/end in the c'tor/d'tor, copying a DmaSyncer\ninstance would trigger sync end earlier than expected. This patch makes\nit non-copyable to avoid the issue.\n\nFixes: 39482d59fe71 (\"DmaBufAllocator: Add Dma Buffer synchronization function & helper class\")\nSigned-off-by: Harvey Yang \nReviewed-by: Kieran Bingham \n---\n include/libcamera/internal/dma_buf_allocator.h | 5 +++++\n src/libcamera/dma_buf_allocator.cpp | 10 ++++++++++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\nindex fc5de2c13edd..0cb20963098c 100644\n--- a/include/libcamera/internal/dma_buf_allocator.h\n+++ b/include/libcamera/internal/dma_buf_allocator.h\n@@ -60,9 +60,14 @@ public:\n \n \texplicit DmaSyncer(SharedFD fd, SyncType type = SyncType::ReadWrite);\n \n+\tDmaSyncer(DmaSyncer &&) = default;\n+\tDmaSyncer &operator=(DmaSyncer &&) = default;\n+\n \t~DmaSyncer();\n \n private:\n+\tLIBCAMERA_DISABLE_COPY(DmaSyncer)\n+\n \tvoid sync(uint64_t step);\n \n \tSharedFD fd_;\ndiff --git a/src/libcamera/dma_buf_allocator.cpp b/src/libcamera/dma_buf_allocator.cpp\nindex 3cc52f9686b0..5f517828d960 100644\n--- a/src/libcamera/dma_buf_allocator.cpp\n+++ b/src/libcamera/dma_buf_allocator.cpp\n@@ -311,6 +311,16 @@ DmaSyncer::DmaSyncer(SharedFD fd, SyncType type)\n \tsync(DMA_BUF_SYNC_START);\n }\n \n+/**\n+ * \\fn DmaSyncer::DmaSyncer(DmaSyncer &&) = default;\n+ * \\brief Enable move on class DmaSyncer\n+ */\n+\n+/**\n+ * \\fn DmaSyncer::operator=(DmaSyncer &&) = default;\n+ * \\brief Enable move on class DmaSyncer\n+ */\n+\n DmaSyncer::~DmaSyncer()\n {\n \tsync(DMA_BUF_SYNC_END);\n","prefixes":["v2"]}