[{"id":32986,"web_url":"https://patchwork.libcamera.org/comment/32986/","msgid":"<173644328815.3771432.10568648867989523235@ping.linuxembedded.co.uk>","date":"2025-01-09T17:21:28","subject":"Re: [PATCH v3 7/9] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-12-10 15:34:37)\n> For performance reasons, color correction matrix (CCM) is not applied by\n> default in software ISP. But let's add a commented out example how to\n> define it to the default tuning file.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/data/uncalibrated.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n> index 3f147112..8df3cd4e 100644\n> --- a/src/ipa/simple/data/uncalibrated.yaml\n> +++ b/src/ipa/simple/data/uncalibrated.yaml\n> @@ -5,6 +5,13 @@ version: 1\n> algorithms:\n> - BlackLevel:\n> - Awb:\n> + # Color correction matrices can be defined here:\n> + # - Ccm:\n> + # ccms:\n> + # - ct: 6500\n> + # ccm: [ 1, 0, 0,\n> + # 0, 1, 0,\n> + # 0, 0, 1]\n\nCan't really 'review' that - it's only adding a comment, but I can say\nthis ;-)\n\n\nAcked-by: Kieran Bingham \n\nThat said - should the example show multiple ccms ? but that doesn't\nmatter too much - it would be expected to be written by the tuning tool.\n\nso maybe this isn't \"needed\" but I can see a benefit to having it for\ndevelopment purposes for now ?\n\nSo - I'm not sure if we should apply this patch or not - but it's\ndefinitely useful in case someone is trying to play around with ccm for\nthe short term.\n\n\n> - Lut:\n> - Agc:\n> ...\n> -- \n> 2.44.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBB75C32EF\n\tfor ;\n\tThu, 9 Jan 2025 17:21:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6506684EA;\n\tThu, 9 Jan 2025 18:21:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A73B61880\n\tfor ;\n\tThu, 9 Jan 2025 18:21:30 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF9629FC;\n\tThu, 9 Jan 2025 18:20:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mJYj+jUS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736443236;\n\tbh=EkKdUBpCHup0CcwtVyp1y9dKkoP3giJ/zGeJA005Vdo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mJYj+jUSQkCPlNqgF5ZMVC6J+DOObW2mn/64k6t4gwajvmZiie55+8mB+XkCfdD9H\n\tuoLiFbdFBwfseNT6QzZ+JLsuALPwxbSI2BVeUs2oSqiAt4RzcQOdzoewnd1BSzyIsx\n\thENnX7A2R4b1CfWeFkqecOSpZ/CrVuVN59BIBIgI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241210153440.1007470-8-mzamazal@redhat.com>","References":"<20241210153440.1007470-1-mzamazal@redhat.com>\n\t<20241210153440.1007470-8-mzamazal@redhat.com>","Subject":"Re: [PATCH v3 7/9] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tRobert Mader ,\n\tHans de Goede , \n\tLaurent Pinchart ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 09 Jan 2025 17:21:28 +0000","Message-ID":"<173644328815.3771432.10568648867989523235@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33024,"web_url":"https://patchwork.libcamera.org/comment/33024/","msgid":"<854j26o5sk.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","date":"2025-01-10T18:57:47","subject":"Re: [PATCH v3 7/9] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Kieran,\n\nthank you for review.\n\nKieran Bingham writes:\n\n> Quoting Milan Zamazal (2024-12-10 15:34:37)\n>> For performance reasons, color correction matrix (CCM) is not applied by\n>> default in software ISP. But let's add a commented out example how to\n>\n>> define it to the default tuning file.\n>> \n>> Signed-off-by: Milan Zamazal \n>> ---\n>> src/ipa/simple/data/uncalibrated.yaml | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>> \n>> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n>> index 3f147112..8df3cd4e 100644\n>> --- a/src/ipa/simple/data/uncalibrated.yaml\n>> +++ b/src/ipa/simple/data/uncalibrated.yaml\n>> @@ -5,6 +5,13 @@ version: 1\n>> algorithms:\n>> - BlackLevel:\n>> - Awb:\n>> + # Color correction matrices can be defined here:\n>> + # - Ccm:\n>> + # ccms:\n>> + # - ct: 6500\n>> + # ccm: [ 1, 0, 0,\n>> + # 0, 1, 0,\n>> + # 0, 0, 1]\n>\n> Can't really 'review' that - it's only adding a comment, but I can say\n> this ;-)\n>\n>\n> Acked-by: Kieran Bingham \n>\n> That said - should the example show multiple ccms ? but that doesn't\n> matter too much - it would be expected to be written by the tuning tool.\n>\n> so maybe this isn't \"needed\" but I can see a benefit to having it for\n> development purposes for now ?\n\nThe purpose is to provide an easy to use example how to define the CCMs\nfor those who'd like to experiment with them. Simply uncomment it and\nyou can see what happens when CCM is enabled. And then the values can\nbe changed to see the corresponding effects.\n\n> So - I'm not sure if we should apply this patch or not - but it's\n> definitely useful in case someone is trying to play around with ccm for\n> the short term.\n>\n>\n>> - Lut:\n>> - Agc:\n>> ...\n>> -- \n>> 2.44.2\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54B43C32F5\n\tfor ;\n\tFri, 10 Jan 2025 18:57:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8E76684E7;\n\tFri, 10 Jan 2025 19:57:54 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A66E2608AA\n\tfor ;\n\tFri, 10 Jan 2025 19:57:52 +0100 (CET)","from mail-ed1-f72.google.com (mail-ed1-f72.google.com\n\t[209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-272-DalMi5YBNsy7K9JIDR5QSg-1; Fri, 10 Jan 2025 13:57:50 -0500","by mail-ed1-f72.google.com with SMTP id\n\t4fb4d7f45d1cf-5d124077928so1975113a12.0\n\tfor ;\n\tFri, 10 Jan 2025 10:57:49 -0800 (PST)","from mzamazal-thinkpadp1gen3.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-ab2c905ec28sm195243566b.16.2025.01.10.10.57.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 10 Jan 2025 10:57:47 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"R715hg36\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1736535471;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=loP7rXkeftmls0bmldk0LXYkKIGpARAVGs/uYVIyN+I=;\n\tb=R715hg361G6BMUMCYFeYRKkbq81fHvA+F/+HqHC1k8EPtnjtgHHAetp8TMRWMLtjbpOxmz\n\tnPpwxRFv88V91jJjwQkEl1bx7JqxeIMZlW5RPO4jqZlbCX5Xbum6DH4soNExGe0p6iaC5s\n\t8dqLUh/5FAZXUTJPSfNO0H6JVT6xNYU=","X-MC-Unique":"DalMi5YBNsy7K9JIDR5QSg-1","X-Mimecast-MFC-AGG-ID":"DalMi5YBNsy7K9JIDR5QSg","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736535469; x=1737140269;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=loP7rXkeftmls0bmldk0LXYkKIGpARAVGs/uYVIyN+I=;\n\tb=wckjRhDpvSF2SdybPjQMbuNDN6aUsd2kU5gZl3UWvu7gTrRwo8AHCGWTaycMViIY+l\n\tFqOSNJKVEySGowCIotHGJZ/sNW38aEuxGtgiA5+4oWpe8eUQFIZLep0wmvsyDt170DdK\n\tT3mdqkibfx/vjVa5BqAYlX31Q2fiqequhexjLWNrw8Kj1vJJeVkUOM+hEH++cSM8sDby\n\tQ3GaMmf7ihL9YiQbwj6snnXoc7p0fcMsRvQVVWcyTUnJVRjGmqCYLca1Lh7C9RaONBd1\n\tc8TXO11b1ess3X4TJYsHyM3Lf7Ply1Y+AWZgf2k5yHqeU43V9oI6CdFLFINJRs3btATT\n\twb/A==","X-Gm-Message-State":"AOJu0YzOcKpUNr8zYgzYmtWVJRTMWNkDVrRxQ/LLX9iqt8+OYWM07n+K\n\tPjbqgdY9M5gIhHOyb4eKT3dRF6cmIYwsyeIccpITIRFk6QuYGumJUbG3sDUgF4x4UdJnaN6sVaw\n\tSv4dfm4vZblLb3JuRWA9/KMbsMGkdSKXo+cmV/oEAoGAU7+jZUbpMeaHgVdrcig497CN4KPc=","X-Gm-Gg":"ASbGnct/Me2UVbrTD0ct9JqdejQhpxJyZaWM3LGiyCORu+rJo8O304TJM2dxpEivE8+\n\tqMMw/GdJPUcki7Y0QLo6gjqEXw1WSl3vEiBi3ckUR4n0psXfe4YX8P8rq1/6nyeSFXiCTXCLS1t\n\t9KIU1nW8AkvgRMSaJST/Y/kuZh+nVkH2BpY8OURESeWwXkfjfadEYeqYzSkF9luPmaGB+vKQ3v5\n\t8DwpvBLHFnif/3lowWMHmPVMp55b1HXN3KzdPgf9OQMbyWRtvyEqsRqx1/QBPk1Xir6V3IqE1M1\n\tCmazoQXCjTa1oXclxjofyBZuclKrIIbnUg==","X-Received":["by 2002:a17:907:2cc5:b0:aab:cd45:5d3c with SMTP id\n\ta640c23a62f3a-ab2abdbfa0bmr1142537866b.50.1736535468824; \n\tFri, 10 Jan 2025 10:57:48 -0800 (PST)","by 2002:a17:907:2cc5:b0:aab:cd45:5d3c with SMTP id\n\ta640c23a62f3a-ab2abdbfa0bmr1142536466b.50.1736535468430; \n\tFri, 10 Jan 2025 10:57:48 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGaERBujLr0so0qdnGamz8zzaZ/bSlMsr1JxtHkWRQwE+0E6jVyXD8NvQ/lBPCu813zDJ8uKA==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, Robert Mader\n\t, Hans de Goede ,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 7/9] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml","In-Reply-To":"<173644328815.3771432.10568648867989523235@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Thu, 09 Jan 2025 17:21:28 +0000\")","References":"<20241210153440.1007470-1-mzamazal@redhat.com>\n\t<20241210153440.1007470-8-mzamazal@redhat.com>\n\t<173644328815.3771432.10568648867989523235@ping.linuxembedded.co.uk>","Date":"Fri, 10 Jan 2025 19:57:47 +0100","Message-ID":"<854j26o5sk.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"SxbAw2KL6fwGlQLLvYbQeV4x5Nxuiqdjue_wV8uCIMg_1736535469","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]