[{"id":2965,"web_url":"https://patchwork.libcamera.org/comment/2965/","msgid":"<20191026213228.hwl3fjdesgpwj72p@uno.localdomain>","date":"2019-10-26T21:32:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: bound_method: Fix compiler\n\twarning due to unused arguments","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Sun, Oct 27, 2019 at 12:17:43AM +0300, Laurent Pinchart wrote:\n> The BoundStaticMethod::invoke() method is never used, but must still be\n> implemented as the base class defines it as pure virtual. As it doesn't\n> use its arguments, the compiler generates a warning. Fix it.\n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/bound_method.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 54c40fc52e3b..8ebaadbec887 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -119,7 +119,7 @@ public:\n> \tbool match(void (*func)(Args...)) const { return func == func_; }\n>\n> \tvoid activate(Args... args) { (*func_)(args...); }\n> -\tvoid invoke(Args... args) {}\n> +\tvoid invoke(Args...) {}\n>\n> private:\n> \tvoid (*func_)(Args...);\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6675D60C0F\n\tfor ;\n\tSat, 26 Oct 2019 23:30:38 +0200 (CEST)","from uno.localdomain (143.121.2.93.rev.sfr.net [93.2.121.143])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 01D2F240002;\n\tSat, 26 Oct 2019 21:30:36 +0000 (UTC)"],"Date":"Sat, 26 Oct 2019 23:32:28 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191026213228.hwl3fjdesgpwj72p@uno.localdomain>","References":"<20191026211743.12963-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"dgxsvyx47b5cgoqy\"","Content-Disposition":"inline","In-Reply-To":"<20191026211743.12963-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: bound_method: Fix compiler\n\twarning due to unused arguments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 26 Oct 2019 21:30:38 -0000"}}]