[{"id":32980,"web_url":"https://patchwork.libcamera.org/comment/32980/","msgid":"<173644150866.2992722.10342651126529925214@ping.linuxembedded.co.uk>","date":"2025-01-09T16:51:48","subject":"Re: [PATCH v3 3/9] libcamera: software_isp: lut: Remove maybe_unused\n\ton a used argument","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-12-10 15:34:33)\n> `params' argument of Lut::prepare is actually used, let's remove\n> maybe_unused from it.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/simple/algorithms/lut.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index d75ff710..243f0818 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -83,7 +83,7 @@ void Lut::updateGammaTable(IPAContext &context)\n> void Lut::prepare(IPAContext &context,\n> [[maybe_unused]] const uint32_t frame,\n> [[maybe_unused]] IPAFrameContext &frameContext,\n> - [[maybe_unused]] DebayerParams *params)\n> + DebayerParams *params)\n> {\n> /*\n> * Update the gamma table if needed. This means if black level changes\n> -- \n> 2.44.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA5E8C32EA\n\tfor ;\n\tThu, 9 Jan 2025 16:51:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 708AB61884;\n\tThu, 9 Jan 2025 17:51:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8404D61880\n\tfor ;\n\tThu, 9 Jan 2025 17:51:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEE9B110F;\n\tThu, 9 Jan 2025 17:50:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fGgB2zS9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736441458;\n\tbh=eD/t1KseAijH+k+VzntiwTjGhppWpk4rT7oD8TX9M5k=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fGgB2zS98eK0UxFYc0VHWAS4dVJ1AncM47CnKhd/Xfw4DMbruehYun+9XWwMoZT9l\n\tNjkqplVipD8ubxCPQyHIhwSUC0yiEQkK9KBdEi+tgeQc7rNvW/xEFd5wtR2ASXaoWy\n\t7GOiJSuIjOIunKrbKF7buIRxh1GHPb4ykVp0LXKM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241210153440.1007470-4-mzamazal@redhat.com>","References":"<20241210153440.1007470-1-mzamazal@redhat.com>\n\t<20241210153440.1007470-4-mzamazal@redhat.com>","Subject":"Re: [PATCH v3 3/9] libcamera: software_isp: lut: Remove maybe_unused\n\ton a used argument","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tRobert Mader ,\n\tHans de Goede , \n\tLaurent Pinchart ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 09 Jan 2025 16:51:48 +0000","Message-ID":"<173644150866.2992722.10342651126529925214@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]