{"id":22274,"url":"https://patchwork.libcamera.org/api/patches/22274/?format=json","web_url":"https://patchwork.libcamera.org/patch/22274/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241210142557.2886315-7-chenghaoyang@chromium.org>","date":"2024-12-10T14:23:59","name":"[v4,6/7] android: notify CAMERA3_MSG_ERROR_REQUEST out of order","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"457bce82f4725f88fc8800026ff59e1b99763bee","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22274/mbox/","series":[{"id":4870,"url":"https://patchwork.libcamera.org/api/series/4870/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4870","date":"2024-12-10T14:23:53","name":"Refactor Android HAL before supporting partial result","version":4,"mbox":"https://patchwork.libcamera.org/series/4870/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22274/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22274/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12366C3257\n\tfor ;\n\tTue, 10 Dec 2024 14:26:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9C1D67E87;\n\tTue, 10 Dec 2024 15:26:17 +0100 (CET)","from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n\t[IPv6:2607:f8b0:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0A0567E8E\n\tfor ;\n\tTue, 10 Dec 2024 15:26:12 +0100 (CET)","by mail-pg1-x52e.google.com with SMTP id\n\t41be03b00d2f7-7fd2ff40782so3410448a12.2\n\tfor ;\n\tTue, 10 Dec 2024 06:26:12 -0800 (PST)","from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-2ef26ff97f2sm11812053a91.11.2024.12.10.06.26.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Dec 2024 06:26:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"SsSyDbz4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1733840771; x=1734445571;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=FLTZqIt8KEFAnYaGSx3c4gSKC7oTYw6EkdvadMeeIRk=;\n\tb=SsSyDbz4WDublwo8jHRNZ1Y5YaGni4e7t1lDVihO/s02xKr90Iz3mXj678Xkq/xppJ\n\thb1p3zbuEVaE4NQtODVkohvlBelCZGDCcNiB4XqTunLu0MdaQTAprnYwCW9mZ0g0yUi2\n\tukc9cLEocK1sB5AAROXEyzA+077tvTXqnEoxU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733840771; x=1734445571;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=FLTZqIt8KEFAnYaGSx3c4gSKC7oTYw6EkdvadMeeIRk=;\n\tb=eIGbtPMcybzWFaia4+wm5euPFYvoW+Vvjp2wYGHlCmOOxfThK9Rn8w1fo7LfVr6q8+\n\tbF+yM5GBtlpoLzrLNET0V6EAxtNIl0N7DgNPlPhBELHQwv4QDeXkhr8lex9d6clH/Qs8\n\tzXyXlZ6Ij+TTZ4D0Mx4T/eiYlP9kRBAgGiUn6TJ66DwNXjky0A9U/rBqRAWzb8vjduDS\n\tRzgmJ0+8ahHnkrCErRWVfMdjor5jsMC3kEKMQNaY7/SOZcNBRBD7PhMVVf2jqh6oJN3L\n\t1Tyx9fcvQQSqYJrPR08P3kIVcVJF/E8c+httGgZT4ozqKPVtJCOE2p2DK9LRLEVnnAhD\n\t99PA==","X-Gm-Message-State":"AOJu0YwH+EnSjbqsGRDqKRItfxCqOKseudBh0zdKrvy0z7CA+7EgxDEe\n\tp/ooj8Zn/EzPbCN4SJn0RtjqOd7//vmm4ijYhxKm9FRg0q/0uoYe0ffbA38n+sKvKJaKa1qOnTU\n\t=","X-Gm-Gg":"ASbGnctIrcD4nN9p5rSMOPoHhKgQkB7kZOfgPmx19q2DyQrVwUNbWJPa8c4wu6Cog9d\n\txX4ofEDNBgReAaRWhS0EtQogXQPB+Vt2TPJ0DCKQM315xd2g7kUR30HZSGMml6bpW0qLnY2+A7Q\n\ttTU+KdszHmYw71bcMZWhRt0vCPmNWnqRoN8fOuT+jSZ7UEdpM0nf+L8hHOpf/WIFz1pYQhg0Z4l\n\twFjGxKlEYoZ0L6K/Y4Ylm42vUWN7zcZW2SRoG2tkOiE9U7xaVQzGLhS6DFgY0kHcS6AwioQMFic\n\t3qx6FeTNVNNYXZKkpSQXgm8RziUjJotXPE66ti7OBTsPVE45Y/qvlydBOftB","X-Google-Smtp-Source":"AGHT+IF6M579DIVfStKTVeNnIJUYHLFxMaFwGSkzzttNyJUMjFutqo+MY0vju63/d+qq5M2MDo0Vww==","X-Received":"by 2002:a17:90b:5111:b0:2ee:ab29:1482 with SMTP id\n\t98e67ed59e1d1-2efcf18d802mr7692187a91.16.1733840770955; \n\tTue, 10 Dec 2024 06:26:10 -0800 (PST)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHan-Lin Chen ,\n\tJacopo Mondi ","Subject":"[PATCH v4 6/7] android: notify CAMERA3_MSG_ERROR_REQUEST out of\n\torder","Date":"Tue, 10 Dec 2024 14:23:59 +0000","Message-ID":"<20241210142557.2886315-7-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.47.0.338.g60cca15819-goog","In-Reply-To":"<20241210142557.2886315-1-chenghaoyang@chromium.org>","References":"<20241210142557.2886315-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a request hasn't done any processing, CAMERA3_MSG_ERROR_REQUEST and\nthe following process_capture_result don't need to wait for the previous\nrequests' completion. This patch avoids pushing the aborted requests\ninto the request queue.\n\nSigned-off-by: Han-Lin Chen \nCo-developed-by: Harvey Yang \nSigned-off-by: Harvey Yang \nReviewed-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3b10f207e..a95114c8d 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -867,6 +867,8 @@ void CameraDevice::abortRequest(Camera3RequestDescriptor *descriptor) const\n \t\tbuffer.status = StreamBuffer::Status::Error;\n \n \tdescriptor->status_ = Camera3RequestDescriptor::Status::Error;\n+\n+\tsendCaptureResult(descriptor);\n }\n \n bool CameraDevice::isValidRequest(camera3_capture_request_t *camera3Request) const\n@@ -1135,14 +1137,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \tMutexLocker stateLock(stateMutex_);\n \n \tif (state_ == State::Flushing) {\n-\t\tCamera3RequestDescriptor *rawDescriptor = descriptor.get();\n-\t\t{\n-\t\t\tMutexLocker descriptorsLock(descriptorsMutex_);\n-\t\t\tdescriptors_.push(std::move(descriptor));\n-\t\t}\n-\t\tabortRequest(rawDescriptor);\n-\t\tcompleteDescriptor(rawDescriptor);\n-\n+\t\tabortRequest(descriptor.get());\n \t\treturn 0;\n \t}\n \n","prefixes":["v4","6/7"]}