[{"id":32658,"web_url":"https://patchwork.libcamera.org/comment/32658/","msgid":"<173383827789.3135963.17062231120407397459@ping.linuxembedded.co.uk>","date":"2024-12-10T13:44:37","subject":"Re: [PATCH v1 6/6] Documentation: guides: pipeline-handler: Query\n\tpixel formats once","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-12-09 17:48:06)\n> There is no reason to create an entire new copy of the same thing,\n> so use the already existing `formats` object.\n\nIndeed, this one probably also needs an update to the vivid tree.\n\n\nReviewed-by: Kieran Bingham \n\n\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> Documentation/guides/pipeline-handler.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index a798733db..069a69cdd 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -932,9 +932,9 @@ Add the following function implementation to your file:\n> \n> StreamConfiguration &cfg = config_[0];\n> \n> - const std::vector formats = cfg.formats().pixelformats();\n> + const std::vector &formats = cfg.formats().pixelformats();\n> if (std::find(formats.begin(), formats.end(), cfg.pixelFormat) == formats.end()) {\n> - cfg.pixelFormat = cfg.formats().pixelformats()[0];\n> + cfg.pixelFormat = formats[0];\n> LOG(VIVID, Debug) << \"Adjusting format to \" << cfg.pixelFormat.toString();\n> status = Adjusted;\n> }\n> -- \n> 2.47.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCE95BD80A\n\tfor ;\n\tTue, 10 Dec 2024 13:44:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0905867E87;\n\tTue, 10 Dec 2024 14:44:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8429F618AF\n\tfor ;\n\tTue, 10 Dec 2024 14:44:40 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 375F8752;\n\tTue, 10 Dec 2024 14:44:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OcVcL3WT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733838248;\n\tbh=v9I5N2Mfiiez1ZTKccOQoWdEXOEnHQ2ygLhHDbaN++k=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=OcVcL3WTObFwZysJw2cScznLlooN8nImUsuYVpZgopAIF7l73bPfX/PWwT6BMDAAB\n\taW/JZcEWqofEgS2iY9rc6XmEEpyK2hjN0w2zQgaVV9/q1boIq1AEuvgp+TEjAnN0Jg\n\tCxWXzbDlW/cgmePTZC6XUeXLFVoSLjVObVPidRPc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241209174806.283905-6-barnabas.pocze@ideasonboard.com>","References":"<20241209174806.283905-1-barnabas.pocze@ideasonboard.com>\n\t<20241209174806.283905-6-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 6/6] Documentation: guides: pipeline-handler: Query\n\tpixel formats once","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 10 Dec 2024 13:44:37 +0000","Message-ID":"<173383827789.3135963.17062231120407397459@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]