{"id":22267,"url":"https://patchwork.libcamera.org/api/patches/22267/?format=json","web_url":"https://patchwork.libcamera.org/patch/22267/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241209174806.283905-6-barnabas.pocze@ideasonboard.com>","date":"2024-12-09T17:48:06","name":"[v1,6/6] Documentation: guides: pipeline-handler: Query pixel formats once","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"424d70384a40c46056b5cfaf2cf667aec1e1c7d3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22267/mbox/","series":[{"id":4869,"url":"https://patchwork.libcamera.org/api/series/4869/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4869","date":"2024-12-09T17:48:01","name":"[v1,1/6] Documentation: guides: pipeline-handler: Fix camera creation","version":1,"mbox":"https://patchwork.libcamera.org/series/4869/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22267/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22267/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 878A8C32DB\n\tfor ;\n\tMon, 9 Dec 2024 17:48:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2040567E79;\n\tMon, 9 Dec 2024 18:48:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E326B67E71\n\tfor ;\n\tMon, 9 Dec 2024 18:48:12 +0100 (CET)","from pb-laptop.local (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4092C502\n\tfor ;\n\tMon, 9 Dec 2024 18:47:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WJY4vplz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733766461;\n\tbh=+qM61pwwECbpyrxtiqVOfH8Yz4HtnWILUvTD/U3EbIQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=WJY4vplzfGMLbvDglbo+bcUJy0iKX6OHzyzR0q9lls/Z+h1L6HxjIVjTja3slMoCV\n\tKOLmpKS22UgHp07AUficX/ww6aIRQgbI7/NerPziIfp3NQ+fgQ/sKVG2CLxjqBOYXT\n\tMqGJHYtuKC0jA+R+r0nqkd/OAH4mJr3qb3qxnCpc=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1 6/6] Documentation: guides: pipeline-handler: Query pixel\n\tformats once","Date":"Mon, 9 Dec 2024 18:48:06 +0100","Message-ID":"<20241209174806.283905-6-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.47.1","In-Reply-To":"<20241209174806.283905-1-barnabas.pocze@ideasonboard.com>","References":"<20241209174806.283905-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason to create an entire new copy of the same thing,\nso use the already existing `formats` object.\n\nSigned-off-by: Barnabás Pőcze \n---\n Documentation/guides/pipeline-handler.rst | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex a798733db..069a69cdd 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -932,9 +932,9 @@ Add the following function implementation to your file:\n \n StreamConfiguration &cfg = config_[0];\n \n- const std::vector formats = cfg.formats().pixelformats();\n+ const std::vector &formats = cfg.formats().pixelformats();\n if (std::find(formats.begin(), formats.end(), cfg.pixelFormat) == formats.end()) {\n- cfg.pixelFormat = cfg.formats().pixelformats()[0];\n+ cfg.pixelFormat = formats[0];\n LOG(VIVID, Debug) << \"Adjusting format to \" << cfg.pixelFormat.toString();\n status = Adjusted;\n }\n","prefixes":["v1","6/6"]}