[{"id":32655,"web_url":"https://patchwork.libcamera.org/comment/32655/","msgid":"<173383789374.3135963.9007694366579041281@ping.linuxembedded.co.uk>","date":"2024-12-10T13:38:13","subject":"Re: [PATCH v1 3/6] Documentation: guides: pipeline-handler: Fix\n\tconfiguration creation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-12-09 17:48:03)\n> `PipelineHandler::generateConfiguration()` returns an `std::unique_ptr`.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> Documentation/guides/pipeline-handler.rst | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 1574fe738..ec5cf4d55 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -799,8 +799,7 @@ derived class, and assign it to a base class pointer.\n> \n> .. code-block:: cpp\n> \n> - VividCameraData *data = cameraData(camera);\n> - CameraConfiguration *config = new VividCameraConfiguration();\n> + std::unique_ptr config = std::make_unique();\n> \n> A ``CameraConfiguration`` is specific to each pipeline, so you can only create\n> it from the pipeline handler code path. Applications can also generate an empty\n> -- \n> 2.47.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4E66BD80A\n\tfor ;\n\tTue, 10 Dec 2024 13:38:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8843767E86;\n\tTue, 10 Dec 2024 14:38:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55AAD618AF\n\tfor ;\n\tTue, 10 Dec 2024 14:38:16 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A203352;\n\tTue, 10 Dec 2024 14:37:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VZYh/TYY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733837864;\n\tbh=YGtoT9/aZFybLA1u2qlUUFPDHOTeo13ik2XqSqIG7TQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=VZYh/TYYsbUloLRmW9FvqMq2nUgbX6C0ggbfda4mDSVMM1VTrQla6aMt2IjttN215\n\tG89BCg614PmPL+LkPnT3RcIcHUmdro+2ozbSO6fW5EriQmqIQT/NcAAtQL7gbh8WTw\n\t7/Al3ev8jxYv6psLxi4F++6IRXD7OViRdM1g7JAo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241209174806.283905-3-barnabas.pocze@ideasonboard.com>","References":"<20241209174806.283905-1-barnabas.pocze@ideasonboard.com>\n\t<20241209174806.283905-3-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 3/6] Documentation: guides: pipeline-handler: Fix\n\tconfiguration creation","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 10 Dec 2024 13:38:13 +0000","Message-ID":"<173383789374.3135963.9007694366579041281@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]