{"id":22264,"url":"https://patchwork.libcamera.org/api/patches/22264/?format=json","web_url":"https://patchwork.libcamera.org/patch/22264/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241209174806.283905-3-barnabas.pocze@ideasonboard.com>","date":"2024-12-09T17:48:03","name":"[v1,3/6] Documentation: guides: pipeline-handler: Fix configuration creation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4328338c894e2ffd53e5d49323ba86f0f6889088","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22264/mbox/","series":[{"id":4869,"url":"https://patchwork.libcamera.org/api/series/4869/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4869","date":"2024-12-09T17:48:01","name":"[v1,1/6] Documentation: guides: pipeline-handler: Fix camera creation","version":1,"mbox":"https://patchwork.libcamera.org/series/4869/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22264/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22264/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8696BD80A\n\tfor ;\n\tMon, 9 Dec 2024 17:48:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CA1967E73;\n\tMon, 9 Dec 2024 18:48:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3807167E69\n\tfor ;\n\tMon, 9 Dec 2024 18:48:12 +0100 (CET)","from pb-laptop.local (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F9C783D\n\tfor ;\n\tMon, 9 Dec 2024 18:47:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FBTWjL+U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733766460;\n\tbh=TIq/o2U8aiMo7e9ir94fSU/5FtT5nScZxkcpOc3FEAs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FBTWjL+U5lrec0NfA/RmG84Jzgp/so2k9ZmB0PRj3mJt2zgSfVXqMcZTaMoJX+SBw\n\tk2KYQo29INMasX+Q91DSfEERhV3Oe4VDdEQUZIERtbKcUXcQJrXzcfwjFnWb84dGMd\n\tWwt9SaqLdzoW/HJcCPzsLEsWv++qycS0dVMLCrC0=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1 3/6] Documentation: guides: pipeline-handler: Fix\n\tconfiguration creation","Date":"Mon, 9 Dec 2024 18:48:03 +0100","Message-ID":"<20241209174806.283905-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.47.1","In-Reply-To":"<20241209174806.283905-1-barnabas.pocze@ideasonboard.com>","References":"<20241209174806.283905-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`PipelineHandler::generateConfiguration()` returns an `std::unique_ptr`.\n\nSigned-off-by: Barnabás Pőcze \n---\n Documentation/guides/pipeline-handler.rst | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex 1574fe738..ec5cf4d55 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -799,8 +799,7 @@ derived class, and assign it to a base class pointer.\n \n .. code-block:: cpp\n \n- VividCameraData *data = cameraData(camera);\n- CameraConfiguration *config = new VividCameraConfiguration();\n+ std::unique_ptr config = std::make_unique();\n \n A ``CameraConfiguration`` is specific to each pipeline, so you can only create\n it from the pipeline handler code path. Applications can also generate an empty\n","prefixes":["v1","3/6"]}